* [dpdk-dev] [PATCH] test/cmdline: fix memory leak
@ 2021-10-29 11:23 David Marchand
2021-10-29 12:13 ` Olivier Matz
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2021-10-29 11:23 UTC (permalink / raw)
To: dev; +Cc: Olivier Matz, Dmitry Kozlyuk, Zhihong Peng
Previous change wrongly removed a valid cmdline_free().
Fixes: 6ad06203a587 ("cmdline: free on exit")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
app/test/test_cmdline_lib.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test/test_cmdline_lib.c b/app/test/test_cmdline_lib.c
index f238094b07..f50ccdb599 100644
--- a/app/test/test_cmdline_lib.c
+++ b/app/test/test_cmdline_lib.c
@@ -176,6 +176,8 @@ test_cmdline_socket_fns(void)
printf("Error: failed to open /dev/null for reading!");
return -1;
}
+ cmdline_free(cl);
+ cl = NULL;
/* void functions */
cmdline_stdin_exit(NULL);
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] test/cmdline: fix memory leak
2021-10-29 11:23 [dpdk-dev] [PATCH] test/cmdline: fix memory leak David Marchand
@ 2021-10-29 12:13 ` Olivier Matz
2021-11-04 10:08 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2021-10-29 12:13 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Dmitry Kozlyuk, Zhihong Peng
On Fri, Oct 29, 2021 at 01:23:15PM +0200, David Marchand wrote:
> Previous change wrongly removed a valid cmdline_free().
>
> Fixes: 6ad06203a587 ("cmdline: free on exit")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] test/cmdline: fix memory leak
2021-10-29 12:13 ` Olivier Matz
@ 2021-11-04 10:08 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2021-11-04 10:08 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Olivier Matz, Dmitry Kozlyuk, Zhihong Peng
On Fri, Oct 29, 2021 at 2:13 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> On Fri, Oct 29, 2021 at 01:23:15PM +0200, David Marchand wrote:
> > Previous change wrongly removed a valid cmdline_free().
> >
> > Fixes: 6ad06203a587 ("cmdline: free on exit")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-04 10:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-29 11:23 [dpdk-dev] [PATCH] test/cmdline: fix memory leak David Marchand
2021-10-29 12:13 ` Olivier Matz
2021-11-04 10:08 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).