From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82D9CA0C57; Mon, 1 Nov 2021 18:06:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F64F40E28; Mon, 1 Nov 2021 18:06:03 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id D94ED40DF6 for ; Mon, 1 Nov 2021 18:06:02 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id r5so11994791pls.1 for ; Mon, 01 Nov 2021 10:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Jy71HIed4DlfTHj1Eiy+LNHh/v7modpsOXYb/Znmu60=; b=qj6jMCdpfxL7hdihAhl1at0DYNJCV7WIidJ5BXzfCeBDRr2s/1Y9vPg7KhdBen8KFx OlEH1poAGmlpdnXMeuoZjXc+MLoLj07asJnxEIUdf8HydObYICCN2gdxKf7RglCMVChq pPv9Ic9LlNLNM3sXKL6/EGeEoGxfrKfnLQerXwyd7q03AHwJ1ftBFs3mrb4Z75DqX4aF 1m6l4tt4oR4w1p9cYWPlveR704qpzcIEQati4eA+yKh5SWAGr7JP6meQ+4usbm6TbgQk Y5equlfC7YJQIqfvstlOAslO0LRi15d2v7QYXmX6vDTM7QnRldWxImrKC1RGY0+Hkzsk LUmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Jy71HIed4DlfTHj1Eiy+LNHh/v7modpsOXYb/Znmu60=; b=fQtYQ9iBu3B0u6ALYt8Zmqm/2CF6Jcxof3hC+O328uJEuaytSCnDVIXxcd0voXWFhi RL4uxhDIW1ZSIx1scYK0tnoP244SOH5GJfTXW6jFKOqosm76+DnmTDg9eAB+2HSYwNbi qH0T/z9qA0eNt4csK8akbE6xKqbv7RkH0LOH3Oo8R7pDCG9f2hediQwI38v0iF9/ySHf og9e8FI8j8k6e+cwQw9O8CEAwyUx3GUMbJsYiCp51JEDrQ/vDw0HpGlV8SSFja61UkHS ARIExRB0vO8bI4XTwZLje7i1dE9HEKLsefKWqQ2cudjkY6E5Qd9NVLutkOrTjPm7hwpB 87cA== X-Gm-Message-State: AOAM532mXy2UXoSQG73RQnlTcCiCcXDyGbs+NlMGHTBYbQFNkpV0Aj8V 5e9DgnUEeaXj7EI1Rf6G+zZq/OGF+Q9Nog== X-Google-Smtp-Source: ABdhPJxGZDQ+e7hAzN52WKArrlgihjAOHJDbsbA+dgBNn85axovYSyQqGGQrT5f7T3xD1k3kqAedzg== X-Received: by 2002:a17:90b:4a50:: with SMTP id lb16mr173506pjb.37.1635786362011; Mon, 01 Nov 2021 10:06:02 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id ms15sm54374pjb.26.2021.11.01.10.06.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 10:06:01 -0700 (PDT) Date: Mon, 1 Nov 2021 10:05:58 -0700 From: Stephen Hemminger To: Konstantin Ananyev Cc: dev@dpdk.org Message-ID: <20211101100558.6b33a12b@hermes.local> In-Reply-To: <20211101161013.31966-3-konstantin.ananyev@intel.com> References: <20211101145246.23465-1-konstantin.ananyev@intel.com> <20211101161013.31966-1-konstantin.ananyev@intel.com> <20211101161013.31966-3-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/2] bpf: fix convert API can be undefined X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 1 Nov 2021 16:10:13 +0000 Konstantin Ananyev wrote: > rte_bpf_convert() implementation depends on libpcap. > Right now it is defined only when this library is installed and > RTE_PORT_PCAP is defined. > Fix that by providing for such case stub rte_bpf_convert() > implementation that will always return an error. > Also move stub for another function (rte_bpf_elf_load) into > the same place (bpf_stub.c). > > Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF") > > Signed-off-by: Konstantin Ananyev Wouldn't it be better to fail compiling a program using unimplemented calls rather than forcing the user to see a failure later?