From: Tomasz Duszynski <tduszynski@marvell.com>
To: <dev@dpdk.org>
Cc: <jerinj@marvell.com>, Tomasz Duszynski <tduszynski@marvell.com>,
"Jakub Palider" <jpalider@marvell.com>
Subject: [dpdk-dev] [PATCH 3/4] raw/cnxk_bphy: add headers that provide used APIs
Date: Tue, 2 Nov 2021 19:41:33 +0100 [thread overview]
Message-ID: <20211102184134.3012344-4-tduszynski@marvell.com> (raw)
In-Reply-To: <20211102184134.3012344-1-tduszynski@marvell.com>
Generally it is good practice to include all headers that provide APIs
which are being used. This is especially true in situations where 3rd
party apps include our public headers and assume that all should work
out of the box.
Including all headers explicitly helps to achieve that.
Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
---
drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h
index 726ff412a2..cc2372f719 100644
--- a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h
+++ b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h
@@ -5,7 +5,11 @@
#ifndef _CNXK_BPHY_H_
#define _CNXK_BPHY_H_
+#include <stdint.h>
+
+#include <rte_common.h>
#include <rte_dev.h>
+#include <rte_malloc.h>
#include <rte_memcpy.h>
#include <rte_rawdev.h>
--
2.25.1
next prev parent reply other threads:[~2021-11-02 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 18:41 [dpdk-dev] [PATCH 0/4] raw/cnxk_bphy: sync with local changes Tomasz Duszynski
2021-11-02 18:41 ` [dpdk-dev] [PATCH 1/4] raw/cnxk_bphy: remove deps from internal headers Tomasz Duszynski
2021-11-02 18:41 ` [dpdk-dev] [PATCH 2/4] raw/cnxk_bphy: keep leading zero in device name Tomasz Duszynski
2021-11-02 18:41 ` Tomasz Duszynski [this message]
2021-11-02 18:41 ` [dpdk-dev] [PATCH 4/4] doc: add BPHY to the list of platform blocks Tomasz Duszynski
2021-11-03 15:20 ` [dpdk-dev] [PATCH 0/4] raw/cnxk_bphy: sync with local changes Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102184134.3012344-4-tduszynski@marvell.com \
--to=tduszynski@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jpalider@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).