From: Harman Kalra <hkalra@marvell.com>
To: <dev@dpdk.org>, Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>
Cc: Harman Kalra <hkalra@marvell.com>
Subject: [dpdk-dev] [PATCH v2] common/cnxk: fix device MSIX greater than default value
Date: Wed, 3 Nov 2021 13:29:14 +0530 [thread overview]
Message-ID: <20211103075915.109838-1-hkalra@marvell.com> (raw)
In-Reply-To: <20211101174407.81854-1-hkalra@marvell.com>
Handling the case where number of MSIX interrupts are greater
than default value i.e. PLT_MAX_RXTX_INTR_VEC_ID. On PCI probe
device is queried for supported MSIX interrupts, and respective
interrupt resources are reallocated with this value. Same MSIX
count should be used while registering new interrupt vectors.
Fixes: 8cb5d08db940 ("interrupts: extend event list")
Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
V2:
* Corrected fixes commit which actually introduced this issue.
drivers/common/cnxk/roc_irq.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/common/cnxk/roc_irq.c b/drivers/common/cnxk/roc_irq.c
index 3b34467b96..7a24297d72 100644
--- a/drivers/common/cnxk/roc_irq.c
+++ b/drivers/common/cnxk/roc_irq.c
@@ -14,7 +14,8 @@
#include <unistd.h>
#define MSIX_IRQ_SET_BUF_LEN \
- (sizeof(struct vfio_irq_set) + sizeof(int) * (PLT_MAX_RXTX_INTR_VEC_ID))
+ (sizeof(struct vfio_irq_set) + sizeof(int) * \
+ (plt_intr_max_intr_get(intr_handle)))
static int
irq_get_info(struct plt_intr_handle *intr_handle)
@@ -34,7 +35,7 @@ irq_get_info(struct plt_intr_handle *intr_handle)
plt_base_dbg("Flags=0x%x index=0x%x count=0x%x max_intr_vec_id=0x%x",
irq.flags, irq.index, irq.count, PLT_MAX_RXTX_INTR_VEC_ID);
- if (irq.count > PLT_MAX_RXTX_INTR_VEC_ID) {
+ if (irq.count == 0) {
plt_err("HW max=%d > PLT_MAX_RXTX_INTR_VEC_ID: %d", irq.count,
PLT_MAX_RXTX_INTR_VEC_ID);
plt_intr_max_intr_set(intr_handle, PLT_MAX_RXTX_INTR_VEC_ID);
@@ -92,14 +93,6 @@ irq_init(struct plt_intr_handle *intr_handle)
int32_t *fd_ptr;
uint32_t i;
- if (plt_intr_max_intr_get(intr_handle) >
- PLT_MAX_RXTX_INTR_VEC_ID) {
- plt_err("Max_intr=%d greater than PLT_MAX_RXTX_INTR_VEC_ID=%d",
- plt_intr_max_intr_get(intr_handle),
- PLT_MAX_RXTX_INTR_VEC_ID);
- return -ERANGE;
- }
-
len = sizeof(struct vfio_irq_set) +
sizeof(int32_t) * plt_intr_max_intr_get(intr_handle);
--
2.18.0
next prev parent reply other threads:[~2021-11-03 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 17:44 [dpdk-dev] [PATCH] " Harman Kalra
2021-11-03 7:13 ` David Marchand
2021-11-03 7:59 ` Harman Kalra [this message]
2021-11-03 15:10 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103075915.109838-1-hkalra@marvell.com \
--to=hkalra@marvell.com \
--cc=dev@dpdk.org \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).