* [dpdk-dev] [PATCH] kni: update kernel API to set random MAC address
@ 2021-11-03 12:59 Ferruh Yigit
2021-11-08 10:53 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2021-11-03 12:59 UTC (permalink / raw)
To: dev; +Cc: Ferruh Yigit, Thomas Monjalon, Stephen Hemminger
Previously used 'random_ether_addr()' API is removed in upstream kernel
with commit
Commit ba530fea8ca1 ("ethernet: remove random_ether_addr()")
Replacement API 'eth_random_addr()' is around since v3.6 [1], so
simply switching to this API without any version checks.
[1]
0a4dd594982a ("etherdevice: Rename random_ether_addr to eth_random_addr")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
kernel/linux/kni/kni_misc.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
index 2b464c438113..f4944e1ddf33 100644
--- a/kernel/linux/kni/kni_misc.c
+++ b/kernel/linux/kni/kni_misc.c
@@ -399,11 +399,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,
if (is_valid_ether_addr(dev_info.mac_addr))
memcpy(net_dev->dev_addr, dev_info.mac_addr, ETH_ALEN);
else
- /*
- * Generate random mac address. eth_random_addr() is the
- * newer version of generating mac address in kernel.
- */
- random_ether_addr(net_dev->dev_addr);
+ /* Generate random MAC address. */
+ eth_random_addr(net_dev->dev_addr);
if (dev_info.mtu)
net_dev->mtu = dev_info.mtu;
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] kni: update kernel API to set random MAC address
2021-11-03 12:59 [dpdk-dev] [PATCH] kni: update kernel API to set random MAC address Ferruh Yigit
@ 2021-11-08 10:53 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2021-11-08 10:53 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Stephen Hemminger
03/11/2021 13:59, Ferruh Yigit:
> Previously used 'random_ether_addr()' API is removed in upstream kernel
> with commit
> Commit ba530fea8ca1 ("ethernet: remove random_ether_addr()")
>
> Replacement API 'eth_random_addr()' is around since v3.6 [1], so
> simply switching to this API without any version checks.
>
> [1]
> 0a4dd594982a ("etherdevice: Rename random_ether_addr to eth_random_addr")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-08 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 12:59 [dpdk-dev] [PATCH] kni: update kernel API to set random MAC address Ferruh Yigit
2021-11-08 10:53 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).