From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4776A0548; Wed, 3 Nov 2021 23:18:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9228A40E0F; Wed, 3 Nov 2021 23:18:07 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 6A03540689 for ; Wed, 3 Nov 2021 23:18:06 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id y1so3872228plk.10 for ; Wed, 03 Nov 2021 15:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DgZJbPCRioB9z7AzKM7apzFdcACzzS+s1aYZJfIomkk=; b=z8ZEr+cHzy3oY2cKvAdi8tXrcJioX0xjiKTp+SsRQNOHp/TQtpzF1jrV+0Vw5Y7JVL c/m91ukClON9gmqmAiLCElEBmhKfw96vVyF1VYksdMmKas1cXb2AUz+kznHmxuDmpxeh DFjUJWRh3cIKDyzrZUSYP0Vc0ykcVf+ZVavMEMKqiNZHaRKSTqmBX08loLMCWdwcwSRA 1XxVw9xbMMtsAo2Xk7BdbvpIj/mQtmXdju71XUzOQOhxc96Zv4VSApetgxjtS5PoPrTP sTN4AezYX7M9UnFxlckiLu/E2plpUuPVOem2tV9F00r10oStRnSmYhKFguO/wg+NUdzz pYVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DgZJbPCRioB9z7AzKM7apzFdcACzzS+s1aYZJfIomkk=; b=DV0LCvmDoNhCS3VDzov7sQCEqIoYbLPVh2m0NLJ/cwFTEcnLXRDPRP7GSe4nLpgH4u fNo7mG1xJoI07k5lH30ZKbQvZYOs110cHKxtu0NHX6g1TByjQSxC/2lzTgN99eemvw5x Ao5Yf48WfxyEOJvMcVKnbIiOjw0i15LuqBSPgxPfa3CYswe9e7geP48J96hf6wFC19yt lPCSw50ljFVk/qE8a2rtjWAhwWetfvKGEgb9FAI+uNHhEe8b2deUVpf9f2GR9aiYOoz0 MBPKYdQVoD3c4Vr3xFoYJH2u/sSnUhsF/O8tUpl8YVIA3NIlPmxLc1EF6yLxJlD43YeT HFTw== X-Gm-Message-State: AOAM531vkiGISMseW2pRzw9KqRFlcvVMdfXQws736X16Us0IxPRp8mc5 w2rPlENcsnwSULoCdUajqOJDcA== X-Google-Smtp-Source: ABdhPJyq99qTJ+ZqLkWqCbmEEhL2Hgo12+2I/tNB1dldgCKlK38wetUn5icsIdXj7fZG/U+v2HxMcw== X-Received: by 2002:a17:902:b70f:b0:141:c3e9:a7e3 with SMTP id d15-20020a170902b70f00b00141c3e9a7e3mr29396292pls.25.1635977885517; Wed, 03 Nov 2021 15:18:05 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id h24sm3358495pfn.180.2021.11.03.15.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 15:18:05 -0700 (PDT) Date: Wed, 3 Nov 2021 15:18:02 -0700 From: Stephen Hemminger To: Tudor Cornea Cc: Ferruh Yigit , dev@dpdk.org Message-ID: <20211103151802.5f233118@hermes.local> In-Reply-To: References: <1635849481-47147-1-git-send-email-tudor.cornea@gmail.com> <1635868273-69843-1-git-send-email-tudor.cornea@gmail.com> <20211102085352.374cece8@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] kni: allow configuring the kni thread granularity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 3 Nov 2021 22:40:51 +0200 Tudor Cornea wrote: > On Tue, 2 Nov 2021 at 17:53, Stephen Hemminger > wrote: > > > On Tue, 2 Nov 2021 17:51:13 +0200 > > Tudor Cornea wrote: > > > > > +#ifdef RTE_KNI_PREEMPT_DEFAULT > > > +module_param(min_scheduling_interval, long, 0644); > > > +MODULE_PARM_DESC(min_scheduling_interval, > > > +"Kni thread min scheduling interval (default=100 microseconds):\n" > > > +"\t\t" > > > +); > > > > Why the non-standard newline's and tab's? > > Please try to make KNI look like other kernel code. > > > > Hi Stephen, > > I tried to base the description of the new parameters on an existing > parameter implemented for the rte_kni module - carrier. > > module_param(carrier, charp, 0644); > MODULE_PARM_DESC(carrier, > "Default carrier state for KNI interface (default=off):\n" > "\t\toff Interfaces will be created with carrier state set to off.\n" > "\t\ton Interfaces will be created with carrier state set to on.\n" > "\t\t" > ); > > I thought about keeping the compatibility in terms of coding style with the > existing Kni module parameters. > Upon browsing the Linux tree, I realise it might not be standard ( > checkpatch.pl , interestingly didn't seem to complain about the patch) > > I also realise now, that I missed two tabs at the beginning of the params > description. > Should I add the missing tabs, so that the new parameters that I intend to > add through this patch are similar in style to the existing ones, or should > I remove the newlines and tabs altogether, when specifying the description > for min_scheduling_interval and max_scheduling_interval ? > > Thanks, > Tudor Although KNI is unlikely to ever get upstream code review, there is no reason to deviate from common practice in kernel drivers. The original module parameter was doing something unconventional. Not wrong, just different.