From: David Christensen <drc@linux.vnet.ibm.com>
To: dev@dpdk.org
Cc: thinhtr@linux.vnet.ibm.com, David Christensen <drc@linux.vnet.ibm.com>
Subject: [dpdk-dev] [PATCH] config/ppc: fix meson build failure with gcc 4.8.5 on RHEL/CENTOS7
Date: Wed, 3 Nov 2021 13:01:26 -0700 [thread overview]
Message-ID: <20211103200126.1033026-1-drc@linux.vnet.ibm.com> (raw)
The POWER meson.build file incorrectly checks if the detected CPU is
"greater than" POWER8 when it should actually test for "greater than or
equal to" POWER8. Fixed the comparison operator.
Bugzilla ID: 875
Fixes: 750196880843 ("config/ppc: select instruction set for IBM Power10")
Cc: thinhtr@linux.vnet.ibm.com
Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
config/ppc/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/ppc/meson.build b/config/ppc/meson.build
index cba8222163..1cba44011f 100644
--- a/config/ppc/meson.build
+++ b/config/ppc/meson.build
@@ -89,7 +89,7 @@ int main() {
else
error('Compiler does not support POWER@0@ platform'.format(cpu))
endif
- if cpu > 8
+ if cpu >= 8
cpu_instruction_set = 'power'+cpu.to_string()
else
error('Compiler does not support POWER@0@ platform'.format(cpu))
--
2.27.0
next reply other threads:[~2021-11-03 20:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 20:01 David Christensen [this message]
2021-11-04 8:10 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103200126.1033026-1-drc@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=thinhtr@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).