From: Joyce Kong <joyce.kong@arm.com>
To: Ori Kam <orika@nvidia.com>,
John McNamara <john.mcnamara@intel.com>,
Conor Fogarty <conor.fogarty@intel.com>,
Conor Walsh <conor.walsh@intel.com>
Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] examples/flow_filtering: fix wrong comment
Date: Thu, 4 Nov 2021 02:32:20 -0500 [thread overview]
Message-ID: <20211104073220.7938-1-joyce.kong@arm.com> (raw)
In-Reply-To: <20211103024103.2420-1-joyce.kong@arm.com>
Change the 'IPV4' level to 'ETH' level in the comment
as it was previously misdescribed.
Fixes: 9a212dc06c7a ("doc: use code snippets in sample app guides")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
doc/guides/sample_app_ug/flow_filtering.rst | 2 +-
examples/flow_filtering/flow_blocks.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/sample_app_ug/flow_filtering.rst b/doc/guides/sample_app_ug/flow_filtering.rst
index 11da9148ca..e8605f36f2 100644
--- a/doc/guides/sample_app_ug/flow_filtering.rst
+++ b/doc/guides/sample_app_ug/flow_filtering.rst
@@ -224,7 +224,7 @@ Setting the first level of the pattern ETH:
.. literalinclude:: ../../../examples/flow_filtering/flow_blocks.c
:language: c
- :start-after: IPv4 we set this level to allow all. 8<
+ :start-after: ETH we set this level to allow all. 8<
:end-before: >8 End of setting the first level of the pattern.
:dedent: 1
diff --git a/examples/flow_filtering/flow_blocks.c b/examples/flow_filtering/flow_blocks.c
index 3251ed9f8f..b168dc6e71 100644
--- a/examples/flow_filtering/flow_blocks.c
+++ b/examples/flow_filtering/flow_blocks.c
@@ -75,7 +75,7 @@ generate_ipv4_flow(uint16_t port_id, uint16_t rx_q,
* ipv4 we set this level to allow all.
*/
- /* IPv4 we set this level to allow all. 8< */
+ /* ETH we set this level to allow all. 8< */
pattern[0].type = RTE_FLOW_ITEM_TYPE_ETH;
/* >8 End of setting the first level of the pattern. */
--
2.17.1
next prev parent reply other threads:[~2021-11-04 7:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 2:41 [dpdk-dev] [PATCH v1] " Joyce Kong
2021-11-03 9:38 ` Walsh, Conor
2021-11-04 7:34 ` Joyce Kong
2021-11-04 9:49 ` Walsh, Conor
2021-11-04 7:32 ` Joyce Kong [this message]
2021-11-04 9:49 ` [dpdk-dev] [PATCH v2] " Walsh, Conor
2021-11-12 6:37 ` [PATCH v3] " Joyce Kong
2021-11-16 15:13 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211104073220.7938-1-joyce.kong@arm.com \
--to=joyce.kong@arm.com \
--cc=conor.fogarty@intel.com \
--cc=conor.walsh@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=nd@arm.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).