* [dpdk-dev] [PATCH] app/testpmd: fix gtp psc extention header length
@ 2021-11-04 9:35 Raslan Darawsheh
2021-11-04 9:40 ` [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension " Raslan Darawsheh
0 siblings, 1 reply; 5+ messages in thread
From: Raslan Darawsheh @ 2021-11-04 9:35 UTC (permalink / raw)
To: dev; +Cc: viacheslavo, stable, Ori Kam, Xiaoyun Li
Current implementation for raw encap sets the length to be in bytes,
but, GTP extention header length is an 8-bit feild in 4-octet units.
This fixes the length calculation of the header length.
Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets")
Cc: viacheslavo@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
app/test-pmd/cmdline_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 24b224e632..b4c5aacdbe 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in)
uint8_t qfi:6;
uint8_t next;
} psc;
- psc.len = sizeof(psc);
+ psc.len = sizeof(psc) / 4;
psc.pdu_type = opt->hdr.type;
psc.qfi = opt->hdr.qfi;
psc.next = 0;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header length
2021-11-04 9:35 [dpdk-dev] [PATCH] app/testpmd: fix gtp psc extention header length Raslan Darawsheh
@ 2021-11-04 9:40 ` Raslan Darawsheh
2021-11-15 19:02 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Raslan Darawsheh @ 2021-11-04 9:40 UTC (permalink / raw)
To: dev; +Cc: viacheslavo, stable, Ori Kam, Xiaoyun Li
Current implementation for raw encap sets the length to be in bytes,
but, GTP 'extension' header length is an 8-bit field in 4-octet units.
This fixes the length calculation of the header length.
Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets")
Cc: viacheslavo@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
v2: fix spelling issues
---
app/test-pmd/cmdline_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 24b224e632..b4c5aacdbe 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in)
uint8_t qfi:6;
uint8_t next;
} psc;
- psc.len = sizeof(psc);
+ psc.len = sizeof(psc) / 4;
psc.pdu_type = opt->hdr.type;
psc.qfi = opt->hdr.qfi;
psc.next = 0;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header length
2021-11-04 9:40 ` [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension " Raslan Darawsheh
@ 2021-11-15 19:02 ` Ferruh Yigit
2021-11-16 13:42 ` Slava Ovsiienko
0 siblings, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2021-11-15 19:02 UTC (permalink / raw)
To: Raslan Darawsheh, Ori Kam, viacheslavo; +Cc: stable, Xiaoyun Li, dev
On 11/4/2021 9:40 AM, Raslan Darawsheh wrote:
> Current implementation for raw encap sets the length to be in bytes,
> but, GTP 'extension' header length is an 8-bit field in 4-octet units.
>
> This fixes the length calculation of the header length.
>
> Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets")
> Cc: viacheslavo@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> ---
> v2: fix spelling issues
> ---
> app/test-pmd/cmdline_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 24b224e632..b4c5aacdbe 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in)
> uint8_t qfi:6;
> uint8_t next;
> } psc;
> - psc.len = sizeof(psc);
> + psc.len = sizeof(psc) / 4;
> psc.pdu_type = opt->hdr.type;
> psc.qfi = opt->hdr.qfi;
> psc.next = 0;
>
Hi Ori, Slava,
Can you please review this patch?
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header length
2021-11-15 19:02 ` Ferruh Yigit
@ 2021-11-16 13:42 ` Slava Ovsiienko
2021-11-16 14:27 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Slava Ovsiienko @ 2021-11-16 13:42 UTC (permalink / raw)
To: Ferruh Yigit, Raslan Darawsheh, Ori Kam; +Cc: stable, Xiaoyun Li, dev
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, November 15, 2021 21:02
> To: Raslan Darawsheh <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: stable@dpdk.org; Xiaoyun Li <xiaoyun.li@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header
> length
>
> On 11/4/2021 9:40 AM, Raslan Darawsheh wrote:
> > Current implementation for raw encap sets the length to be in bytes,
> > but, GTP 'extension' header length is an 8-bit field in 4-octet units.
> >
> > This fixes the length calculation of the header length.
> >
> > Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw
> > sets")
> > Cc: viacheslavo@nvidia.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> > ---
> > v2: fix spelling issues
> > ---
> > app/test-pmd/cmdline_flow.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> > index 24b224e632..b4c5aacdbe 100644
> > --- a/app/test-pmd/cmdline_flow.c
> > +++ b/app/test-pmd/cmdline_flow.c
> > @@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in)
> > uint8_t qfi:6;
> > uint8_t next;
> > } psc;
> > - psc.len = sizeof(psc);
> > + psc.len = sizeof(psc) / 4;
> > psc.pdu_type = opt->hdr.type;
> > psc.qfi = opt->hdr.qfi;
> > psc.next = 0;
> >
>
> Hi Ori, Slava,
>
> Can you please review this patch?
Looks good to me.
Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header length
2021-11-16 13:42 ` Slava Ovsiienko
@ 2021-11-16 14:27 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2021-11-16 14:27 UTC (permalink / raw)
To: Slava Ovsiienko, Raslan Darawsheh, Ori Kam; +Cc: stable, Xiaoyun Li, dev
On 11/16/2021 1:42 PM, Slava Ovsiienko wrote:
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, November 15, 2021 21:02
>> To: Raslan Darawsheh <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>;
>> Slava Ovsiienko <viacheslavo@nvidia.com>
>> Cc: stable@dpdk.org; Xiaoyun Li <xiaoyun.li@intel.com>; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header
>> length
>>
>> On 11/4/2021 9:40 AM, Raslan Darawsheh wrote:
>>> Current implementation for raw encap sets the length to be in bytes,
>>> but, GTP 'extension' header length is an 8-bit field in 4-octet units.
>>>
>>> This fixes the length calculation of the header length.
>>>
>>> Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw
>>> sets")
>>> Cc: viacheslavo@nvidia.com
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
>
>
> Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-16 14:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 9:35 [dpdk-dev] [PATCH] app/testpmd: fix gtp psc extention header length Raslan Darawsheh
2021-11-04 9:40 ` [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension " Raslan Darawsheh
2021-11-15 19:02 ` Ferruh Yigit
2021-11-16 13:42 ` Slava Ovsiienko
2021-11-16 14:27 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).