From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29F93A0C56; Fri, 5 Nov 2021 03:49:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1672E4111A; Fri, 5 Nov 2021 03:49:09 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id A581240689 for ; Fri, 5 Nov 2021 03:49:02 +0100 (CET) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HllM65TSJz90nQ for ; Fri, 5 Nov 2021 10:48:50 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.15; Fri, 5 Nov 2021 10:49:00 +0800 From: "Min Hu (Connor)" To: CC: , Date: Fri, 5 Nov 2021 10:46:55 +0800 Message-ID: <20211105024657.60302-8-humin29@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211105024657.60302-1-humin29@huawei.com> References: <20211102031729.35536-1-humin29@huawei.com> <20211105024657.60302-1-humin29@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH v2 7/9] net/hns3: remove magic numbers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Huisong Li Removing magic numbers with macros. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c | 4 ++-- drivers/net/hns3/hns3_common.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c index 5fe0ff5ce7..290999f594 100644 --- a/drivers/net/hns3/hns3_common.c +++ b/drivers/net/hns3/hns3_common.c @@ -54,7 +54,7 @@ hns3_parse_dev_caps_mask(const char *key, const char *value, void *extra_args) RTE_SET_USED(key); - val = strtoull(value, NULL, 16); + val = strtoull(value, NULL, HNS3_CONVERT_TO_HEXADECIMAL); *(uint64_t *)extra_args = val; return 0; @@ -67,7 +67,7 @@ hns3_parse_mbx_time_limit(const char *key, const char *value, void *extra_args) RTE_SET_USED(key); - val = strtoul(value, NULL, 10); + val = strtoul(value, NULL, HNS3_CONVERT_TO_DECIMAL); if (val > HNS3_MBX_DEF_TIME_LIMIT_MS && val <= UINT16_MAX) *(uint16_t *)extra_args = val; diff --git a/drivers/net/hns3/hns3_common.h b/drivers/net/hns3/hns3_common.h index 094a0bc5ff..68f9b1b96a 100644 --- a/drivers/net/hns3/hns3_common.h +++ b/drivers/net/hns3/hns3_common.h @@ -9,6 +9,9 @@ #include "hns3_ethdev.h" +#define HNS3_CONVERT_TO_DECIMAL 10 +#define HNS3_CONVERT_TO_HEXADECIMAL 16 + enum { HNS3_IO_FUNC_HINT_NONE = 0, HNS3_IO_FUNC_HINT_VEC, -- 2.33.0