From: Ali Alnubani <alialnu@nvidia.com>
To: <dev@dpdk.org>
Cc: <wojciechx.liguzinski@intel.com>
Subject: [dpdk-dev] [PATCH] sched: fix build with debug enabled
Date: Sun, 7 Nov 2021 18:30:54 +0200 [thread overview]
Message-ID: <20211107163054.2745624-1-alialnu@nvidia.com> (raw)
Compare pkt_len to 0 instead of NULL to avoid the following build
failure with debug mode enabled:
../lib/sched/rte_pie.h: In function 'rte_pie_enqueue_empty':
../lib/sched/rte_pie.h:125:21: error: comparison between pointer
and integer [-Werror]
RTE_ASSERT(pkt_len != NULL);
Bugzilla ID: 878
Fixes: 44c730b0e379 ("sched: add PIE based congestion management")
Cc: wojciechx.liguzinski@intel.com
Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
lib/sched/rte_pie.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/sched/rte_pie.h b/lib/sched/rte_pie.h
index a3441ffe51..dfdf572311 100644
--- a/lib/sched/rte_pie.h
+++ b/lib/sched/rte_pie.h
@@ -122,7 +122,7 @@ rte_pie_enqueue_empty(const struct rte_pie_config *pie_cfg,
struct rte_pie *pie,
uint32_t pkt_len)
{
- RTE_ASSERT(pkt_len != NULL);
+ RTE_ASSERT(pkt_len != 0);
/* Update the PIE qlen parameter */
pie->qlen++;
--
2.25.1
next reply other threads:[~2021-11-07 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 16:30 Ali Alnubani [this message]
2021-11-07 17:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211107163054.2745624-1-alialnu@nvidia.com \
--to=alialnu@nvidia.com \
--cc=dev@dpdk.org \
--cc=wojciechx.liguzinski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).