From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 800A0A0C52; Sun, 7 Nov 2021 17:31:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1605D40151; Sun, 7 Nov 2021 17:31:42 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2052.outbound.protection.outlook.com [40.107.92.52]) by mails.dpdk.org (Postfix) with ESMTP id D0A0F40040 for ; Sun, 7 Nov 2021 17:31:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jQ0ygXW05a0BmXB3u3M+3VgW5YkuIC8OTTNurH0DquPxmxAPpFNXPR9PQoTdPSrrqD8cY5Jm6VFry+tZSQR/QPCuA5wl4BiIOOe3NM3WYlUt3V09DeUVCDCEW9oneDHU+JZFS0cgmAp4OVgL2xCeqLlsVs1rPYcNopxq5WF8QD9KGR1fTPqOZ4cwsURo9eCBHVYDWOwvCdZJFm3DyjlW48w9qtSWYJzfQBNqBx91oWokhSUhlYVN8+oHqgKO+mv0RI5Zi/rJ2nMu8mtSI9FUWgycsNPD3fPHAz99TVomR+6B/TEbJO5/VJ7mm7c1nMoBkc50o5j8QeaX8IsT5UoKHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yXZgQAbapu1O8Yc2jSn7O8UMgGZ7oBEo9pgTzO+G45I=; b=ikkCG6bj79gbXL3EEjFms7fV4sunEL+9RUhz18zOxRpl+b//yyR0Omo7ZC+Z/+rBL6OFrr9/7pvgKzSN7pDqiOhT4mca0Kt5Z4xCyaLiJkBfMqeucI58fW+BFTc1DYi44V9zYidtPYSe6zLaz19sOYcJSM04ntaPqAmA4+D4YopOthx/fa1AGs5wEXo0peT8vz3ySR80O+6ACEbsBu2T/EzuOeZDGeJoyd/fKTe1wkHvev55UAESh3NX1+BIshipnxt5VtU3oOrlX2xehy+tCDhWr2xrDXVqOekGUbcc35Bk6UU5U3fjh6OvV0EuD+RB+YbDsmDZ+ZE0yFJW3wCAsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yXZgQAbapu1O8Yc2jSn7O8UMgGZ7oBEo9pgTzO+G45I=; b=bGOgeU7uSAx2jvMX0ve8rI3hrByFtaYNtNvr3sNX09VK2RvpVUuB8rrZj2g4Foh2ZNJdUmnpo84cFQfvUuZT4HhH4aMam2SkAMCVviA/Xb9HHzcFCR66kO3UQuQg5uM1tILK3TmJ0fhKdAAfYoUtAj8+zqj6OpODvsOKfk4vxcdTsuuScKR3WyRadC4bxpKQBs1CP/Hx8adp+oUfbPqe4csmSgk254YPuoK0Kf0v7st5Dgv3b8OsaqGXrzKvHWbuZ1Xm+XFvbh90cOv+29XGgVOBOJgNHt5inZ3nwZuLWnTriFT356sNaL6nt3+1y2ALqdH54qkUQUfy4qV66AbZFw== Received: from BN0PR02CA0001.namprd02.prod.outlook.com (2603:10b6:408:e4::6) by BYAPR12MB3334.namprd12.prod.outlook.com (2603:10b6:a03:df::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Sun, 7 Nov 2021 16:31:37 +0000 Received: from BN8NAM11FT005.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e4:cafe::ee) by BN0PR02CA0001.outlook.office365.com (2603:10b6:408:e4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Sun, 7 Nov 2021 16:31:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT005.mail.protection.outlook.com (10.13.176.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Sun, 7 Nov 2021 16:31:36 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 7 Nov 2021 16:31:34 +0000 From: Ali Alnubani To: CC: Date: Sun, 7 Nov 2021 18:30:54 +0200 Message-ID: <20211107163054.2745624-1-alialnu@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08d5fce5-38ec-4728-3ccc-08d9a20c11a0 X-MS-TrafficTypeDiagnostic: BYAPR12MB3334: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1443; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Wtq83heT44rbuaNRG3RZFw4yCAWe9fAvWpmQsU2h3zcZ9bUs0zrXFKc5emV1J4xz5ktTsft7IOCblzZFYFSdOHf8jPl6sI/PSXBVJ6oXpAimwdWLRAZFL7Pbg7CKsmiYlgyG/6akMGTOOe4d3+47gSSPKIAK23FbZQ3cFNihQCpD6VcXR7bWSr77YiyMcIN4bAN/uOF7qcQuuPvEppr8gQvkarathgsWKMmgpUIlJFfZLBDaXClTfJcEsW9JwksYhakx0ymS8P+TbRQ32jVNdVZHoX/BjFtNbtT/r19/2hsB9Ry5RdkJDCq5DBs9wg3P7hkok+xj10ZM+FIvxEA9fWt2AjeePkmGoqmtrerkKpCNHhlwhwKIq8QfKaG1ge7fI2J+hLfT0GCyxEqX0CvBRvsRwQdYBM2PUCWahjZAeP3H268X8ij1FmirHyvDD97YdghZx7do/790Wp3FT5qNhvE9uXJzuVoNo2NbEkMyPidSkL/+jsm7fpya+qeC0Ach3fFVDu/Cb6x+vpfgDeo7h8XMYdpuVShKSHMk3XYgUR142QFOs/h5zo+2bYKPJfZuRmIkN6yIH6FF3kTlaBHGcwGUm0XXRuRlkwIUmPS34W7M2d3sFHMztBMdN89su0eafoUu5sE9lyJw6XANvUM/Xjor2ulvjs/cahMylNWq2DszNDblcB+v+rkmaRsAqCqBvQ2+DB61oMZdVJa+PalhA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(2906002)(82310400003)(508600001)(6666004)(7636003)(186003)(2616005)(47076005)(55016002)(6286002)(8936002)(83380400001)(16526019)(4326008)(356005)(36756003)(86362001)(5660300002)(36860700001)(1076003)(8676002)(70206006)(6916009)(426003)(70586007)(316002)(36906005)(26005)(4744005)(7696005)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2021 16:31:36.6868 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08d5fce5-38ec-4728-3ccc-08d9a20c11a0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT005.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3334 Subject: [dpdk-dev] [PATCH] sched: fix build with debug enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Compare pkt_len to 0 instead of NULL to avoid the following build failure with debug mode enabled: ../lib/sched/rte_pie.h: In function 'rte_pie_enqueue_empty': ../lib/sched/rte_pie.h:125:21: error: comparison between pointer and integer [-Werror] RTE_ASSERT(pkt_len != NULL); Bugzilla ID: 878 Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Cc: wojciechx.liguzinski@intel.com Signed-off-by: Ali Alnubani --- lib/sched/rte_pie.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sched/rte_pie.h b/lib/sched/rte_pie.h index a3441ffe51..dfdf572311 100644 --- a/lib/sched/rte_pie.h +++ b/lib/sched/rte_pie.h @@ -122,7 +122,7 @@ rte_pie_enqueue_empty(const struct rte_pie_config *pie_cfg, struct rte_pie *pie, uint32_t pkt_len) { - RTE_ASSERT(pkt_len != NULL); + RTE_ASSERT(pkt_len != 0); /* Update the PIE qlen parameter */ pie->qlen++; -- 2.25.1