From: Stephen Hemminger <stephen@networkplumber.org>
To: Elena Agostini <eagostini@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] gpu/cuda: introduce CUDA driver
Date: Mon, 8 Nov 2021 10:59:27 -0800 [thread overview]
Message-ID: <20211108105927.4a19d086@hermes.local> (raw)
In-Reply-To: <DM6PR12MB4107026864BA3D4AFCFCA548CD919@DM6PR12MB4107.namprd12.prod.outlook.com>
On Mon, 8 Nov 2021 18:39:36 +0000
Elena Agostini <eagostini@nvidia.com> wrote:
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Date: Monday, 8 November 2021 at 19:35
> > To: Elena Agostini <eagostini@nvidia.com>
> > Cc: dev@dpdk.org <dev@dpdk.org>
> > Subject: Re: [dpdk-dev] [PATCH v2 1/1] gpu/cuda: introduce CUDA driver
> > External email: Use caution opening links or attachments>
> >
> > On Thu, 4 Nov 2021 02:01:28 +0000
> > <eagostini@nvidia.com> wrote:>
> > > +/* Single entry of the memory list */
> > > +struct mem_entry {
> > > + CUdeviceptr ptr_d;
> > > + void *ptr_h;
> > > + size_t size;
> > > + struct rte_gpu *dev;
> > > + CUcontext ctx;>
> > Not sure where these types CUdeviceptr and CUcontext are coming
> > from, but the code looks like Windows style not DPDK or Linux.>
> > Please don't introduce CamelCase typedef's and never typedefs
> > for pointers.
>
> These are CUDA Driver API specific types, I can’t change them.
Could you at least avoid using the pointer typedefs.
When a pointer is typedef'd it leads to confusion to readers and
some dumb static analyzers.
next prev parent reply other threads:[~2021-11-08 18:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 22:49 [dpdk-dev] [RFC PATCH] " eagostini
2021-11-04 2:01 ` [dpdk-dev] [PATCH v2 0/1] " eagostini
2021-11-04 2:01 ` [dpdk-dev] [PATCH v2 1/1] " eagostini
2021-11-03 18:15 ` Stephen Hemminger
2021-11-08 18:35 ` Stephen Hemminger
2021-11-08 18:39 ` Elena Agostini
2021-11-08 18:59 ` Stephen Hemminger [this message]
2021-11-08 19:07 ` Elena Agostini
2021-11-08 19:02 ` [dpdk-dev] [RFC PATCH] " Stephen Hemminger
2021-11-08 21:20 ` Elena Agostini
2021-11-08 22:07 ` Stephen Hemminger
2021-11-08 23:15 ` Stephen Hemminger
2021-11-09 2:28 ` [dpdk-dev] [PATCH v3 0/1] " eagostini
2021-11-09 2:28 ` [dpdk-dev] [PATCH v3 1/1] " eagostini
2021-11-08 19:52 ` David Marchand
2021-11-09 5:50 ` [dpdk-dev] [PATCH v4 0/1] " eagostini
2021-11-09 5:50 ` [dpdk-dev] [PATCH v4 1/1] " eagostini
2021-11-15 22:36 ` [PATCH v5 0/1] " eagostini
2021-11-15 22:36 ` [PATCH v5 1/1] " eagostini
2021-11-16 20:47 ` [PATCH v6 0/1] " eagostini
2021-11-16 20:47 ` [PATCH v6 1/1] " eagostini
2021-11-16 22:50 ` [PATCH v7 0/1] " eagostini
2021-11-16 22:50 ` [PATCH v7 1/1] " eagostini
2021-11-16 15:58 ` Stephen Hemminger
2021-11-16 16:35 ` Thomas Monjalon
2021-11-16 16:40 ` Thomas Monjalon
2021-11-16 16:30 ` Thomas Monjalon
2021-11-16 16:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211108105927.4a19d086@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).