From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D284A0C4E; Mon, 8 Nov 2021 19:59:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 993B1410E8; Mon, 8 Nov 2021 19:59:31 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id E060440E5A for ; Mon, 8 Nov 2021 19:59:30 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id np3so8790769pjb.4 for ; Mon, 08 Nov 2021 10:59:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mRDC4mUNfOrQhVg+LgebQsHiSD5DXD9pYzMCGM7awkY=; b=2seyOavRfH0GJGwfxh7xhdVvQ0ISW6LL2UAsGXjbEwheFMsWd2j3Y/4G+HCSLcxQi2 UZKaM5OUDpwwdOzRG3eRlKbZdoMFEyQu3s+MH9vdTm3gQ3vT167TvLTtXl/LetsVfK8R 1ARtp+WWLcdqK6fMCmXmCrhCHNTbqU0ZbMjLK+m4viReDIUcJ6ARYZBwLR8IZDpDh2ia i99OhHyxsSwEszyCGn4oJ2zuIzvkXg4XLkuxMvZGBIUe00dJC4efYqkaivXltMDbfJSq /yi89ndTtFC9VHamjIpHGWJGttKBPP/YAV3VmGgkELm/RsHADmGizRSsIRtd37GRg5P3 +ylg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mRDC4mUNfOrQhVg+LgebQsHiSD5DXD9pYzMCGM7awkY=; b=7Np2vTWf2Q/J5ZcvwdgkqwjhRI6GeqVqtWdPwvHG6R9Awx/eQOwgdrYTbgRNP3a6rq 4vF1l/yVpxM3Bsah1X6sYomrNFi3oVNHI+xNXHHSrzZy+6xL4DALUH0HxSYgWBRF4zT3 0VmlD7R7663C8AvsgeUexMfiuLNrXwWZek1fz1M0w8xnaTBHxX2aFDo6mi9nvzlCKYH0 7I//tOs4XsFeRlcI9GZlV5gjgEcEnIETVlmDVqF/HmzBVBMVPqtpsIfkaMfQ9Z3n6h+f b9m7Momfz+F3OlewTOkxVcfbpdts+m1GcBShMkEoPEdaAl+GfSpiLVDYedMQVJ1xhBRM 7PzQ== X-Gm-Message-State: AOAM531pLamPa43LzSZgI0cz2zIj3XJFVkyKkiO2Merfqu4oni96WF1O 5ml3QpY8lw9bPHzFa5K6/Md56g== X-Google-Smtp-Source: ABdhPJz23jlAcYK8ySRUDB6wgkSMAW6WnrvmytUgZccppu3kB3W12k6zRsJ9uTCuiYoI+m9Z3AtAjg== X-Received: by 2002:a17:902:ea10:b0:142:112d:c0b9 with SMTP id s16-20020a170902ea1000b00142112dc0b9mr1020203plg.35.1636397970096; Mon, 08 Nov 2021 10:59:30 -0800 (PST) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id v10sm4487333pfg.162.2021.11.08.10.59.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 10:59:29 -0800 (PST) Date: Mon, 8 Nov 2021 10:59:27 -0800 From: Stephen Hemminger To: Elena Agostini Cc: "dev@dpdk.org" Message-ID: <20211108105927.4a19d086@hermes.local> In-Reply-To: References: <20211005224905.13505-1-eagostini@nvidia.com> <20211104020128.13165-1-eagostini@nvidia.com> <20211104020128.13165-2-eagostini@nvidia.com> <20211108103529.41007024@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 1/1] gpu/cuda: introduce CUDA driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 8 Nov 2021 18:39:36 +0000 Elena Agostini wrote: > > From: Stephen Hemminger > > Date: Monday, 8 November 2021 at 19:35 > > To: Elena Agostini > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 1/1] gpu/cuda: introduce CUDA driver > > External email: Use caution opening links or attachments> > > > > On Thu, 4 Nov 2021 02:01:28 +0000 > > wrote:> =20 > > > +/* Single entry of the memory list */ > > > +struct mem_entry { > > > + CUdeviceptr ptr_d; > > > + void *ptr_h; > > > + size_t size; > > > + struct rte_gpu *dev; > > > + CUcontext ctx;> =20 > > Not sure where these types CUdeviceptr and CUcontext are coming > > from, but the code looks like Windows style not DPDK or Linux.> > > Please don't introduce CamelCase typedef's and never typedefs > > for pointers. =20 >=20 > These are CUDA Driver API specific types, I can=E2=80=99t change them. Could you at least avoid using the pointer typedefs. When a pointer is typedef'd it leads to confusion to readers and some dumb static analyzers.