From: Volodymyr Fialko <vfialko@marvell.com>
To: <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
"Anatoly Burakov" <anatoly.burakov@intel.com>
Cc: <jerinj@marvell.com>, Volodymyr Fialko <vfialko@marvell.com>,
"David Marchand" <david.marchand@redhat.com>
Subject: [dpdk-dev] [PATCH v2] eal/arm64: support ASan
Date: Mon, 8 Nov 2021 23:45:48 +0100 [thread overview]
Message-ID: <20211108224548.3388687-1-vfialko@marvell.com> (raw)
In-Reply-To: <20211108134547.3286191-1-vfialko@marvell.com>
This patch defines ASAN_SHADOW_OFFSET for arm64 according to the ASan
documentation. This offset should cover all arm64 VMAs supported by
ASan.
Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
Changes since v1:
- changed the subject
- rewrite checks in "elif" manner
---
config/meson.build | 2 +-
doc/guides/prog_guide/asan.rst | 2 +-
lib/eal/common/malloc_elem.h | 2 ++
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/config/meson.build b/config/meson.build
index 17b5bec406..7eb710c08d 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -428,7 +428,7 @@ if get_option('b_sanitize') == 'address' or get_option('b_sanitize') == 'address
dpdk_extra_ldflags += '-lasan'
endif
- if is_linux and arch_subdir == 'x86' and dpdk_conf.get('RTE_ARCH_64')
+ if is_linux and arch_subdir in ['x86', 'arm'] and dpdk_conf.get('RTE_ARCH_64')
dpdk_conf.set10('RTE_MALLOC_ASAN', true)
endif
endif
diff --git a/doc/guides/prog_guide/asan.rst b/doc/guides/prog_guide/asan.rst
index 6d1b871c93..28b2382fc7 100644
--- a/doc/guides/prog_guide/asan.rst
+++ b/doc/guides/prog_guide/asan.rst
@@ -33,7 +33,7 @@ Example::
"stty echo" command when an error occurs.
ASan is aware of DPDK memory allocations, thanks to added instrumentation.
-This is only enabled on x86_64 at the moment.
+This is enabled on x86_64 and arm64 at the moment.
Other architectures may have to define ASAN_SHADOW_OFFSET.
Example heap-buffer-overflow error
diff --git a/lib/eal/common/malloc_elem.h b/lib/eal/common/malloc_elem.h
index 262d69bb3e..26e937cea0 100644
--- a/lib/eal/common/malloc_elem.h
+++ b/lib/eal/common/malloc_elem.h
@@ -106,6 +106,8 @@ malloc_elem_cookies_ok(const struct malloc_elem *elem)
#ifdef RTE_ARCH_X86_64
#define ASAN_SHADOW_OFFSET 0x00007fff8000
+#elif defined(RTE_ARCH_ARM64)
+#define ASAN_SHADOW_OFFSET 0x001000000000
#endif
#define ASAN_SHADOW_GRAIN_SIZE 8
--
2.25.1
next prev parent reply other threads:[~2021-11-08 22:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 13:45 [dpdk-dev] [PATCH] build: enable ASan for arm64 Volodymyr Fialko
2021-11-08 15:01 ` David Marchand
2021-11-08 16:37 ` Jerin Jacob
2021-11-08 22:45 ` Volodymyr Fialko [this message]
2021-11-09 5:39 ` [dpdk-dev] [PATCH v2] eal/arm64: support ASan Ruifeng Wang
2021-11-09 9:59 ` [dpdk-dev] [PATCH v3] " Volodymyr Fialko
2021-11-12 13:34 ` David Marchand
2021-11-08 22:34 [dpdk-dev] [PATCH v2] " Volodymyr Fialko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211108224548.3388687-1-vfialko@marvell.com \
--to=vfialko@marvell.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).