From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E24B6A034F; Wed, 10 Nov 2021 04:07:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78F294014D; Wed, 10 Nov 2021 04:07:17 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id D038940142 for ; Wed, 10 Nov 2021 04:07:16 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1059) id ED3B120C352A; Tue, 9 Nov 2021 19:07:15 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ED3B120C352A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1636513635; bh=BoYL+KWxbkl5GKqbNKUbnFkLmb3l4A0gTG8mEBsvt2A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sG1jsp5oiMeKaVDa67qjyX6YFq36AWe/YtLQ8Z+/g4kLKk+fmuO2vss0Lur7sxaQI b56K3W1kbuuY/fFjRR3vc/Gc6qukRiO3anWFnajpt5Q71nI0JiweSe2eQYkBKi1E7/ uazBUqCxrxdt+drz8G267F4k9M+cy3+HhGn37LnA= Date: Tue, 9 Nov 2021 19:07:15 -0800 From: Narcisa Ana Maria Vasile To: Thomas Monjalon Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, khot@microsoft.com, dmitrym@microsoft.com, roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com, bruce.richardson@intel.com, david.marchand@redhat.com, pallavi.kadam@intel.com Message-ID: <20211110030715.GB7558@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1633732841-17873-1-git-send-email-navasile@linux.microsoft.com> <4938958.YfKOMBFpFK@thomas> <20211109021048.GF12569@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <2349846.SAT7s3pbht@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2349846.SAT7s3pbht@thomas> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v16 9/9] Add unit tests for thread API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 09, 2021 at 09:32:08AM +0100, Thomas Monjalon wrote: > 09/11/2021 03:10, Narcisa Ana Maria Vasile: > > On Tue, Oct 12, 2021 at 06:33:16PM +0200, Thomas Monjalon wrote: > > > 09/10/2021 09:41, Narcisa Ana Maria Vasile: > > > > From: Narcisa Vasile > > > > > > > > As a new API for threading is introduced, > > > > a set of unit tests have been added to test the new interface. > > > > The tests verify that: > > > > * mutexes and barriers behave as expected > > > > * thread properties are applied correctly > > > > * the thread id is retrieved correctly > > > > * thread creation/destruction works properly > > > > > > Please make each test part of the patch implementing the feature. > > > Thanks > > > > > Makes sense, but most of these unit tests use rte_thread_create and > > rte_thread_join to handle the creation and cleanup of the threads > > that are being tested, so I'm forced to have this test patch at the end. > > You mean you cannot start the series with implementing these 2 functions? Yes, rte_thread_create() depends on thread attributes. However, some of the other components can still be tested separately. I've broken it down in v17 to allow for better progressive testing, but the first 3 tests follow after the first 3 features. > > > I could still break it up into smaller patches, one for each test category > > (mutex, attributes, etc) if you want. > > I would like to see features built & tested atomically and progressively. >