DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Xu, Wei1" <wei1.xu@intel.com>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"bernard.iremonger@inel.com" <bernard.iremonger@inel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fix parameters order when calling rte_ether_addr_copy()
Date: Wed, 10 Nov 2021 08:03:18 -0800	[thread overview]
Message-ID: <20211110080318.61df8450@hermes.local> (raw)
In-Reply-To: <PH0PR11MB5159C100715402B318E8B086A6939@PH0PR11MB5159.namprd11.prod.outlook.com>

On Wed, 10 Nov 2021 08:17:59 +0000
"Xu, Wei1" <wei1.xu@intel.com> wrote:

>                               eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);
> -                             rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr],
> -                                                           &eth_hdr->dst_addr);
> -                             rte_ether_addr_copy(&ports[fs->tx_port].eth_addr,
> -                                                           &eth_hdr->src_addr);
> +                            rte_ether_addr_copy(&eth_hdr->dst_addr,
> +                                                          &peer_eth_addrs[fs->peer_addr]);
> +                            rte_ether_addr_copy(&eth_hdr->src_addr,
> +                                                          &ports[fs->tx_port].eth_addr);

Your patch indents with spaces not tabs

      reply	other threads:[~2021-11-10 16:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10  8:17 Xu, Wei1
2021-11-10 16:03 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211110080318.61df8450@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=bernard.iremonger@inel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=wei1.xu@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).