DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: fix DCB configuration
@ 2021-11-09  8:02 Jie Wang
  2021-11-10  9:08 ` [dpdk-dev] [PATCH v2] " Jie Wang
  0 siblings, 1 reply; 6+ messages in thread
From: Jie Wang @ 2021-11-09  8:02 UTC (permalink / raw)
  To: dev; +Cc: yuying.zhang, xiaoyun.li, stevex.yang, Jie Wang

When set port DCB mode enabled, it should remove RSS HASH offload
before reconfiguring the device.

Because port multi-queue mode is changed from RSS to DCB.

Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")

Signed-off-by: Jie Wang <jie1x.wang@intel.com>
---
 app/test-pmd/testpmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index a66dfb297c..9e8cf45dea 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3948,6 +3948,7 @@ init_port_dcb_config(portid_t pid,
 	if (retval < 0)
 		return retval;
 	port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER;
+	port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
 
 	/* re-configure the device . */
 	retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH v2] app/testpmd: fix DCB configuration
  2021-11-09  8:02 [dpdk-dev] [PATCH] app/testpmd: fix DCB configuration Jie Wang
@ 2021-11-10  9:08 ` Jie Wang
  2021-11-12  9:08   ` Singh, Aman Deep
  2021-11-15  3:29   ` [PATCH v3] app/testpmd: fix DCB in VT configuration Jie Wang
  0 siblings, 2 replies; 6+ messages in thread
From: Jie Wang @ 2021-11-10  9:08 UTC (permalink / raw)
  To: dev; +Cc: yuying.zhang, xiaoyun.li, stevex.yang, Jie Wang

When set port DCB mode enabled, it should remove RSS HASH offload
before reconfiguring the device and queues.

Because port multi-queue mode is changed from RSS to DCB.

Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")

Signed-off-by: Jie Wang <jie1x.wang@intel.com>
---
v2:
 * update commit log.
 * remove RSS HASH offload from port->rx_conf[i].offloads.
---
 app/test-pmd/testpmd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index a66dfb297c..661be341a0 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3948,6 +3948,9 @@ init_port_dcb_config(portid_t pid,
 	if (retval < 0)
 		return retval;
 	port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER;
+	port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
+	for (i = 0; i < nb_rxq; i++)
+		rte_port->rx_conf[i].offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
 
 	/* re-configure the device . */
 	retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix DCB configuration
  2021-11-10  9:08 ` [dpdk-dev] [PATCH v2] " Jie Wang
@ 2021-11-12  9:08   ` Singh, Aman Deep
  2021-11-15  3:29   ` [PATCH v3] app/testpmd: fix DCB in VT configuration Jie Wang
  1 sibling, 0 replies; 6+ messages in thread
From: Singh, Aman Deep @ 2021-11-12  9:08 UTC (permalink / raw)
  To: Jie Wang, dev; +Cc: yuying.zhang, xiaoyun.li, stevex.yang


On 11/10/2021 2:38 PM, Jie Wang wrote:
> When set port DCB mode enabled, it should remove RSS HASH offload
> before reconfiguring the device and queues.
>
> Because port multi-queue mode is changed from RSS to DCB.
>
> Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")
>
> Signed-off-by: Jie Wang <jie1x.wang@intel.com>
> ---
> v2:
>   * update commit log.
>   * remove RSS HASH offload from port->rx_conf[i].offloads.
> ---
>   app/test-pmd/testpmd.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index a66dfb297c..661be341a0 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3948,6 +3948,9 @@ init_port_dcb_config(portid_t pid,
>   	if (retval < 0)
>   		return retval;
>   	port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER;
> +	port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
> +	for (i = 0; i < nb_rxq; i++)
> +		rte_port->rx_conf[i].offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;

I think this change will effect DCB_ENABLED case also ( without VT). In 
that case RSS offload is allowed.

Please check with configuration "port config 0 dcb vt off 4 pfc off".

>   
>   	/* re-configure the device . */
>   	retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3] app/testpmd: fix DCB in VT configuration
  2021-11-10  9:08 ` [dpdk-dev] [PATCH v2] " Jie Wang
  2021-11-12  9:08   ` Singh, Aman Deep
@ 2021-11-15  3:29   ` Jie Wang
  2021-11-15 12:46     ` Singh, Aman Deep
  1 sibling, 1 reply; 6+ messages in thread
From: Jie Wang @ 2021-11-15  3:29 UTC (permalink / raw)
  To: dev; +Cc: yuying.zhang, xiaoyun.li, stevex.yang, Jie Wang

When set port DCB in VT mode enabled, it should remove RSS HASH
offload before reconfiguring the device and queues.

Because port multi-queue mode is changed from RSS to DCB in VT.

Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")

Signed-off-by: Jie Wang <jie1x.wang@intel.com>
---
v3:
 * update commit log.
 * remove RSS HASh offload from DCB in VT.
v2:
 * update commit log.
 * remove RSS HASH offload from port->rx_conf[i].offloads.
---
 app/test-pmd/testpmd.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index a66dfb297c..c18942279a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3948,6 +3948,13 @@ init_port_dcb_config(portid_t pid,
 	if (retval < 0)
 		return retval;
 	port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER;
+	/* remove RSS HASH offload for DCB in vt mode */
+	if (port_conf.rxmode.mq_mode == RTE_ETH_MQ_RX_VMDQ_DCB) {
+		port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
+		for (i = 0; i < nb_rxq; i++)
+			rte_port->rx_conf[i].offloads &=
+				~RTE_ETH_RX_OFFLOAD_RSS_HASH;
+	}
 
 	/* re-configure the device . */
 	retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] app/testpmd: fix DCB in VT configuration
  2021-11-15  3:29   ` [PATCH v3] app/testpmd: fix DCB in VT configuration Jie Wang
@ 2021-11-15 12:46     ` Singh, Aman Deep
  2021-11-15 16:23       ` Ferruh Yigit
  0 siblings, 1 reply; 6+ messages in thread
From: Singh, Aman Deep @ 2021-11-15 12:46 UTC (permalink / raw)
  To: Jie Wang, dev; +Cc: yuying.zhang, xiaoyun.li, stevex.yang, Ferruh Yigit

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]


On 11/15/2021 8:59 AM, Jie Wang wrote:
> When set port DCB in VT mode enabled, it should remove RSS HASH
> offload before reconfiguring the device and queues.
>
> Because port multi-queue mode is changed from RSS to DCB in VT.
>
> Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")
>
> Signed-off-by: Jie Wang<jie1x.wang@intel.com>

Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>

> ---
> v3:
>   * update commit log.
>   * remove RSS HASh offload from DCB in VT.
> v2:
>   * update commit log.
>   * remove RSS HASH offload from port->rx_conf[i].offloads.
> ---
>   app/test-pmd/testpmd.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index a66dfb297c..c18942279a 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3948,6 +3948,13 @@ init_port_dcb_config(portid_t pid,
>   	if (retval < 0)
>   		return retval;
>   	port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER;
> +	/* remove RSS HASH offload for DCB in vt mode */
> +	if (port_conf.rxmode.mq_mode == RTE_ETH_MQ_RX_VMDQ_DCB) {
> +		port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
> +		for (i = 0; i < nb_rxq; i++)
> +			rte_port->rx_conf[i].offloads &=
> +				~RTE_ETH_RX_OFFLOAD_RSS_HASH;
> +	}
>   
>   	/* re-configure the device . */
>   	retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);

[-- Attachment #2: Type: text/html, Size: 2822 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] app/testpmd: fix DCB in VT configuration
  2021-11-15 12:46     ` Singh, Aman Deep
@ 2021-11-15 16:23       ` Ferruh Yigit
  0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2021-11-15 16:23 UTC (permalink / raw)
  To: Singh, Aman Deep, Jie Wang, dev; +Cc: yuying.zhang, xiaoyun.li, stevex.yang

On 11/15/2021 12:46 PM, Singh, Aman Deep wrote:
> 
> On 11/15/2021 8:59 AM, Jie Wang wrote:
>> When set port DCB in VT mode enabled, it should remove RSS HASH
>> offload before reconfiguring the device and queues.
>>
>> Because port multi-queue mode is changed from RSS to DCB in VT.
>>
>> Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")
>>
>> Signed-off-by: Jie Wang<jie1x.wang@intel.com>
> 
> Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>
> 

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-11-15 16:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-09  8:02 [dpdk-dev] [PATCH] app/testpmd: fix DCB configuration Jie Wang
2021-11-10  9:08 ` [dpdk-dev] [PATCH v2] " Jie Wang
2021-11-12  9:08   ` Singh, Aman Deep
2021-11-15  3:29   ` [PATCH v3] app/testpmd: fix DCB in VT configuration Jie Wang
2021-11-15 12:46     ` Singh, Aman Deep
2021-11-15 16:23       ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).