From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 52D6CA034F;
	Thu, 11 Nov 2021 06:45:20 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DAD4640E28;
	Thu, 11 Nov 2021 06:45:19 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id CC96E40E03
 for <dev@dpdk.org>; Thu, 11 Nov 2021 06:45:17 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id D292C20C3571; Wed, 10 Nov 2021 21:45:16 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D292C20C3571
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1636609516;
 bh=fWiozBZELqfoEypdhon7RaujkoaQ/D6qXt1coLbKOws=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=O0KA/+FJlEZgf0L9bxvldiUntLtFkgogPw4vJh7ekW/Qlm6yGQX/HgpoefQtwBdz0
 EXCpXWXc+PXywgolOvxTYrJsYSrrroIb6l6pcGEW4EYYOlNEI4c9p+KEgA66z45AOg
 ACNb8kEjmta+K/o0Pe7TS7phlzCSp/nW50FqXlm0=
Date: Wed, 10 Nov 2021 21:45:16 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com,
 Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] devtools: forbid additions of __reserved
Message-ID: <20211111054516.GB31795@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20211023102900.22317-1-david.marchand@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211023102900.22317-1-david.marchand@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Sat, Oct 23, 2021 at 12:29:00PM +0200, David Marchand wrote:
> __reserved is a reserved keyword in Windows system headers.
> 

fwiw it's the c standard that stipulates identifiers starting with __
are reserved for any use.

C11/C99 "ANSI-C"
7.1.3 Reserved Identifiers
    `All identifiers that begin with an underscore and either an
    uppercase letter or another underscore are always reserved for
    any use.'

Public DPDK headers are also subject to the C++ standard.
C++ (n3690)
5.10 Identifiers

    `(3.1) -- Each identifier that contains a double underscore __ or
    begins with an underscore followed by an uppercase letter is reserved
    to the implementation for any use.'

    `(3.2) -- Each identifier that begins with an underscore is reserved
    to the implementation for use as a name in the global namespace.'

dpdk is pretty comprehensive in violating these clauses with
identifiers of the form `__rte_’ fortunately since preprocessors,
compilers, standard library headers are unlikely to use `rte’ it’s
fairly safe in spite of being non-compliant.