From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 96581A034F;
	Fri, 12 Nov 2021 17:41:59 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1A04841147;
	Fri, 12 Nov 2021 17:41:59 +0100 (CET)
Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com
 [209.85.210.176])
 by mails.dpdk.org (Postfix) with ESMTP id 73B35410EA
 for <dev@dpdk.org>; Fri, 12 Nov 2021 17:41:58 +0100 (CET)
Received: by mail-pf1-f176.google.com with SMTP id c4so8999727pfj.2
 for <dev@dpdk.org>; Fri, 12 Nov 2021 08:41:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=FADtKZjnM4o7YmsaeJ5tEK9zAHDycsUkxUr9RcBTpjY=;
 b=dAobUaZTifn7LyZMbFlYdwKIyh9TW7zdiegdkAbvkfkeiYDW3iOjfURmSTmb3+7pkD
 kdJlFhPAEC25ThzK82grkdIfMNctAvms0PyOUBvkpKCwt2IVyRQ/y+uZvU0FofhFXoWN
 M/aARNigZc33sCjWyKcSlNa/MKsK1i5wsGEi9S/Px+wCyNuJqJ2k8elwTbl8bISUw426
 XaZKyojeZDhTjAMHNDqR8kHT2JkUMTpQP6ASVrHPtD7vqOuVOHCebyWPPQTTpHmRIa95
 9ts2lO41YrXl48eBjWCXQM6pSxKKkKB3MdVh/sw3iGHz54VQILGkn+SnJizWb6gklcoL
 NGTA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=FADtKZjnM4o7YmsaeJ5tEK9zAHDycsUkxUr9RcBTpjY=;
 b=GESbIHQ3oMcdKsJE9gYyYlHKwDzMwQQcsWjFcQcxhmdRruEhISRy5Ie6UHIk01HmbC
 tDkSEEkRtnLrJg9TiP+8V+pXwKyRdShXlax/fU3M0NJVZFC9uIwDYl87Bxnqn2y5eZzB
 WiieBWMrFam4wSvtEKkyXiHxaSexw8lc626D1xC8BYeCoY5O26q0Uoi1hC34vN5rYBma
 4JuhU7PicLcta+koKDelGPHrsPYz/lZe0IJ1JLGZoLXeXYHP2O2vlcW9KMYlsF4YmNBv
 DemnfnzmZkcx2nQAm0WydUJTqYaaBRzfmvuJsytzav8aYGuppNaJf8VX+JDmKdMZtFKL
 l+tg==
X-Gm-Message-State: AOAM532il8rE+DiGSzIFkhFbmmrLRiWM4SH9mbLdituVRZ9IMt3UWiY8
 TcfCshRp7qQo8NZ6S6Szd+9eKg==
X-Google-Smtp-Source: ABdhPJwO8oevQQTv/8S2MZF3mKc15LSqQJ1abOr/dC+cY7mfu85CT5zb5pLxR0uRzmGED8E7vOw6PA==
X-Received: by 2002:a63:5c3:: with SMTP id 186mr10786870pgf.466.1636735317474; 
 Fri, 12 Nov 2021 08:41:57 -0800 (PST)
Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123])
 by smtp.gmail.com with ESMTPSA id e24sm6525801pfn.8.2021.11.12.08.41.55
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 12 Nov 2021 08:41:57 -0800 (PST)
Date: Fri, 12 Nov 2021 08:41:53 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Walsh, Conor" <conor.walsh@intel.com>
Cc: David Marchand <david.marchand@redhat.com>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, "Liang, LongfengX" <longfengx.liang@intel.com>,
 dev <dev@dpdk.org>, "Hunt, David" <david.hunt@intel.com>, "Wang, Yipeng1"
 <yipeng1.wang@intel.com>, "Gobriel, Sameh" <sameh.gobriel@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>, "Medvedkin, Vladimir"
 <vladimir.medvedkin@intel.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@oss.nxp.com>, "Trahe, Fiona"
 <fiona.trahe@intel.com>, "Griffin, John" <john.griffin@intel.com>, "Jain,
 Deepak K" <deepak.k.jain@intel.com>, "Van Haaren, Harry"
 <harry.van.haaren@intel.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>, Ziyang Xuan
 <xuanziyang2@huawei.com>, Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
 Guoyang Zhou <zhouguoyang@huawei.com>, Shijith Thotton
 <sthotton@marvell.com>, Srisivasubramanian Srinivasan
 <srinivasan@marvell.com>, "heinrich.kuhn@corigine.com"
 <heinrich.kuhn@corigine.com>, Harman Kalra <hkalra@marvell.com>, Rasesh
 Mody <rmody@marvell.com>, Devendra Singh Rawat <dsinghrawat@marvell.com>,
 "Jiawen Wu" <jiawenwu@trustnetic.com>, "Wang, Yong" <yongwang@vmware.com>,
 "Mcnamara, John" <john.mcnamara@intel.com>, Shreyansh Jain
 <shreyansh.jain@nxp.com>, "santosh.shukla@caviumnetworks.com"
 <santosh.shukla@caviumnetworks.com>, Akhil Goyal <gakhil@marvell.com>,
 "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, "Kusztal, ArkadiuszX"
 <arkadiuszx.kusztal@intel.com>, "michael.baucom@broadcom.com"
 <michael.baucom@broadcom.com>, Venkat Duvvuru
 <venkatkumar.duvvuru@broadcom.com>, Lance Richardson
 <lance.richardson@broadcom.com>, "kishore.padmanabha@broadcom.com"
 <kishore.padmanabha@broadcom.com>, Jerin Jacob
 <jerin.jacob@caviumnetworks.com>, "derek.chickles@caviumnetworks.com"
 <derek.chickles@caviumnetworks.com>, "ssrinivasan@caviumnetworks.com"
 <ssrinivasan@caviumnetworks.com>, "mjatharakonda@oneconvergence.com"
 <mjatharakonda@oneconvergence.com>, "simon.horman@corigine.com"
 <simon.horman@corigine.com>, "david.george@sophos.com"
 <david.george@sophos.com>, "sony.chacko@qlogic.com"
 <sony.chacko@qlogic.com>, "harish.patil@qlogic.com"
 <harish.patil@qlogic.com>, Tomasz Kulasek <tomaszx.kulasek@intel.com>,
 "ian.betts@intel.com" <ian.betts@intel.com>, Liang Ma
 <liang.j.ma@intel.com>, "lei.a.yao@intel.com" <lei.a.yao@intel.com>
Subject: Re: [PATCH 5/7] drivers/net: fix unused but set variables
Message-ID: <20211112084153.1931b484@hermes.local>
In-Reply-To: <PH0PR11MB52079CFAEFF6673C25113D5BFF959@PH0PR11MB5207.namprd11.prod.outlook.com>
References: <20211112140111.922171-1-conor.walsh@intel.com>
 <20211112140111.922171-6-conor.walsh@intel.com>
 <ef0163fd-0dd5-956d-ab2a-933868994114@intel.com>
 <CAJFAV8wOhpdiPcVTRd0pU7AFhxJq-ikE-iCV=Gfzj0_cXcn3OA@mail.gmail.com>
 <PH0PR11MB52079CFAEFF6673C25113D5BFF959@PH0PR11MB5207.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, 12 Nov 2021 16:38:37 +0000
"Walsh, Conor" <conor.walsh@intel.com> wrote:

> Would something along the lines of this make more sense?
> 
> #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX
> completed += vmxnet3_unmap_pkt(tcd->txdIdx, txq);
> #else
> vmxnet3_unmap_pkt(tcd->txdIdx, txq);
> #endif
> 
> Thanks,
> Conor.

Why not just
	RTE_USED(completed);

#ifdef's introduce more testing issues.