* [PATCH] net/ice: fix secondary process Rx offload path
@ 2021-11-12 5:43 Alvin Zhang
2021-11-15 2:05 ` [PATCH v2] " Alvin Zhang
0 siblings, 1 reply; 7+ messages in thread
From: Alvin Zhang @ 2021-11-12 5:43 UTC (permalink / raw)
To: qi.z.zhang, leyi.rong; +Cc: dev, Alvin Zhang, stable
Secondary process depends on the vector offload flag to select right
Rx offload path. This patch adds a variable in share memory to store
the vector offload flag that can be directly read by secondary process.
Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
Cc: stable@dpdk.org
Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
drivers/net/ice/ice_ethdev.h | 1 +
drivers/net/ice/ice_rxtx.c | 19 +++++++++++--------
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h
index 3a5bb9b..52daae0 100644
--- a/drivers/net/ice/ice_ethdev.h
+++ b/drivers/net/ice/ice_ethdev.h
@@ -538,6 +538,7 @@ struct ice_adapter {
bool rx_use_avx512;
bool tx_use_avx2;
bool tx_use_avx512;
+ int rx_vec_path;
#endif
};
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 2d771ea..981493e 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -3172,15 +3172,14 @@
#ifdef RTE_ARCH_X86
struct ice_rx_queue *rxq;
int i;
- int rx_check_ret = -1;
if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
ad->rx_use_avx512 = false;
ad->rx_use_avx2 = false;
- rx_check_ret = ice_rx_vec_dev_check(dev);
+ ad->rx_vec_path = ice_rx_vec_dev_check(dev);
if (ad->ptp_ena)
- rx_check_ret = -1;
- if (rx_check_ret >= 0 && ad->rx_bulk_alloc_allowed &&
+ ad->rx_vec_path = -1;
+ if (ad->rx_vec_path >= 0 && ad->rx_bulk_alloc_allowed &&
rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) {
ad->rx_vec_allowed = true;
for (i = 0; i < dev->data->nb_rx_queues; i++) {
@@ -3215,7 +3214,8 @@
if (dev->data->scattered_rx) {
if (ad->rx_use_avx512) {
#ifdef CC_AVX512_SUPPORT
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_path ==
+ ICE_VECTOR_OFFLOAD_PATH) {
PMD_DRV_LOG(NOTICE,
"Using AVX512 OFFLOAD Vector Scattered Rx (port %d).",
dev->data->port_id);
@@ -3230,7 +3230,8 @@
}
#endif
} else if (ad->rx_use_avx2) {
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_path ==
+ ICE_VECTOR_OFFLOAD_PATH) {
PMD_DRV_LOG(NOTICE,
"Using AVX2 OFFLOAD Vector Scattered Rx (port %d).",
dev->data->port_id);
@@ -3252,7 +3253,8 @@
} else {
if (ad->rx_use_avx512) {
#ifdef CC_AVX512_SUPPORT
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_path ==
+ ICE_VECTOR_OFFLOAD_PATH) {
PMD_DRV_LOG(NOTICE,
"Using AVX512 OFFLOAD Vector Rx (port %d).",
dev->data->port_id);
@@ -3267,7 +3269,8 @@
}
#endif
} else if (ad->rx_use_avx2) {
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_path ==
+ ICE_VECTOR_OFFLOAD_PATH) {
PMD_DRV_LOG(NOTICE,
"Using AVX2 OFFLOAD Vector Rx (port %d).",
dev->data->port_id);
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] net/ice: fix secondary process Rx offload path
2021-11-12 5:43 [PATCH] net/ice: fix secondary process Rx offload path Alvin Zhang
@ 2021-11-15 2:05 ` Alvin Zhang
2021-11-16 1:21 ` Zhang, Qi Z
2021-11-16 2:32 ` [PATCH v3] " Alvin Zhang
0 siblings, 2 replies; 7+ messages in thread
From: Alvin Zhang @ 2021-11-15 2:05 UTC (permalink / raw)
To: qi.z.zhang, leyi.rong; +Cc: dev, Alvin Zhang, stable
Secondary process depends on the vector offload flag to select right
Rx offload path. This patch adds a variable in share memory to store
the vector offload flag that can be directly read by secondary process.
Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
Cc: stable@dpdk.org
Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
drivers/net/ice/ice_ethdev.h | 1 +
drivers/net/ice/ice_rxtx.c | 19 +++++++++++--------
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h
index 3a5bb9b..52daae0 100644
--- a/drivers/net/ice/ice_ethdev.h
+++ b/drivers/net/ice/ice_ethdev.h
@@ -538,6 +538,7 @@ struct ice_adapter {
bool rx_use_avx512;
bool tx_use_avx2;
bool tx_use_avx512;
+ int rx_vec_path;
#endif
};
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 2d771ea..981493e 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -3172,15 +3172,14 @@
#ifdef RTE_ARCH_X86
struct ice_rx_queue *rxq;
int i;
- int rx_check_ret = -1;
if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
ad->rx_use_avx512 = false;
ad->rx_use_avx2 = false;
- rx_check_ret = ice_rx_vec_dev_check(dev);
+ ad->rx_vec_path = ice_rx_vec_dev_check(dev);
if (ad->ptp_ena)
- rx_check_ret = -1;
- if (rx_check_ret >= 0 && ad->rx_bulk_alloc_allowed &&
+ ad->rx_vec_path = -1;
+ if (ad->rx_vec_path >= 0 && ad->rx_bulk_alloc_allowed &&
rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) {
ad->rx_vec_allowed = true;
for (i = 0; i < dev->data->nb_rx_queues; i++) {
@@ -3215,7 +3214,8 @@
if (dev->data->scattered_rx) {
if (ad->rx_use_avx512) {
#ifdef CC_AVX512_SUPPORT
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_path ==
+ ICE_VECTOR_OFFLOAD_PATH) {
PMD_DRV_LOG(NOTICE,
"Using AVX512 OFFLOAD Vector Scattered Rx (port %d).",
dev->data->port_id);
@@ -3230,7 +3230,8 @@
}
#endif
} else if (ad->rx_use_avx2) {
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_path ==
+ ICE_VECTOR_OFFLOAD_PATH) {
PMD_DRV_LOG(NOTICE,
"Using AVX2 OFFLOAD Vector Scattered Rx (port %d).",
dev->data->port_id);
@@ -3252,7 +3253,8 @@
} else {
if (ad->rx_use_avx512) {
#ifdef CC_AVX512_SUPPORT
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_path ==
+ ICE_VECTOR_OFFLOAD_PATH) {
PMD_DRV_LOG(NOTICE,
"Using AVX512 OFFLOAD Vector Rx (port %d).",
dev->data->port_id);
@@ -3267,7 +3269,8 @@
}
#endif
} else if (ad->rx_use_avx2) {
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_path ==
+ ICE_VECTOR_OFFLOAD_PATH) {
PMD_DRV_LOG(NOTICE,
"Using AVX2 OFFLOAD Vector Rx (port %d).",
dev->data->port_id);
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v2] net/ice: fix secondary process Rx offload path
2021-11-15 2:05 ` [PATCH v2] " Alvin Zhang
@ 2021-11-16 1:21 ` Zhang, Qi Z
2021-11-16 2:12 ` Zhang, AlvinX
2021-11-16 2:32 ` [PATCH v3] " Alvin Zhang
1 sibling, 1 reply; 7+ messages in thread
From: Zhang, Qi Z @ 2021-11-16 1:21 UTC (permalink / raw)
To: Zhang, AlvinX, Rong, Leyi; +Cc: dev, stable
> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Monday, November 15, 2021 10:06 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Rong, Leyi <leyi.rong@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/ice: fix secondary process Rx offload path
>
> Secondary process depends on the vector offload flag to select right Rx offload
> path. This patch adds a variable in share memory to store the vector offload
> flag that can be directly read by secondary process.
>
> Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
> drivers/net/ice/ice_ethdev.h | 1 +
> drivers/net/ice/ice_rxtx.c | 19 +++++++++++--------
> 2 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h index
> 3a5bb9b..52daae0 100644
> --- a/drivers/net/ice/ice_ethdev.h
> +++ b/drivers/net/ice/ice_ethdev.h
> @@ -538,6 +538,7 @@ struct ice_adapter {
> bool rx_use_avx512;
> bool tx_use_avx2;
> bool tx_use_avx512;
> + int rx_vec_path;
Can we make the type/ name more specific, how about defined as: "bool rx_vec_offload_support;" ?
Then we can keep most thing unchanged in primary process branch, but only add below ,
ad->rx_vec_offload_support = (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH);
in following branch
we can avoid duplicate if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH)..
> #endif
> };
>
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index
> 2d771ea..981493e 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -3172,15 +3172,14 @@
> #ifdef RTE_ARCH_X86
> struct ice_rx_queue *rxq;
> int i;
> - int rx_check_ret = -1;
>
> if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> ad->rx_use_avx512 = false;
> ad->rx_use_avx2 = false;
> - rx_check_ret = ice_rx_vec_dev_check(dev);
> + ad->rx_vec_path = ice_rx_vec_dev_check(dev);
> if (ad->ptp_ena)
> - rx_check_ret = -1;
> - if (rx_check_ret >= 0 && ad->rx_bulk_alloc_allowed &&
> + ad->rx_vec_path = -1;
> + if (ad->rx_vec_path >= 0 && ad->rx_bulk_alloc_allowed &&
> rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) {
> ad->rx_vec_allowed = true;
> for (i = 0; i < dev->data->nb_rx_queues; i++) { @@ -3215,7
> +3214,8 @@
> if (dev->data->scattered_rx) {
> if (ad->rx_use_avx512) {
> #ifdef CC_AVX512_SUPPORT
> - if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
> + if (ad->rx_vec_path ==
> + ICE_VECTOR_OFFLOAD_PATH) {
> PMD_DRV_LOG(NOTICE,
> "Using AVX512 OFFLOAD Vector Scattered Rx
> (port %d).",
> dev->data->port_id);
> @@ -3230,7 +3230,8 @@
> }
> #endif
> } else if (ad->rx_use_avx2) {
> - if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
> + if (ad->rx_vec_path ==
> + ICE_VECTOR_OFFLOAD_PATH) {
> PMD_DRV_LOG(NOTICE,
> "Using AVX2 OFFLOAD Vector Scattered Rx
> (port %d).",
> dev->data->port_id);
> @@ -3252,7 +3253,8 @@
> } else {
> if (ad->rx_use_avx512) {
> #ifdef CC_AVX512_SUPPORT
> - if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
> + if (ad->rx_vec_path ==
> + ICE_VECTOR_OFFLOAD_PATH) {
> PMD_DRV_LOG(NOTICE,
> "Using AVX512 OFFLOAD Vector Rx (port %d).",
> dev->data->port_id);
> @@ -3267,7 +3269,8 @@
> }
> #endif
> } else if (ad->rx_use_avx2) {
> - if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
> + if (ad->rx_vec_path ==
> + ICE_VECTOR_OFFLOAD_PATH) {
> PMD_DRV_LOG(NOTICE,
> "Using AVX2 OFFLOAD Vector Rx
> (port %d).",
> dev->data->port_id);
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v2] net/ice: fix secondary process Rx offload path
2021-11-16 1:21 ` Zhang, Qi Z
@ 2021-11-16 2:12 ` Zhang, AlvinX
0 siblings, 0 replies; 7+ messages in thread
From: Zhang, AlvinX @ 2021-11-16 2:12 UTC (permalink / raw)
To: Zhang, Qi Z, Rong, Leyi; +Cc: dev, stable
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Tuesday, November 16, 2021 9:22 AM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>; Rong, Leyi <leyi.rong@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH v2] net/ice: fix secondary process Rx offload path
>
>
>
> > -----Original Message-----
> > From: Zhang, AlvinX <alvinx.zhang@intel.com>
> > Sent: Monday, November 15, 2021 10:06 AM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Rong, Leyi
> > <leyi.rong@intel.com>
> > Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH v2] net/ice: fix secondary process Rx offload path
> >
> > Secondary process depends on the vector offload flag to select right
> > Rx offload path. This patch adds a variable in share memory to store
> > the vector offload flag that can be directly read by secondary process.
> >
> > Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> > ---
> > drivers/net/ice/ice_ethdev.h | 1 +
> > drivers/net/ice/ice_rxtx.c | 19 +++++++++++--------
> > 2 files changed, 12 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/ice/ice_ethdev.h
> > b/drivers/net/ice/ice_ethdev.h index
> > 3a5bb9b..52daae0 100644
> > --- a/drivers/net/ice/ice_ethdev.h
> > +++ b/drivers/net/ice/ice_ethdev.h
> > @@ -538,6 +538,7 @@ struct ice_adapter { bool rx_use_avx512; bool
> > tx_use_avx2; bool tx_use_avx512;
> > +int rx_vec_path;
>
> Can we make the type/ name more specific, how about defined as: "bool
> rx_vec_offload_support;" ?
>
> Then we can keep most thing unchanged in primary process branch, but only
> add below ,
>
> ad->rx_vec_offload_support = (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH);
>
>
> in following branch
>
> we can avoid duplicate if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH)..
>
Ok, I'll update it in V3.
>
>
>
> > #endif
> > };
> >
> > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
> > index 2d771ea..981493e 100644
> > --- a/drivers/net/ice/ice_rxtx.c
> > +++ b/drivers/net/ice/ice_rxtx.c
> > @@ -3172,15 +3172,14 @@
> > #ifdef RTE_ARCH_X86
> > struct ice_rx_queue *rxq;
> > int i;
> > -int rx_check_ret = -1;
> >
> > if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> > ad->rx_use_avx512 = false;
> > ad->rx_use_avx2 = false;
> > -rx_check_ret = ice_rx_vec_dev_check(dev);
> > +ad->rx_vec_path = ice_rx_vec_dev_check(dev);
> > if (ad->ptp_ena)
> > -rx_check_ret = -1;
> > -if (rx_check_ret >= 0 && ad->rx_bulk_alloc_allowed &&
> > +ad->rx_vec_path = -1;
> > +if (ad->rx_vec_path >= 0 && ad->rx_bulk_alloc_allowed &&
> > rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) {
> > ad->rx_vec_allowed = true; for (i = 0; i < dev->data->nb_rx_queues;
> > i++) { @@ -3215,7
> > +3214,8 @@
> > if (dev->data->scattered_rx) {
> > if (ad->rx_use_avx512) {
> > #ifdef CC_AVX512_SUPPORT
> > -if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
> > +if (ad->rx_vec_path ==
> > + ICE_VECTOR_OFFLOAD_PATH) {
> > PMD_DRV_LOG(NOTICE,
> > "Using AVX512 OFFLOAD Vector Scattered Rx (port %d).",
> > dev->data->port_id); @@ -3230,7 +3230,8 @@ } #endif } else if
> > (ad->rx_use_avx2) { -if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
> > +if (ad->rx_vec_path ==
> > + ICE_VECTOR_OFFLOAD_PATH) {
> > PMD_DRV_LOG(NOTICE,
> > "Using AVX2 OFFLOAD Vector Scattered Rx (port %d).",
> > dev->data->port_id);
> > @@ -3252,7 +3253,8 @@
> > } else {
> > if (ad->rx_use_avx512) {
> > #ifdef CC_AVX512_SUPPORT
> > -if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
> > +if (ad->rx_vec_path ==
> > + ICE_VECTOR_OFFLOAD_PATH) {
> > PMD_DRV_LOG(NOTICE,
> > "Using AVX512 OFFLOAD Vector Rx (port %d).", dev->data->port_id); @@
> > -3267,7 +3269,8 @@ } #endif } else if (ad->rx_use_avx2) { -if
> > (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
> > +if (ad->rx_vec_path ==
> > + ICE_VECTOR_OFFLOAD_PATH) {
> > PMD_DRV_LOG(NOTICE,
> > "Using AVX2 OFFLOAD Vector Rx
> > (port %d).",
> > dev->data->port_id);
> > --
> > 1.8.3.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] net/ice: fix secondary process Rx offload path
2021-11-15 2:05 ` [PATCH v2] " Alvin Zhang
2021-11-16 1:21 ` Zhang, Qi Z
@ 2021-11-16 2:32 ` Alvin Zhang
2021-11-16 3:09 ` Sun, QinX
1 sibling, 1 reply; 7+ messages in thread
From: Alvin Zhang @ 2021-11-16 2:32 UTC (permalink / raw)
To: qi.z.zhang, leyi.rong; +Cc: dev, Alvin Zhang, stable
Secondary process depends on the vector offload flag to select right
Rx offload path. This patch adds a variable in share memory to store
the vector offload flag that can be directly read by secondary process.
Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
Cc: stable@dpdk.org
Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
v3: Modify the patch according to comment.
---
drivers/net/ice/ice_ethdev.h | 1 +
drivers/net/ice/ice_rxtx.c | 10 ++++++----
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h
index 3a5bb9b..f8d0f0c 100644
--- a/drivers/net/ice/ice_ethdev.h
+++ b/drivers/net/ice/ice_ethdev.h
@@ -538,6 +538,7 @@ struct ice_adapter {
bool rx_use_avx512;
bool tx_use_avx2;
bool tx_use_avx512;
+ bool rx_vec_offload_support;
#endif
};
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 2d771ea..f6d8564 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -3180,6 +3180,8 @@
rx_check_ret = ice_rx_vec_dev_check(dev);
if (ad->ptp_ena)
rx_check_ret = -1;
+ ad->rx_vec_offload_support =
+ (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH);
if (rx_check_ret >= 0 && ad->rx_bulk_alloc_allowed &&
rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) {
ad->rx_vec_allowed = true;
@@ -3215,7 +3217,7 @@
if (dev->data->scattered_rx) {
if (ad->rx_use_avx512) {
#ifdef CC_AVX512_SUPPORT
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_offload_support) {
PMD_DRV_LOG(NOTICE,
"Using AVX512 OFFLOAD Vector Scattered Rx (port %d).",
dev->data->port_id);
@@ -3230,7 +3232,7 @@
}
#endif
} else if (ad->rx_use_avx2) {
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_offload_support) {
PMD_DRV_LOG(NOTICE,
"Using AVX2 OFFLOAD Vector Scattered Rx (port %d).",
dev->data->port_id);
@@ -3252,7 +3254,7 @@
} else {
if (ad->rx_use_avx512) {
#ifdef CC_AVX512_SUPPORT
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_offload_support) {
PMD_DRV_LOG(NOTICE,
"Using AVX512 OFFLOAD Vector Rx (port %d).",
dev->data->port_id);
@@ -3267,7 +3269,7 @@
}
#endif
} else if (ad->rx_use_avx2) {
- if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
+ if (ad->rx_vec_offload_support) {
PMD_DRV_LOG(NOTICE,
"Using AVX2 OFFLOAD Vector Rx (port %d).",
dev->data->port_id);
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v3] net/ice: fix secondary process Rx offload path
2021-11-16 2:32 ` [PATCH v3] " Alvin Zhang
@ 2021-11-16 3:09 ` Sun, QinX
2021-11-16 4:54 ` Zhang, Qi Z
0 siblings, 1 reply; 7+ messages in thread
From: Sun, QinX @ 2021-11-16 3:09 UTC (permalink / raw)
To: Zhang, AlvinX, Zhang, Qi Z, Rong, Leyi; +Cc: dev, Zhang, AlvinX, stable
> -----Original Message-----
> From: Alvin Zhang <alvinx.zhang@intel.com>
> Sent: Tuesday, November 16, 2021 10:32 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Rong, Leyi <leyi.rong@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v3] net/ice: fix secondary process Rx offload path
>
> Secondary process depends on the vector offload flag to select right Rx
> offload path. This patch adds a variable in share memory to store the vector
> offload flag that can be directly read by secondary process.
>
> Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
Tested-by: Qin Sun <qinx.sun@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v3] net/ice: fix secondary process Rx offload path
2021-11-16 3:09 ` Sun, QinX
@ 2021-11-16 4:54 ` Zhang, Qi Z
0 siblings, 0 replies; 7+ messages in thread
From: Zhang, Qi Z @ 2021-11-16 4:54 UTC (permalink / raw)
To: Sun, QinX, Zhang, AlvinX, Rong, Leyi; +Cc: dev, Zhang, AlvinX, stable
> -----Original Message-----
> From: Sun, QinX <qinx.sun@intel.com>
> Sent: Tuesday, November 16, 2021 11:09 AM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Rong, Leyi <leyi.rong@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH v3] net/ice: fix secondary process Rx offload path
>
> > -----Original Message-----
> > From: Alvin Zhang <alvinx.zhang@intel.com>
> > Sent: Tuesday, November 16, 2021 10:32 AM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Rong, Leyi
> > <leyi.rong@intel.com>
> > Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH v3] net/ice: fix secondary process Rx offload path
> >
> > Secondary process depends on the vector offload flag to select right
> > Rx offload path. This patch adds a variable in share memory to store
> > the vector offload flag that can be directly read by secondary process.
> >
> > Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
>
> Tested-by: Qin Sun <qinx.sun@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-11-16 4:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 5:43 [PATCH] net/ice: fix secondary process Rx offload path Alvin Zhang
2021-11-15 2:05 ` [PATCH v2] " Alvin Zhang
2021-11-16 1:21 ` Zhang, Qi Z
2021-11-16 2:12 ` Zhang, AlvinX
2021-11-16 2:32 ` [PATCH v3] " Alvin Zhang
2021-11-16 3:09 ` Sun, QinX
2021-11-16 4:54 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).