From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06848A0C43; Mon, 15 Nov 2021 03:05:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7441A40E01; Mon, 15 Nov 2021 03:05:52 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 1DD9540141; Mon, 15 Nov 2021 03:05:49 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="220253673" X-IronPort-AV: E=Sophos;i="5.87,235,1631602800"; d="scan'208";a="220253673" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2021 18:05:48 -0800 X-IronPort-AV: E=Sophos;i="5.87,235,1631602800"; d="scan'208";a="566274480" Received: from shwdenpg235.ccr.corp.intel.com ([10.253.106.22]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2021 18:05:45 -0800 From: Alvin Zhang To: qi.z.zhang@intel.com, leyi.rong@intel.com Cc: dev@dpdk.org, Alvin Zhang , stable@dpdk.org Subject: [PATCH v2] net/ice: fix secondary process Rx offload path Date: Mon, 15 Nov 2021 10:05:39 +0800 Message-Id: <20211115020539.20468-1-alvinx.zhang@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20211112054313.20132-1-alvinx.zhang@intel.com> References: <20211112054313.20132-1-alvinx.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Secondary process depends on the vector offload flag to select right Rx offload path. This patch adds a variable in share memory to store the vector offload flag that can be directly read by secondary process. Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path") Cc: stable@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/ice/ice_ethdev.h | 1 + drivers/net/ice/ice_rxtx.c | 19 +++++++++++-------- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h index 3a5bb9b..52daae0 100644 --- a/drivers/net/ice/ice_ethdev.h +++ b/drivers/net/ice/ice_ethdev.h @@ -538,6 +538,7 @@ struct ice_adapter { bool rx_use_avx512; bool tx_use_avx2; bool tx_use_avx512; + int rx_vec_path; #endif }; diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index 2d771ea..981493e 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -3172,15 +3172,14 @@ #ifdef RTE_ARCH_X86 struct ice_rx_queue *rxq; int i; - int rx_check_ret = -1; if (rte_eal_process_type() == RTE_PROC_PRIMARY) { ad->rx_use_avx512 = false; ad->rx_use_avx2 = false; - rx_check_ret = ice_rx_vec_dev_check(dev); + ad->rx_vec_path = ice_rx_vec_dev_check(dev); if (ad->ptp_ena) - rx_check_ret = -1; - if (rx_check_ret >= 0 && ad->rx_bulk_alloc_allowed && + ad->rx_vec_path = -1; + if (ad->rx_vec_path >= 0 && ad->rx_bulk_alloc_allowed && rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) { ad->rx_vec_allowed = true; for (i = 0; i < dev->data->nb_rx_queues; i++) { @@ -3215,7 +3214,8 @@ if (dev->data->scattered_rx) { if (ad->rx_use_avx512) { #ifdef CC_AVX512_SUPPORT - if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) { + if (ad->rx_vec_path == + ICE_VECTOR_OFFLOAD_PATH) { PMD_DRV_LOG(NOTICE, "Using AVX512 OFFLOAD Vector Scattered Rx (port %d).", dev->data->port_id); @@ -3230,7 +3230,8 @@ } #endif } else if (ad->rx_use_avx2) { - if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) { + if (ad->rx_vec_path == + ICE_VECTOR_OFFLOAD_PATH) { PMD_DRV_LOG(NOTICE, "Using AVX2 OFFLOAD Vector Scattered Rx (port %d).", dev->data->port_id); @@ -3252,7 +3253,8 @@ } else { if (ad->rx_use_avx512) { #ifdef CC_AVX512_SUPPORT - if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) { + if (ad->rx_vec_path == + ICE_VECTOR_OFFLOAD_PATH) { PMD_DRV_LOG(NOTICE, "Using AVX512 OFFLOAD Vector Rx (port %d).", dev->data->port_id); @@ -3267,7 +3269,8 @@ } #endif } else if (ad->rx_use_avx2) { - if (rx_check_ret == ICE_VECTOR_OFFLOAD_PATH) { + if (ad->rx_vec_path == + ICE_VECTOR_OFFLOAD_PATH) { PMD_DRV_LOG(NOTICE, "Using AVX2 OFFLOAD Vector Rx (port %d).", dev->data->port_id); -- 1.8.3.1