DPDK patches and discussions
 help / color / mirror / Atom feed
From: Conor Walsh <conor.walsh@intel.com>
To: ferruh.yigit@intel.com, david.marchand@redhat.com,
	longfengx.liang@intel.com, dev@dpdk.org
Cc: david.hunt@intel.com, yipeng1.wang@intel.com,
	sameh.gobriel@intel.com, bruce.richardson@intel.com,
	vladimir.medvedkin@intel.com, hemant.agrawal@nxp.com,
	sachin.saxena@oss.nxp.com, fiona.trahe@intel.com,
	john.griffin@intel.com, deepak.k.jain@intel.com,
	harry.van.haaren@intel.com, ajit.khaparde@broadcom.com,
	somnath.kotur@broadcom.com, xuanziyang2@huawei.com,
	cloud.wangxiaoyun@huawei.com, sthotton@marvell.com,
	srinivasan@marvell.com, heinrich.kuhn@corigine.com,
	hkalra@marvell.com, rmody@marvell.com, dsinghrawat@marvell.com,
	jiawenwu@trustnetic.com, yongwang@vmware.com,
	john.mcnamara@intel.com, gakhil@marvell.com,
	roy.fan.zhang@intel.com, arkadiuszx.kusztal@intel.com,
	michael.baucom@broadcom.com, venkatkumar.duvvuru@broadcom.com,
	lance.richardson@broadcom.com, kishore.padmanabha@broadcom.com,
	jerin.jacob@caviumnetworks.com, mjatharakonda@oneconvergence.com,
	simon.horman@corigine.com, david.george@sophos.com,
	sony.chacko@qlogic.com, harish.patil@qlogic.com,
	stephen@networkplumber.org, jerinjacobk@gmail.com,
	Conor Walsh <conor.walsh@intel.com>,
	stable@dpdk.org
Subject: [PATCH 6/6] examples/performance-thread: fix unused but set variables
Date: Mon, 15 Nov 2021 17:58:55 +0000	[thread overview]
Message-ID: <20211115175855.1091621-7-conor.walsh@intel.com> (raw)
In-Reply-To: <20211115175855.1091621-1-conor.walsh@intel.com>

This patch removes the hits variable from the cpu_load_collector function
within the performance thread example app as it is an unused but set
variable.

Bugzilla ID: 881
Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app")
Cc: stable@dpdk.org

Reported-by: Liang Longfeng <longfengx.liang@intel.com>
Signed-off-by: Conor Walsh <conor.walsh@intel.com>
---
 examples/performance-thread/l3fwd-thread/main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c
index 3a6a33bda3..8a35040597 100644
--- a/examples/performance-thread/l3fwd-thread/main.c
+++ b/examples/performance-thread/l3fwd-thread/main.c
@@ -1885,7 +1885,6 @@ process_burst(struct rte_mbuf *pkts_burst[MAX_PKT_BURST], int nb_rx,
 static int __rte_noreturn
 cpu_load_collector(__rte_unused void *arg) {
 	unsigned i, j, k;
-	uint64_t hits;
 	uint64_t prev_tsc, diff_tsc, cur_tsc;
 	uint64_t total[MAX_CPU] = { 0 };
 	unsigned min_cpu = MAX_CPU;
@@ -1972,12 +1971,10 @@ cpu_load_collector(__rte_unused void *arg) {
 			printf("cpu#     proc%%  poll%%  overhead%%\n\n");
 
 			for (i = min_cpu; i <= max_cpu; i++) {
-				hits = 0;
 				printf("CPU %d:", i);
 				for (j = 0; j < MAX_CPU_COUNTER; j++) {
 					printf("%7" PRIu64 "",
 							cpu_load.hits[j][i] * 100 / cpu_load.counter);
-					hits += cpu_load.hits[j][i];
 					cpu_load.hits[j][i] = 0;
 				}
 				printf("%7" PRIu64 "\n",
-- 
2.25.1


  parent reply	other threads:[~2021-11-15 18:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 14:01 [PATCH 0/7] " Conor Walsh
2021-11-12 14:01 ` [PATCH 1/7] app/test: " Conor Walsh
2021-11-12 14:29   ` Medvedkin, Vladimir
2021-11-12 14:01 ` [PATCH 2/7] drivers/bus/fslmc: " Conor Walsh
2021-11-12 14:01 ` [PATCH 3/7] drivers/common/qat: " Conor Walsh
2021-11-12 14:01 ` [PATCH 4/7] drivers/event/sw: " Conor Walsh
2021-11-12 15:15   ` Van Haaren, Harry
2021-11-12 14:01 ` [PATCH 5/7] drivers/net: " Conor Walsh
2021-11-12 16:17   ` Ferruh Yigit
2021-11-12 16:27     ` David Marchand
2021-11-12 16:38       ` Walsh, Conor
2021-11-12 16:41         ` Stephen Hemminger
2021-11-12 16:46           ` Walsh, Conor
2021-11-12 16:35     ` Walsh, Conor
2021-11-15  9:28   ` David Marchand
2021-11-16  4:58     ` Somnath Kotur
2021-11-16  5:08       ` Ajit Khaparde
2021-11-12 14:01 ` [PATCH 6/7] examples/performance-thread: " Conor Walsh
2021-11-12 14:01 ` [PATCH 7/7] lib/power: " Conor Walsh
2021-11-12 14:13   ` David Marchand
2021-11-12 14:17     ` Walsh, Conor
2021-11-12 14:26       ` David Marchand
2021-11-15 17:58 ` [PATCH 0/6] " Conor Walsh
2021-11-15 17:58   ` [PATCH 1/6] app/test: " Conor Walsh
2021-11-15 17:58   ` [PATCH 2/6] drivers/bus/fslmc: " Conor Walsh
2021-11-15 17:58   ` [PATCH 3/6] drivers/common/qat: " Conor Walsh
2021-11-15 17:58   ` [PATCH 4/6] drivers/event/sw: " Conor Walsh
2021-11-15 17:58   ` [PATCH 5/6] drivers/net: " Conor Walsh
2021-11-16 12:04     ` David Marchand
2021-11-15 17:58   ` Conor Walsh [this message]
2021-11-16 12:28   ` [PATCH 0/6] " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211115175855.1091621-7-conor.walsh@intel.com \
    --to=conor.walsh@intel.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=cloud.wangxiaoyun@huawei.com \
    --cc=david.george@sophos.com \
    --cc=david.hunt@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=ferruh.yigit@intel.com \
    --cc=fiona.trahe@intel.com \
    --cc=gakhil@marvell.com \
    --cc=harish.patil@qlogic.com \
    --cc=harry.van.haaren@intel.com \
    --cc=heinrich.kuhn@corigine.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hkalra@marvell.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jerinjacobk@gmail.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=john.griffin@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=kishore.padmanabha@broadcom.com \
    --cc=lance.richardson@broadcom.com \
    --cc=longfengx.liang@intel.com \
    --cc=michael.baucom@broadcom.com \
    --cc=mjatharakonda@oneconvergence.com \
    --cc=rmody@marvell.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=sameh.gobriel@intel.com \
    --cc=simon.horman@corigine.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=sony.chacko@qlogic.com \
    --cc=srinivasan@marvell.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=sthotton@marvell.com \
    --cc=venkatkumar.duvvuru@broadcom.com \
    --cc=vladimir.medvedkin@intel.com \
    --cc=xuanziyang2@huawei.com \
    --cc=yipeng1.wang@intel.com \
    --cc=yongwang@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).