From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39692A0C47; Tue, 16 Nov 2021 20:10:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23805407FF; Tue, 16 Nov 2021 20:10:20 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id ED73440040 for ; Tue, 16 Nov 2021 20:10:18 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 4E2AB20C6371; Tue, 16 Nov 2021 11:10:18 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4E2AB20C6371 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1637089818; bh=Gg6Ruj7xPOLvxMyYsUpbe0BPlgjqFRb5A24wH+tfdP0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RpSpQo2WjSNujyudzqWkRk3Rl10h5EidA58qWZWSofhvM0Z2GqNlC0U68S3A230nP QJdb6oZOlZmxg3MkL25q5x8SY62i3pmhP9gUUZrciYCAprNgR5TifTUdznvcCS/psm xOel+ZyCjK9aI+8TDFYepDTPeIL3XVtJbJZEfubc= Date: Tue, 16 Nov 2021 11:10:18 -0800 From: Tyler Retzlaff To: "Ananyev, Konstantin" Cc: "dev@dpdk.org" Subject: Re: ethdev: hide internal structures Message-ID: <20211116191018.GA31070@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20211116002440.GA17166@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 16, 2021 at 10:32:55AM +0000, Ananyev, Konstantin wrote: > > rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback are internal > data structures that were used by public inline ethdev functions. > Well behaving app should not access these data structures directly. > So, for well behaving app there should no changes in the code required. > That what I meant by 'transparent' above. > But it is still an ABI change, so yes, the app has to be re-compiled. so it appears the application was establishing a private context / vendor extension between the application and a pmd. the application was abusing access to the rte_eth_devices[] to get the private context from the rte_eth_dev. is there a proper / supported way of providing this functionality through the public api? > > Konstantin