From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55930A0C47; Tue, 16 Nov 2021 21:44:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A15040141; Tue, 16 Nov 2021 21:44:11 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 9B9AB40040 for ; Tue, 16 Nov 2021 21:44:09 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id E5A5120C636F; Tue, 16 Nov 2021 12:44:08 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E5A5120C636F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1637095448; bh=Oyt2lEPmH6VXLTTLE6rF+zhSjMaeIoGys/vwBCHlEXY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GTo1fKNnB8JYBUFEcSHoqAsGGKbjOtzXfGNiLsQZ0QVNBKUMqmgLeMg5UmXR9AJxg FCRkseICxoq8Map+r1wqwLn6Ijxg2MSPKeMD6LK/mxFSU2M7pjZAyE7u9F+Mk6f2xY RKRxZCHVxzGcNrZOn9xQ+sFMTSGNUgLKbmlE4a34= Date: Tue, 16 Nov 2021 12:44:08 -0800 From: Tyler Retzlaff To: Ferruh Yigit Cc: Konstantin Ananyev , dev@dpdk.org, Ray Kinsella , Thomas Monjalon , David Marchand Subject: Re: ethdev: hide internal structures Message-ID: <20211116204408.GA7119@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20211116002440.GA17166@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <15f9b491-6c36-dc85-6348-d746196d4374@intel.com> <20211116175453.GA16051@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <1a3f1e7f-06bf-ef39-6819-339b0a8a29d4@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a3f1e7f-06bf-ef39-6819-339b0a8a29d4@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 16, 2021 at 08:07:49PM +0000, Ferruh Yigit wrote: > On 11/16/2021 5:54 PM, Tyler Retzlaff wrote: > > > >i thought someone was responsible for reviewing abi/api related changes > >on the board to understand the implications of changes like this? > > > > Sorry for the negative impact on your product, I can understand the > frustration. > > The 'rte_eth_devices[]' was marked as '@internal' in the header file > since 2012 [1], so it is not new, but it was not marked programmatically, > only as comment in the header file. > Expectation was applications to not directly use it. unfortunately there are a lot of these expectations in the project code, rarely do consuming applications get written in the way we would expect and this is a lesson that if it is not mechanically enforced it isn't prevented. > > > For long term ABI stability, this is a good step forward, although > the impact was known, best time for these kind of change is the 21.11 > release, otherwise change needs to wait (at least) one more year. agreed, we appreciate what will be accomplished with the change. > > This change has been discussed and accepted in the technical board [2], > and a deprecation notice has been sent to mail list [3] for notification. the notes from [2] aren't that clear, but i think it is fair you point out that if [3] were read carefully it was implied that it would impact ethdev. anyway, it is moot now. > > Agree the announce was a little late than we normally do (although > only a month late than what defined in process), this is accepted by > the board to not miss the ABI break window (.11 release). > As you will recognize, not only ethdev, but a few more device abstraction > layer libraries had similar changes in this release. yes, i understand. perhaps in the future it may be possible to introduce some kind of __deprecation notice during compilation earlier than the removal and it may have been noticed sooner. perhaps a patch that did this near the time of the original notification [2]. i've left the details of the functional gap in my other reply to the thread, hopefully you have a suggestion. thanks Ferruh, appreciate it. > > > [1] > f831c63cbe86 ("ethdev: minor changes") > > [2] > https://mails.dpdk.org/archives/dev/2021-July/214662.html > > [3] > https://patches.dpdk.org/project/dpdk/patch/20210826103500.2172550-1-ferruh.yigit@intel.com/