From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3A30A0C41; Thu, 18 Nov 2021 05:11:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B20EE40696; Thu, 18 Nov 2021 05:11:09 +0100 (CET) Received: from relay.smtp-ext.broadcom.com (lpdvacalvio01.broadcom.com [192.19.166.228]) by mails.dpdk.org (Postfix) with ESMTP id 715E440395 for ; Thu, 18 Nov 2021 05:11:08 +0100 (CET) Received: from dhcp-10-123-153-55.dhcp.broadcom.net (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 1249580F5; Wed, 17 Nov 2021 20:11:05 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 1249580F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1637208667; bh=5Qo1c4ZirHmoS/huXZ3JMGdE9LlA0pzEo0CvwtE58WE=; h=From:To:Cc:Subject:Date:From; b=AMUP5ooU/bFF9kb0OIj4hJ0xm2H+ofVdoUqEuEJYVREDDFR1t9GFezQRwg/FBH9yk a7nZLtwMQS6nn3QvUSfIVDsQzepxym5FLw19HPl/3h68ceaqAVDoUKzFRWvIxwTqwQ XLlLnUj6sn/CxRY8Bq8YRaKZElYKyNLfKx7/EQ7k= From: Somnath Kotur To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Somnath Kotur , Charlie Brtee , Ajit Khaparde Subject: [PATCH] net/bnxt: fix autoneg on PAM4 links Date: Thu, 18 Nov 2021 09:34:39 +0530 Message-Id: <20211118040439.24583-1-somnath.kotur@broadcom.com> X-Mailer: git-send-email 2.28.0.450.g3a238e5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If autonegotiation was enabled, driver was not passing the 'auto_pam4_link_speeds' obtained during init and stored in bp->link_info to bnxt_hwrm_port_phy_cfg(). This would result in an incorrect setting being passed to the HW during PHY configuration. This in turn, would result in invalid settings being retrieved and configured in subsequent application loads resulting in launch failures. Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link") Reported-by: Charlie Brtee Reviewed-by: Ajit Khaparde Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_hwrm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 67ed807dad..df75047e2d 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -3247,6 +3247,8 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up) link_req.auto_link_speed_mask = bnxt_parse_eth_link_speed_mask(bp, dev_conf->link_speeds); + link_req.auto_pam4_link_speeds = + bp->link_info->auto_pam4_link_speeds; } else { if (bp->link_info->phy_type == HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASET || -- 2.28.0.497.g54e85e7