* [PATCH] net/bnxt: restore fast-path API pointers post recovery
@ 2021-11-22 4:53 Somnath Kotur
2021-11-22 5:19 ` Ajit Khaparde
0 siblings, 1 reply; 2+ messages in thread
From: Somnath Kotur @ 2021-11-22 4:53 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Somnath Kotur, Kalesh AP
In bnxt_dev_recover(), restore the newly introduced fast-path API pointers
(struct rte_eth_fp_ops)->rx_pkt_burst to the real burst routines instead of
the dummy ones, once error recovery has successfully completed.
Fixes: c87d435a4d79 ("ethdev: copy fast-path API into separate structure")
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index c1bdf9a921..f79f33ab4e 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -4345,6 +4345,12 @@ static void bnxt_dev_recover(void *arg)
goto err_start;
}
+ rte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst =
+ bp->eth_dev->rx_pkt_burst;
+ rte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst =
+ bp->eth_dev->tx_pkt_burst;
+ rte_mb();
+
rc = bnxt_restore_filters(bp);
if (rc)
goto err_start;
--
2.28.0.497.g54e85e7
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net/bnxt: restore fast-path API pointers post recovery
2021-11-22 4:53 [PATCH] net/bnxt: restore fast-path API pointers post recovery Somnath Kotur
@ 2021-11-22 5:19 ` Ajit Khaparde
0 siblings, 0 replies; 2+ messages in thread
From: Ajit Khaparde @ 2021-11-22 5:19 UTC (permalink / raw)
To: Somnath Kotur; +Cc: dpdk-dev, Ferruh Yigit, Kalesh AP
On Sun, Nov 21, 2021 at 8:59 PM Somnath Kotur
<somnath.kotur@broadcom.com> wrote:
>
> In bnxt_dev_recover(), restore the newly introduced fast-path API pointers
> (struct rte_eth_fp_ops)->rx_pkt_burst to the real burst routines instead of
> the dummy ones, once error recovery has successfully completed.
>
> Fixes: c87d435a4d79 ("ethdev: copy fast-path API into separate structure")
>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Squashed with previous commit [1].
[1] https://patchwork.dpdk.org/project/dpdk/patch/20211119035041.4493-1-somnath.kotur@broadcom.com/
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index c1bdf9a921..f79f33ab4e 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -4345,6 +4345,12 @@ static void bnxt_dev_recover(void *arg)
> goto err_start;
> }
>
> + rte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst =
> + bp->eth_dev->rx_pkt_burst;
> + rte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst =
> + bp->eth_dev->tx_pkt_burst;
> + rte_mb();
> +
> rc = bnxt_restore_filters(bp);
> if (rc)
> goto err_start;
> --
> 2.28.0.497.g54e85e7
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-22 5:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 4:53 [PATCH] net/bnxt: restore fast-path API pointers post recovery Somnath Kotur
2021-11-22 5:19 ` Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).