From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35113A0C52; Wed, 24 Nov 2021 10:36:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9B3441143; Wed, 24 Nov 2021 10:36:20 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2045.outbound.protection.outlook.com [40.107.243.45]) by mails.dpdk.org (Postfix) with ESMTP id A44474003C for ; Wed, 24 Nov 2021 10:36:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQB9pmOx6GoX+CWnMcPTxYPFsPwYX0F5YQtt5TWfNrkmxSJU9RHfD2v3AH0UbBHufNbJrFqdfJ7J7r0nN8cgcbovhI9KTMQftupw44TcD+ChlSVrj9uiRD+dPcTD+Zj7vQhiqTJSk1boUdrgaRpgLbKpY77yOT0Z1L1mdxOyE255M9FiH++MB1rVqeUiFUrXjA1wu8vA2f6DtRlnO9uNRb9uSl8MS26HWPcr1wZNm5MQSWEcQJ4g6EOUl3hsmpcAKeZPSXdwsFuDWcDKjW+hqeHpvgFp9LJaQKp+dovDn2PKJ5lHF1UaEn27xzqMiQ32qZfH9zu7wqNf3Cjaa3SONQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+ptZHFWO6YTp0clNQoAGZT9zrgFvgfi35RSo365NPXY=; b=TXLywhW2YzhwPkAkxTtjbEOA7NYHEIeDzQPUHAEyot1gaCFQt98MuQeCHYjdHKBGOpmROiX5zSa7F2gVMlhm0WvhH1AiT/S1XaRTN3eOc4h4JWl7g2DLM/JZBvSkOtjmmTyMqvWB1L7/evAMSwhQFH4AJQVh0kQlivitDDkYKi95jWzbAP1JORmR0T/ecHTRFp/0gzFebpPMp7q4preOk/fh6mtlF/SHwesNsZSZmtTw9taFVQKxBzMC9ucJHs/DZIIFjrFQX3Oip6QUJtTZatBuscxJSL4fZwiuEUOvvf0TAdtIqptO2lJPvzkXeaapo3SZUWH7OAcxaDCySywESg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ptZHFWO6YTp0clNQoAGZT9zrgFvgfi35RSo365NPXY=; b=llsnAnybCX+iY6mXT5ZcKxNSeARueWvatolCyRtoxWD69Ojvfxvwi/6YETEdgUmpmtCakmn3R9UUWBbUAVyutlwZH3YDlTaT9m3iz+lOCu3c1tFjLnCW6f7AIHWxHJbqjqbc1HQIlmJdpXpj5RCt1kMqRKJIibE/DvOGs4Tg/2lWROWWWY4g0D7WaMcR9ZqDECa/CXXuiStABryejagLmzJ/lR+oTKdQfX9qY80pt1ogSRE2x4Ks+J/QfMx/AoCyULrpQ3KvkvTy2CKStGBQvDUeZ3uJTbdvRmcgdB2km7o7ZjSavy0zLpCJb+vxGoygar8wAYr74k8LvnDXtBXuVg== Received: from DM6PR03CA0042.namprd03.prod.outlook.com (2603:10b6:5:100::19) by CY4PR12MB1798.namprd12.prod.outlook.com (2603:10b6:903:11a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Wed, 24 Nov 2021 09:36:16 +0000 Received: from DM6NAM11FT026.eop-nam11.prod.protection.outlook.com (2603:10b6:5:100:cafe::d3) by DM6PR03CA0042.outlook.office365.com (2603:10b6:5:100::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend Transport; Wed, 24 Nov 2021 09:36:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT026.mail.protection.outlook.com (10.13.172.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4713.20 via Frontend Transport; Wed, 24 Nov 2021 09:36:15 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 24 Nov 2021 09:36:11 +0000 From: Dmitry Kozlyuk To: CC: Raslan Darawsheh , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH 1/2] net/mlx5: fix indirect RSS creation when port is stopped Date: Wed, 24 Nov 2021 11:35:52 +0200 Message-ID: <20211124093556.3358394-2-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211124093556.3358394-1-dkozlyuk@nvidia.com> References: <20211123223159.3324247-1-dkozlyuk@nvidia.com> <20211124093556.3358394-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5415f257-1588-4f40-9e80-08d9af2ddc64 X-MS-TrafficTypeDiagnostic: CY4PR12MB1798: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V315Wj427hFz8lJDfx+F3tckHWQlDyG6i+R9YHtJU8GSLfRRWTKThzkb49ia/k4/J0qbK4yMS20utmKFfMfcKsqjsWe/KMXHZJ/mN2YJjT7s/762PjaN/L6hSdVBlfpSKsCO2O2F5HbteITx4MbpEXdpbgsBlknDv0Us2LBK2uEz3l98XmBGPsYgdf49AJDOOFIMX9oRken+wWwA1s2lOjO7b/mnrWPD0nxf7eFky6vbKYtPtDurxV0iTMIVW95tR1DNk2dPDWFimc0YTmG+blj0cfar7IN12qiSH1e8/NwunRnHkYa4evfWApiZF9oAktxensjMS2ez2p21HxRVQwC5rnSL8yGgtJUL+3jhaxh65gBVX/NE+KiUFbtHYOjCEjWQUSCCaMYc6WhAhhUCsRcI9yf4tDhSHSDEjO2EUTohkANsMnd5pZ43LcJFefYlzwEqcyO1AXLyqsdds3UoXJBoHF0Ud1TyNn2FqvAqprb8+C++PlfhRJ3hRUk+Fk/qzTiiHyLLfe+EyHy8GH75DBKOdzdSKpDD3PaA+cegoKFQaDBDfvP4dOkm12VMVsdQ0PkvOgriqGlibedgqtA8Mnpmd91WCGpr93zMdgmVE4pJTL4ub3kg289OJcnC8bQJ3rRXK3XRnFfQ8G5Eu7JIS9lsuy8oHFdC5nCXjNLuUc7WPd8C9gvi0eTT4NfPkcIqiwUmr3h7O1VmHujyRlVX5w== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(4326008)(8936002)(2906002)(6286002)(47076005)(5660300002)(107886003)(16526019)(83380400001)(7696005)(26005)(6666004)(86362001)(36860700001)(82310400004)(6916009)(186003)(508600001)(316002)(336012)(7636003)(70586007)(426003)(70206006)(1076003)(356005)(8676002)(55016003)(36756003)(54906003)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2021 09:36:15.4357 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5415f257-1588-4f40-9e80-08d9af2ddc64 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT026.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1798 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org mlx5_ind_table_obj_setup() was incrementing RxQ reference counters even when the port was stopped, which prevented RxQ release and triggered an internal assertion. Only increment reference counter when the port is started. Fixes: ec4e11d41d12 ("net/mlx5: preserve indirect actions on restart") Signed-off-by: Dmitry Kozlyuk --- drivers/net/mlx5/mlx5_rxq.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 47dc24793b..8f9a94572f 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -2270,6 +2270,7 @@ mlx5_ind_table_obj_setup(struct rte_eth_dev *dev, struct mlx5_ind_table_obj *ind_tbl) { struct mlx5_priv *priv = dev->data->dev_private; + bool dev_started = priv->dev_data->dev_started; uint32_t queues_n = ind_tbl->queues_n; uint16_t *queues = ind_tbl->queues; unsigned int i, j; @@ -2278,22 +2279,25 @@ mlx5_ind_table_obj_setup(struct rte_eth_dev *dev, log2above(queues_n) : log2above(priv->config.ind_table_max_size); - for (i = 0; i != queues_n; ++i) { - if (mlx5_rxq_ref(dev, queues[i]) == NULL) { - ret = -rte_errno; - goto error; + if (dev_started) + for (i = 0; i != queues_n; ++i) { + if (mlx5_rxq_ref(dev, queues[i]) == NULL) { + ret = -rte_errno; + goto error; + } } - } ret = priv->obj_ops.ind_table_new(dev, n, ind_tbl); if (ret) goto error; __atomic_fetch_add(&ind_tbl->refcnt, 1, __ATOMIC_RELAXED); return 0; error: - err = rte_errno; - for (j = 0; j < i; j++) - mlx5_rxq_deref(dev, ind_tbl->queues[j]); - rte_errno = err; + if (dev_started) { + err = rte_errno; + for (j = 0; j < i; j++) + mlx5_rxq_deref(dev, queues[j]); + rte_errno = err; + } DRV_LOG(DEBUG, "Port %u cannot setup indirection table.", dev->data->port_id); return ret; -- 2.25.1