From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF15FA0C45; Thu, 25 Nov 2021 15:30:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64A494270A; Thu, 25 Nov 2021 15:30:38 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2085.outbound.protection.outlook.com [40.107.92.85]) by mails.dpdk.org (Postfix) with ESMTP id 4FE5542708 for ; Thu, 25 Nov 2021 15:30:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EGfgZQwuJte3zmDh6DDbEHbBWW/OBZgeWVZEjNt2il+XLuZiUS541Rb+mOLyerf9JcyNPdvapb6PLceLMlv6RxFZ5jY0qce41tvg++z0L0sV/NVhQPxizdo7CKM7i/aBL5lTomySxdnumIZ+GfNKRdEr0oE3TmZXJ7Q+WoAG7uKf1mIK5+wt4ZzYOwvyORNm1+urhUlnN0Kfp0Nu8AOMDLqYJdI8guQGXdjjlmE0u29h3HfLARagu6HZkZFEMHpznvrSgYmuuxfgXRH6ZMWkjSWjyHnj/z3uP64UUJkz3fw45LjT61jnFEooKYru+dc4iKYxZoYbxZqarvz7J3J8RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RiLUnBxgFxBrNI20uXu3wtTrZzgtYh1jLH3MHVPKjww=; b=CYwGAthNL0+Rg4KPA84CjWPqn835748Q+aIfQutfBb/iFi/jxNRiWqe9hu5dc/grYWFQISL1Q1d58aWHst2nV1DyCtILgu5xqpzMva6CxbV241XGECJC6acIh4bygNgW80oyUb5XIUzeJVJNpIvJef7NVI8WBu9g7BlR8zjKQE5YGZ4gyVwmrfjHPnFxbjO32i922yPUwOKNIFalIxtsoVFXXzHrHwnOQMXvZht8Ed42t5u1y9oJy9JaVumG3FgKaE94ipFoQV/rRtEA+UWxUMLyJ/2e50KktRKxXlHB1qaazraCufxcoKTVGdoEh0YFo6AFP0/DuAARIvlDByWYug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RiLUnBxgFxBrNI20uXu3wtTrZzgtYh1jLH3MHVPKjww=; b=DfFtlUoujqv7nhHhgxU0q3hg3waPbT8DfCaK8UyjEudHtNneJoPRF0V2QWH7Lakdy893VUWDL3oLmyKdwVB0wcEZN/YmfIX+YTU0OrhNrdch2AiThdUZ4JL+pcKXzZ6I9ZxPulWta8WLh7KyGo971MxnycOFP6kXbmx5RxzYv0mzs+NTME29jkdPJIAlzN6lDNNZnun83AWGMSZLmkWXKX+VtLi+nT8LMNWGSfMYy2Oa1ibI0MTx44bbapuOeq0K71f/suX1mgPvHkSLG3rSQUII3KqmncWvnfpwpAEz1X7fmco5XzMIGXttrGIYaj+/UM1DpSCn8hCM5+vpGzy6qw== Received: from MW4PR04CA0240.namprd04.prod.outlook.com (2603:10b6:303:87::35) by DM6PR12MB4531.namprd12.prod.outlook.com (2603:10b6:5:2a4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20; Thu, 25 Nov 2021 14:30:34 +0000 Received: from CO1NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:303:87:cafe::be) by MW4PR04CA0240.outlook.office365.com (2603:10b6:303:87::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend Transport; Thu, 25 Nov 2021 14:30:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT063.mail.protection.outlook.com (10.13.175.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4734.22 via Frontend Transport; Thu, 25 Nov 2021 14:30:34 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 25 Nov 2021 14:30:33 +0000 From: To: CC: Elena Agostini Subject: [PATCH v1] gpudev: remove unnecessary rte_gpu_wmb Date: Thu, 25 Nov 2021 22:40:54 +0000 Message-ID: <20211125224054.26157-1-eagostini@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69b9b269-82f3-43d6-401c-08d9b0202426 X-MS-TrafficTypeDiagnostic: DM6PR12MB4531: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vY7qch2ogyBOXNQxZWgzlL/s/yD2MG5F3w4HyeEepA7rhJ3f7Jq4F7vdAwa/eJSrI0wRjkwJFF/OK1AdTj/I17SRmlBjWUGqVmuDX6MHS5i/9NEKdknmOkYrDqt6+cE54UJhEQrjiYD6jf1rGOJSNOhlAlJbEmdjeb97O2zHkTQpOzVAVt2Ucoge/LSs3QHu29TtNuwzNW+Sn5LNbFbB+jAo5D8A6qFU/tNxi7WX69FwtEhe5v2PGmWyPMx7CLcmAJrvgcabAksum1VYFjNmHsfXoYbWFzXUcfmk4GBhURnaGmbGoSxyftyCVCFtGKyRNZV0tv/WAgERtSP3sm+iZV+skn+YFUr6u2JFRZXhoB/lS+ECQjJT5LhroexMNKoYeIn5l/ncYjImuv+hjsswW49+jrXqZ/5G0w6KGXlRfN1ooYINmdh8YKiGepownAc0OJ/4XftGJFOm1w4/P9kKewYUUGhYdpvHrBmX6S76r6z0BR3YYw3CSTyEvjupe4lbrnM1bitdqbRVrxkuOqkaJLQz4cElUIWvUwDbl/gX+KG2StdckMAFC7vtwxUAwJAMfhiLjjxb+a268+a7sa91A/qe3ryuXP6dEGFTsyDGt/d+BEPkE/h/nQY/GloaMnPwnOJNTOWFDs87ACBUdFvY1LwA2QqgE2z7x6kadpLHhqTQMgIYEYOosodbrNpsDzq1Q5ISw+9QDXuOzuwcVfkYnQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(2616005)(70206006)(55016003)(82310400004)(70586007)(36860700001)(316002)(8936002)(7636003)(356005)(2906002)(47076005)(2876002)(4326008)(426003)(6916009)(7696005)(336012)(6666004)(1076003)(26005)(186003)(8676002)(16526019)(86362001)(107886003)(5660300002)(4744005)(508600001)(36756003)(6286002)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 14:30:34.0495 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69b9b269-82f3-43d6-401c-08d9b0202426 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4531 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Elena Agostini Remove unnecessary rte_gpu_wmb from rte_gpu_comm_populate_list_pkts. It causes a performance degradation in case of NVIDIA GPU V100. This change doesn't affect any functionality as the status resides in CPU registered memory. Fixes: c7ebd65c1372 ("gpudev: add communication list") Signed-off-by: Elena Agostini --- lib/gpudev/gpudev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c index 1d8200e71b..9ae36dbae9 100644 --- a/lib/gpudev/gpudev.c +++ b/lib/gpudev/gpudev.c @@ -877,7 +877,6 @@ rte_gpu_comm_populate_list_pkts(struct rte_gpu_comm_list *comm_list_item, RTE_GPU_VOLATILE(comm_list_item->num_pkts) = num_mbufs; rte_gpu_wmb(comm_list_item->dev_id); RTE_GPU_VOLATILE(comm_list_item->status) = RTE_GPU_COMM_LIST_READY; - rte_gpu_wmb(comm_list_item->dev_id); return 0; } -- 2.17.1