DPDK patches and discussions
 help / color / mirror / Atom feed
From: Josh Knight <joshua.knight@netscout.com>
To: keith.wiles@intel.com
Cc: dev@dpdk.org, Josh Knight <joshua.knight@netscout.com>
Subject: [PATCH] pktgen: Fix setting user pattern from cli
Date: Tue, 30 Nov 2021 10:02:18 -0500	[thread overview]
Message-ID: <20211130150218.10254-1-joshua.knight@netscout.com> (raw)

When setting the user pattern from the pktgen cli, it would always be
incorrectly set to the string 'pattern' regardless of input.

This can be demonstrated simply by setting a pattern

    set 0 pattern user
    set 0 user pattern asdfasdf

Signed-off-by: Josh Knight <joshua.knight@netscout.com>
---
 app/cli-functions.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/cli-functions.c b/app/cli-functions.c
index 4293444..41d354b 100644
--- a/app/cli-functions.c
+++ b/app/cli-functions.c
@@ -652,7 +652,7 @@ set_cmd(int argc, char **argv)
 			break;
 		case 25:
 			foreach_port(portlist,
-				 pattern_set_user_pattern(info, argv[3]));
+				 pattern_set_user_pattern(info, argv[4]));
 			break;
 		case 30:
 			p = strchr(argv[4], '/');
-- 
2.30.1 (Apple Git-130)


                 reply	other threads:[~2021-11-30 15:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211130150218.10254-1-joshua.knight@netscout.com \
    --to=joshua.knight@netscout.com \
    --cc=dev@dpdk.org \
    --cc=keith.wiles@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).