From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2632EA0C4C; Wed, 1 Dec 2021 08:19:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E1E74068C; Wed, 1 Dec 2021 08:19:21 +0100 (CET) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mails.dpdk.org (Postfix) with ESMTP id B3E2A4067B for ; Wed, 1 Dec 2021 08:19:20 +0100 (CET) Received: by mail-lf1-f54.google.com with SMTP id l22so60409126lfg.7 for ; Tue, 30 Nov 2021 23:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QDUCS0pxLge50eNZLyi/zI6EwZ11BwwzIeFxEV0pKN4=; b=oWizxZyDMuaqat8QAeNNzoxIlAfR99kv8zFBODQjrcn+80pzLlTiD0RpU+d40tSJuG jI/NVDJMxf2rDL/5+fQSJgRB6XhYHetZzy0lxBTyolCt12HFBYDDLke1lc19jd0Rr0k9 FSvkzdV/xdzoehurTSo4hZOrLmuEepxZTI/NTCOionwmSgAl5KUfXAZM4kEsB98LxPz/ bUQ9FrisY+YRE/XkEyg1lV9Xw1fYMUo/DzQI9Kv+HLHooBtvCthZrVG3ltEQmd7FK1d5 7DTDGl0RPMbYEko6f5eBg6Ek7XJokpRDG/CwMT9n1+KhJ5mCts8dv0lmw9ill4b4hf4p RwaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QDUCS0pxLge50eNZLyi/zI6EwZ11BwwzIeFxEV0pKN4=; b=dmphDlGUiwlwNb4vfFOR8rReMRYbruwydtPKh3svE35bnUr0P6ELnZPsl7gTC45E9D cJe5kv0EMXrwtNc8ePWi4AB3gmYJXwZPTitFHvTAhDksiSdnqPVTHIy/mHFefM/jSozs V3d6Jcy75yrFqn24cJE/priUE5lJT1RH8sLXCp5kvwPeQFLvrjvR+fq65kD0BVXBhLt2 5JRLxCYzG7a4zny3UYMbvvJKJQSsqGAbQlwe/JIFUnIfKoN1VutpK79JKbWsZN+ohv69 j2r05b6fwpGtG9G1L65XlzQ0Unv9gERkt1bvXQ291bnZ8zQtOUYhHEm1TxEZddRR5Kap neQg== X-Gm-Message-State: AOAM5323MNMo2Ld6yfodFK72lSj2v3XTeCr2cZN6G9xMLSe6O2ALBrZW Xazh1z1qtGoA3ZBWz1M0rLw= X-Google-Smtp-Source: ABdhPJw4nrrGn0cEyxxbKAoiLhAW2wnWlLmT7wtUVSKOdujkXemwgWyYLlnaBFWHPPQvLUCZR/z+ug== X-Received: by 2002:a19:c3d5:: with SMTP id t204mr4222618lff.303.1638343160116; Tue, 30 Nov 2021 23:19:20 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id j15sm1985976lfg.167.2021.11.30.23.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 23:19:19 -0800 (PST) Date: Wed, 1 Dec 2021 10:19:19 +0300 From: Dmitry Kozlyuk To: Jie Zhou Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Subject: Re: [PATCH v8 03/11] app/test: replace POSIX specific code Message-ID: <20211201101919.45fe7152@sovereign> In-Reply-To: <20211201010538.GA15157@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1635215204-20604-1-git-send-email-jizh@linux.microsoft.com> <1635216361-23641-1-git-send-email-jizh@linux.microsoft.com> <1635216361-23641-4-git-send-email-jizh@linux.microsoft.com> <20211124010206.6ca9d9cf@sovereign> <20211201010538.GA15157@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2021-11-30 17:05 (UTC-0800), Jie Zhou: > On Wed, Nov 24, 2021 at 01:02:06AM +0300, Dmitry Kozlyuk wrote: [...] > > [...] > > > diff --git a/app/test/test_cmdline.c b/app/test/test_cmdline.c > > > index 115bee966d..9a76bd299f 100644 > > > --- a/app/test/test_cmdline.c > > > +++ b/app/test/test_cmdline.c > > > @@ -31,6 +31,7 @@ test_cmdline(void) > > > return -1; > > > if (test_parse_num_invalid_param() < 0) > > > return -1; > > > +#ifndef RTE_EXEC_ENV_WINDOWS > > > printf("Testing parsing IP addresses...\n"); > > > if (test_parse_ipaddr_valid() < 0) > > > return -1; > > > @@ -38,6 +39,7 @@ test_cmdline(void) > > > return -1; > > > if (test_parse_ipaddr_invalid_param() < 0) > > > return -1; > > > +#endif > > > printf("Testing parsing strings...\n"); > > > if (test_parse_string_valid() < 0) > > > return -1; > > > > What's wrong with parsing IP addresses on Windows? > > > test_cmdline_ipaddr.c uses linux netinet/in.h specific u6_addr. Skip these > 3 cases for now and prefer a separate patch to make it work on Windows. Or > maybe there is already DPDK support on this which I am not aware of? Thanks. Understood, only please explain this in the commit log.