[PATCH v2 1/2] devtools: don't include headline "fix" in backports

[PATCH v2 1/2] devtools: don't include headline "fix" in backports

[christian.ehrhardt]

From: Christian Ehrhardt <christian.ehrhardt@canonical.com>

It was important in the past to select anything with "fix" in the
headline, but recently more often created false positives and work
to sort tihngs out than identifying many helpful patches.

The community and processes aroudn DPDK matured enough that developers
(rightfully) expect to rely on "Fixes:" and "stable@" marking for
backprots.

Therefore do no more include patches that just include the word fix
in the backport candidate list.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 devtools/git-log-fixes.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
index 210c8dcf25..27ec9088d4 100755
--- a/devtools/git-log-fixes.sh
+++ b/devtools/git-log-fixes.sh
@@ -13,7 +13,7 @@ print_help ()
 	cat <<- END_OF_HELP
 
 	Find fixes to backport on previous versions.
-	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
+	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.
 	The oldest bug origin is printed as well as partially fixed versions.
 	END_OF_HELP
 }
@@ -109,8 +109,7 @@ while read id headline ; do
 	origins=$(origin_filter $id)
 	stable=$(stable_tag $id)
 	fixes=$(fixes_tag $id)
-	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \
-		echo "$headline" | grep -q fix || continue
+	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue
 	version=$(commit_version $id)
 	if [ -n "$origins" ] ; then
 		origver="$(origin_version $origins)"
-- 
2.34.0

[PATCH v2 2/2] devtools: report commit id on partial fixes

[christian.ehrhardt]

From: Christian Ehrhardt <christian.ehrhardt@canonical.com>

The candidate list for backports lists partial fixes like:
 "(21.02 (partially fixed in 21.08))"
That is useful to identify fixes menat for later releases, but
indirectly applying to older ones as well.

While the devscript has no access to the stable tree to fully check
if the respective interim commit is present there, reporting the commit
id will still help to check it later - because only if the interim commit
id is in the stable tree, then also the new fix is a real candidate
for backporting.

The above would become "(21.02 (partially fixed in c30751afc360 @ 21.08))"

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 devtools/git-log-fixes.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
index 27ec9088d4..a1b548948a 100755
--- a/devtools/git-log-fixes.sh
+++ b/devtools/git-log-fixes.sh
@@ -76,7 +76,7 @@ origin_version () # <origin_hash> ...
 			# look chained fix of fix recursively
 			local rootver="$(origin_version $roothashes)"
 			[ -n "$rootver" ] || continue
-			echo "$rootver (partially fixed in $origver)"
+			echo "$rootver (partially fixed in $origin @ $origver)"
 		else
 			echo "$origver"
 		fi
-- 
2.34.0

Re: [PATCH v2 1/2] devtools: don't include headline "fix" in backports

[Luca Boccassi]

On Fri, 2021-12-03 at 08:54 +0100, christian.ehrhardt@canonical.com
wrote:
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> It was important in the past to select anything with "fix" in the
> headline, but recently more often created false positives and work
> to sort tihngs out than identifying many helpful patches.
> 
> The community and processes aroudn DPDK matured enough that developers
> (rightfully) expect to rely on "Fixes:" and "stable@" marking for
> backprots.
> 
> Therefore do no more include patches that just include the word fix
> in the backport candidate list.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>  devtools/git-log-fixes.sh | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> index 210c8dcf25..27ec9088d4 100755
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> @@ -13,7 +13,7 @@ print_help ()
>  	cat <<- END_OF_HELP
>  
> 
>  	Find fixes to backport on previous versions.
> -	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
> +	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.
>  	The oldest bug origin is printed as well as partially fixed versions.
>  	END_OF_HELP
>  }
> @@ -109,8 +109,7 @@ while read id headline ; do
>  	origins=$(origin_filter $id)
>  	stable=$(stable_tag $id)
>  	fixes=$(fixes_tag $id)
> -	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \
> -		echo "$headline" | grep -q fix || continue
> +	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue
>  	version=$(commit_version $id)
>  	if [ -n "$origins" ] ; then
>  		origver="$(origin_version $origins)"

Acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi

Re: [PATCH v2 2/2] devtools: report commit id on partial fixes

[Luca Boccassi]

On Fri, 2021-12-03 at 08:54 +0100, christian.ehrhardt@canonical.com
wrote:
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> The candidate list for backports lists partial fixes like:
>  "(21.02 (partially fixed in 21.08))"
> That is useful to identify fixes menat for later releases, but
> indirectly applying to older ones as well.
> 
> While the devscript has no access to the stable tree to fully check
> if the respective interim commit is present there, reporting the commit
> id will still help to check it later - because only if the interim commit
> id is in the stable tree, then also the new fix is a real candidate
> for backporting.
> 
> The above would become "(21.02 (partially fixed in c30751afc360 @ 21.08))"
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>  devtools/git-log-fixes.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> index 27ec9088d4..a1b548948a 100755
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> @@ -76,7 +76,7 @@ origin_version () # <origin_hash> ...
>  			# look chained fix of fix recursively
>  			local rootver="$(origin_version $roothashes)"
>  			[ -n "$rootver" ] || continue
> -			echo "$rootver (partially fixed in $origver)"
> +			echo "$rootver (partially fixed in $origin @ $origver)"
>  		else
>  			echo "$origver"
>  		fi

Acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi

Re: [PATCH v2 1/2] devtools: don't include headline "fix" in backports

[Kevin Traynor]

On 03/12/2021 07:54, christian.ehrhardt@canonical.com wrote:
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> It was important in the past to select anything with "fix" in the
> headline, but recently more often created false positives and work
> to sort tihngs out than identifying many helpful patches.
> 
> The community and processes aroudn DPDK matured enough that developers
> (rightfully) expect to rely on "Fixes:" and "stable@" marking for
> backprots.

nit: several typos here and i think it should say "or" stable@

> 
> Therefore do no more include patches that just include the word fix
> in the backport candidate list.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>   devtools/git-log-fixes.sh | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> index 210c8dcf25..27ec9088d4 100755
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> @@ -13,7 +13,7 @@ print_help ()
>   	cat <<- END_OF_HELP
>   
>   	Find fixes to backport on previous versions.
> -	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
> +	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.

"..or for recipient stable@dpdk.org."

Good idea, thanks. With minor fixes,

Acked-by: Kevin Traynor <ktraynor@redhat.com>

>   	The oldest bug origin is printed as well as partially fixed versions.
>   	END_OF_HELP
>   }
> @@ -109,8 +109,7 @@ while read id headline ; do
>   	origins=$(origin_filter $id)
>   	stable=$(stable_tag $id)
>   	fixes=$(fixes_tag $id)
> -	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \
> -		echo "$headline" | grep -q fix || continue
> +	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue
>   	version=$(commit_version $id)
>   	if [ -n "$origins" ] ; then
>   		origver="$(origin_version $origins)"
> 

Re: [PATCH v2 2/2] devtools: report commit id on partial fixes

[Kevin Traynor]

On 03/12/2021 07:54, christian.ehrhardt@canonical.com wrote:
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> The candidate list for backports lists partial fixes like:
>   "(21.02 (partially fixed in 21.08))"
> That is useful to identify fixes menat for later releases, but
> indirectly applying to older ones as well.
> 
> While the devscript has no access to the stable tree to fully check
> if the respective interim commit is present there, reporting the commit
> id will still help to check it later - because only if the interim commit
> id is in the stable tree, then also the new fix is a real candidate
> for backporting.
> 
> The above would become "(21.02 (partially fixed in c30751afc360 @ 21.08))"
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>   devtools/git-log-fixes.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> index 27ec9088d4..a1b548948a 100755
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> @@ -76,7 +76,7 @@ origin_version () # <origin_hash> ...
>   			# look chained fix of fix recursively
>   			local rootver="$(origin_version $roothashes)"
>   			[ -n "$rootver" ] || continue
> -			echo "$rootver (partially fixed in $origver)"
> +			echo "$rootver (partially fixed in $origin @ $origver)"
>   		else
>   			echo "$origver"
>   		fi
> 

Acked-by: Kevin Traynor <ktraynor@redhat.com>

Re: [PATCH v2 2/2] devtools: report commit id on partial fixes

[Xueming(Steven) Li]

On Fri, 2021-12-03 at 08:54 +0100, christian.ehrhardt@canonical.com
wrote:
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> The candidate list for backports lists partial fixes like:
>  "(21.02 (partially fixed in 21.08))"
> That is useful to identify fixes menat for later releases, but
> indirectly applying to older ones as well.
> 
> While the devscript has no access to the stable tree to fully check
> if the respective interim commit is present there, reporting the commit
> id will still help to check it later - because only if the interim commit
> id is in the stable tree, then also the new fix is a real candidate
> for backporting.
> 
> The above would become "(21.02 (partially fixed in c30751afc360 @ 21.08))"
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>  devtools/git-log-fixes.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> index 27ec9088d4..a1b548948a 100755
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> @@ -76,7 +76,7 @@ origin_version () # <origin_hash> ...
>  			# look chained fix of fix recursively
>  			local rootver="$(origin_version $roothashes)"
>  			[ -n "$rootver" ] || continue
> -			echo "$rootver (partially fixed in $origver)"
> +			echo "$rootver (partially fixed in $origin @ $origver)"
>  		else
>  			echo "$origver"
>  		fi

Acked-by: Xueming Li <xuemingl@nvidia.com>

Re: [PATCH v2 1/2] devtools: don't include headline "fix" in backports

[Xueming(Steven) Li]

On Fri, 2021-12-03 at 08:54 +0100, christian.ehrhardt@canonical.com
wrote:
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> It was important in the past to select anything with "fix" in the
> headline, but recently more often created false positives and work
> to sort tihngs out than identifying many helpful patches.
> 
> The community and processes aroudn DPDK matured enough that developers
> (rightfully) expect to rely on "Fixes:" and "stable@" marking for
> backprots.
> 
> Therefore do no more include patches that just include the word fix
> in the backport candidate list.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>  devtools/git-log-fixes.sh | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> index 210c8dcf25..27ec9088d4 100755
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> @@ -13,7 +13,7 @@ print_help ()
>  	cat <<- END_OF_HELP
>  
>  	Find fixes to backport on previous versions.
> -	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
> +	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.
>  	The oldest bug origin is printed as well as partially fixed versions.
>  	END_OF_HELP
>  }
> @@ -109,8 +109,7 @@ while read id headline ; do
>  	origins=$(origin_filter $id)
>  	stable=$(stable_tag $id)
>  	fixes=$(fixes_tag $id)
> -	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \
> -		echo "$headline" | grep -q fix || continue
> +	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue
>  	version=$(commit_version $id)
>  	if [ -n "$origins" ] ; then
>  		origver="$(origin_version $origins)"

Yes, most of them are faked ones, thanks for fixing this.

Acked-by: Xueming Li <xuemingl@nvidia.com>

Re: [PATCH v2 1/2] devtools: don't include headline "fix" in backports

[Thomas Monjalon]

03/12/2021 15:04, Kevin Traynor:
> On 03/12/2021 07:54, christian.ehrhardt@canonical.com wrote:
> > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > 
> > It was important in the past to select anything with "fix" in the
> > headline, but recently more often created false positives and work
> > to sort tihngs out than identifying many helpful patches.
> > 
> > The community and processes aroudn DPDK matured enough that developers
> > (rightfully) expect to rely on "Fixes:" and "stable@" marking for
> > backprots.
> 
> nit: several typos here and i think it should say "or" stable@
> 
> > 
> > Therefore do no more include patches that just include the word fix
> > in the backport candidate list.
> > 
> > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > ---
> >   devtools/git-log-fixes.sh | 5 ++---
> >   1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> > index 210c8dcf25..27ec9088d4 100755
> > --- a/devtools/git-log-fixes.sh
> > +++ b/devtools/git-log-fixes.sh
> > @@ -13,7 +13,7 @@ print_help ()
> >   	cat <<- END_OF_HELP
> >   
> >   	Find fixes to backport on previous versions.
> > -	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
> > +	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.
> 
> "..or for recipient stable@dpdk.org."
> 
> Good idea, thanks. With minor fixes,
> 
> Acked-by: Kevin Traynor <ktraynor@redhat.com>

After one year, nits above have not been fixed, so I'm doing it myself.

While at it, remove "Reverts" from help because not parsed in reality.

Series applied with above changes.