From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD913A0548; Fri, 3 Dec 2021 08:54:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC6D84014F; Fri, 3 Dec 2021 08:54:20 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 6B4C240041 for <dev@dpdk.org>; Fri, 3 Dec 2021 08:54:19 +0100 (CET) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 46F164003F for <dev@dpdk.org>; Fri, 3 Dec 2021 07:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638518059; bh=btuBD8y3q75nPLokDQATYRpJIXLPnVDO5JmvhyjWgns=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=o2MO3yXMgAQfQHB7m9bzkkRvd4Hw4HJYvc7YINNuVyLuCzbJmZSvzp298w9vVjnTN JB7Y9TwTwNMKXpbETasre/JUjmt64WDDnYX+S/LDbmRwXEPMd0z8F2jnvQnfFXZjr3 lYkPJlYpyDiRIkMrszk/+Aqc4Lfmrv97Ldg19oGImRx1D2KpSi/8n3NgHCI3wgRBph 93NT6tiDTVg15rD/igzJLLVL+w/FutjoZBYOM5ui5VVGZpY0vElMoAMbmsAmoRvcaN 7xea6I9yjSmd5lxPWr+SG726OCmRgWslfxHfmcXFCu9WsJfAEiDZ4ApzTn2ObT+1Vm wGVR4tviDVY3g== Received: by mail-ed1-f70.google.com with SMTP id b15-20020aa7c6cf000000b003e7cf0f73daso1791226eds.22 for <dev@dpdk.org>; Thu, 02 Dec 2021 23:54:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=btuBD8y3q75nPLokDQATYRpJIXLPnVDO5JmvhyjWgns=; b=UvvTLikSsdqWxX5nm8rJN/Cr4awGjuFDRYCAdwZb4oDqH996w7tqB1YHAHkzDFEvkv hn0yoB1TD5O4i7KJDEqHa27tsTHWa8/3LQSVbdhTOavstPeNQBny/C+/Pni+/rlUrv/p buoFtm6LqQ/ohY7v7xAfRlXor2OdxG97yad2GgTyO+PGG523tAQxv0K1FfEbdCouGbN7 8JA4ck3LyWJ8QbtBsmrqmCUem5owcgaXBIYt35VXtbliRrGZglF2RUhuzmMS+JKXl7SH M1+tLafv6sc53bXeBGIUD9CP1fe1wqgMYBAWCE4QLL3V0qc/wPJeiH9VSRUqWXfpxQ9N QEpQ== X-Gm-Message-State: AOAM531YG+/POXav6oEFYEAXaiZ3LNVDCS/JwHOcYe7qwKea00LHahJx TFjSX/FCou9dlg329T+olSTpS2oEGrMOwHu1FSaxta9FenB8wcWRrGw1EJQVjopz1kWZ1wk4tB3 lVMeMvqbQHrBURaLfHsxl X-Received: by 2002:a50:955c:: with SMTP id v28mr24937560eda.293.1638518058809; Thu, 02 Dec 2021 23:54:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPjHiplE5l77W/rplCZfh6txR3zoh+tMPtINAKHW6/vVSfiusEKjDikOTXeR2yqHSMsUtGjA== X-Received: by 2002:a50:955c:: with SMTP id v28mr24937528eda.293.1638518058592; Thu, 02 Dec 2021 23:54:18 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id gt18sm1430632ejc.46.2021.12.02.23.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Dec 2021 23:54:18 -0800 (PST) From: christian.ehrhardt@canonical.com To: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Luca Boccassi <bluca@debian.org>, Xueming Li <xuemingl@nvidia.com>, David Marchand <david.marchand@redhat.com>, Kevin Traynor <ktraynor@redhat.com>, Maxime Coquelin <maxime.coquelin@redhat.com> Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com> Subject: [PATCH v2 1/2] devtools: don't include headline "fix" in backports Date: Fri, 3 Dec 2021 08:54:14 +0100 Message-Id: <20211203075415.4083502-1-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org From: Christian Ehrhardt <christian.ehrhardt@canonical.com> It was important in the past to select anything with "fix" in the headline, but recently more often created false positives and work to sort tihngs out than identifying many helpful patches. The community and processes aroudn DPDK matured enough that developers (rightfully) expect to rely on "Fixes:" and "stable@" marking for backprots. Therefore do no more include patches that just include the word fix in the backport candidate list. Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> --- devtools/git-log-fixes.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh index 210c8dcf25..27ec9088d4 100755 --- a/devtools/git-log-fixes.sh +++ b/devtools/git-log-fixes.sh @@ -13,7 +13,7 @@ print_help () cat <<- END_OF_HELP Find fixes to backport on previous versions. - It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts". + It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org. The oldest bug origin is printed as well as partially fixed versions. END_OF_HELP } @@ -109,8 +109,7 @@ while read id headline ; do origins=$(origin_filter $id) stable=$(stable_tag $id) fixes=$(fixes_tag $id) - [ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \ - echo "$headline" | grep -q fix || continue + [ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue version=$(commit_version $id) if [ -n "$origins" ] ; then origver="$(origin_version $origins)" -- 2.34.0