DPDK patches and discussions
 help / color / mirror / Atom feed
From: christian.ehrhardt@canonical.com
To: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
	Luca Boccassi <bluca@debian.org>,
	Xueming Li <xuemingl@nvidia.com>,
	David Marchand <david.marchand@redhat.com>,
	Kevin Traynor <ktraynor@redhat.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: [PATCH v2 2/2] devtools: report commit id on partial fixes
Date: Fri,  3 Dec 2021 08:54:15 +0100	[thread overview]
Message-ID: <20211203075415.4083502-2-christian.ehrhardt@canonical.com> (raw)
In-Reply-To: <20211203075415.4083502-1-christian.ehrhardt@canonical.com>

From: Christian Ehrhardt <christian.ehrhardt@canonical.com>

The candidate list for backports lists partial fixes like:
 "(21.02 (partially fixed in 21.08))"
That is useful to identify fixes menat for later releases, but
indirectly applying to older ones as well.

While the devscript has no access to the stable tree to fully check
if the respective interim commit is present there, reporting the commit
id will still help to check it later - because only if the interim commit
id is in the stable tree, then also the new fix is a real candidate
for backporting.

The above would become "(21.02 (partially fixed in c30751afc360 @ 21.08))"

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 devtools/git-log-fixes.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
index 27ec9088d4..a1b548948a 100755
--- a/devtools/git-log-fixes.sh
+++ b/devtools/git-log-fixes.sh
@@ -76,7 +76,7 @@ origin_version () # <origin_hash> ...
 			# look chained fix of fix recursively
 			local rootver="$(origin_version $roothashes)"
 			[ -n "$rootver" ] || continue
-			echo "$rootver (partially fixed in $origver)"
+			echo "$rootver (partially fixed in $origin @ $origver)"
 		else
 			echo "$origver"
 		fi
-- 
2.34.0


  reply	other threads:[~2021-12-03  7:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03  7:54 [PATCH v2 1/2] devtools: don't include headline "fix" in backports christian.ehrhardt
2021-12-03  7:54 ` christian.ehrhardt [this message]
2021-12-03 12:24   ` [PATCH v2 2/2] devtools: report commit id on partial fixes Luca Boccassi
2021-12-03 14:05   ` Kevin Traynor
2021-12-05 11:35   ` Xueming(Steven) Li
2021-12-03 12:24 ` [PATCH v2 1/2] devtools: don't include headline "fix" in backports Luca Boccassi
2021-12-03 14:04 ` Kevin Traynor
2022-11-26 21:35   ` Thomas Monjalon
2021-12-05 11:38 ` Xueming(Steven) Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211203075415.4083502-2-christian.ehrhardt@canonical.com \
    --to=christian.ehrhardt@canonical.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=thomas@monjalon.net \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).