From: Stephen Douthit <stephend@silicom-usa.com>
To: dev@dpdk.org
Cc: wenw@silicom-usa.com, Stephen Douthit <stephend@silicom-usa.com>,
Haiyue Wang <haiyue.wang@intel.com>
Subject: [PATCH 7/7] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices
Date: Fri, 3 Dec 2021 17:55:16 -0500 [thread overview]
Message-ID: <20211203225516.571368-8-stephend@silicom-usa.com> (raw)
In-Reply-To: <20211203225516.571368-1-stephend@silicom-usa.com>
1G Cu SFPs are not officially supported on the X552/X553 family of devices
but treat them as 1G SX modules since they usually work. Print a warning
though since support isn't validated, similar to what already happens for
other unofficially supported SFPs enabled via the allow_unsupported_sfps
parameter inherited from the mainline Linux driver.
Signed-off-by: Stephen Douthit <stephend@silicom-usa.com>
---
drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c
index 8810d1658e..8d1bc6c80d 100644
--- a/drivers/net/ixgbe/base/ixgbe_x550.c
+++ b/drivers/net/ixgbe/base/ixgbe_x550.c
@@ -1538,9 +1538,21 @@ STATIC s32 ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool *linear)
case ixgbe_sfp_type_1g_lha_core1:
*linear = false;
break;
- case ixgbe_sfp_type_unknown:
+ /* Copper SFPs are not officially supported for x550em devices, but can
+ * often be made to work at fixed 1G speeds. Pretend they're 1g_sx
+ * modules here to allow g.Fast DSL SFPs to work.
+ */
case ixgbe_sfp_type_1g_cu_core0:
+ EWARN(hw, "Pretending that unsupported 1g_cu SFP is 1g_sx\n");
+ *linear = false;
+ hw->phy.sfp_type = ixgbe_sfp_type_1g_sx_core0;
+ break;
case ixgbe_sfp_type_1g_cu_core1:
+ EWARN(hw, "Pretending that unsupported 1g_cu SFP is 1g_sx\n");
+ *linear = false;
+ hw->phy.sfp_type = ixgbe_sfp_type_1g_sx_core1;
+ break;
+ case ixgbe_sfp_type_unknown:
default:
return IXGBE_ERR_SFP_NOT_SUPPORTED;
}
--
2.31.1
next prev parent reply other threads:[~2021-12-03 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 22:55 [PATCH 0/7] ixgbe SFP handling fixes Stephen Douthit
2021-12-03 22:55 ` [PATCH 1/7] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs Stephen Douthit
2021-12-03 22:55 ` [PATCH 2/7] net/ixgbe: Add ixgbe_check_sfp_cage() for testing state of PRSNT# signal Stephen Douthit
2021-12-03 22:55 ` [PATCH 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write Stephen Douthit
2021-12-03 22:55 ` [PATCH 4/7] net/ixgbe: Run 82599 link status workaround only on affected devices Stephen Douthit
2021-12-03 22:55 ` [PATCH 5/7] net/ixgbe: Fix SFP detection and linking on hotplug Stephen Douthit
2021-12-03 22:55 ` [PATCH 6/7] net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs Stephen Douthit
2021-12-03 22:55 ` Stephen Douthit [this message]
[not found] <20211203224706.569618-1-stephend@silicom-usa.com>
2021-12-03 22:47 ` [PATCH 7/7] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Stephen Douthit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203225516.571368-8-stephend@silicom-usa.com \
--to=stephend@silicom-usa.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=wenw@silicom-usa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).