From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28594A00C2; Sat, 11 Dec 2021 22:49:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6F0740A4B; Sat, 11 Dec 2021 22:49:22 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 36A8240698 for ; Sat, 11 Dec 2021 22:49:21 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id gt5so9267548pjb.1 for ; Sat, 11 Dec 2021 13:49:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UVma7ajZKeKi8ivd7N6It8XjUvqZVaYX8olbAQzld3s=; b=p5lggiROGiDYiqY8ZeUMNqNpJzByc7wYrxyvfHxdUV8t3rNx4Qwa0cOutIQwLlwZOo lO/KDv6jaJW65rKhJPS8YkZvlkx0Xci79vTfGJ/x/t7nK/8fQKOj6EoOfFvn43U8pxBx fAMbZEqhFFBKyZQqZuwcjezc4xu1+CLyBshu9k7iLLcxTLqTcDiwF5cKRUMul3tJK2kL dDeSiTl84Q5rNk5WCNNlQJoc8mKN06OJ5CmqGiFqf9YpQBnHkiAaQ+bleDJ/jY4ky9Aa ceLtdZzzAHaiJerKkjYHOzzvemosJHSo/Gb9affuF3Iq+Z30SDqQmHHGVLJg4d4UJF8+ jjYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UVma7ajZKeKi8ivd7N6It8XjUvqZVaYX8olbAQzld3s=; b=uwTgM+UWSZkep4mFbZRG1lyFIp1W060NrdLIPQGfEVYkUXLj3IL9uSRdh6crkfm1h1 fD5gsWyBzFnTQ2WKk4xc9z/GG2Qe25ZRObaAMi3vQrQ72dxQxoCemXyQgvF9N6wnbOw5 62/1sKhv3Z7wYCTLgXXRXkCXAN9dedV/+gMpPk33ABvnBGebrQsCGycQetBX0z08kThw 61ApzKSYnGunsnTylWe1s1xJ4pWHwhTohPyiBUAvRr7wDzZcrwxmVXy6fcXi7tDhIIlr Cvck8/bYIqrT8WlU0hAGkT+o60TgF3QjY1vWMffD830+Z+B/SpMYp3b4jTkH8wXEX3qU mBTg== X-Gm-Message-State: AOAM5328B5GU/fZqKfh6ekjNDzVOiZEuEWr04hB82FQwbMOfXOM65kUL duocoVcfhn+zLtdZd65hrbKHwRn++lul4A== X-Google-Smtp-Source: ABdhPJzy2K2vBNxc98QKwy/fq+5i0cQyMMfGTdbCjJhLSCApIKebRv7WOdM4syIutkG2xZLxxPvijQ== X-Received: by 2002:a17:90a:6886:: with SMTP id a6mr33488226pjd.78.1639259360080; Sat, 11 Dec 2021 13:49:20 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id 38sm5830890pgl.73.2021.12.11.13.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Dec 2021 13:49:19 -0800 (PST) Date: Sat, 11 Dec 2021 13:49:17 -0800 From: Stephen Hemminger To: Ciara Loftus Cc: dev@dpdk.org Subject: Re: [RFC PATCH] net/af_xdp: reenable secondary process support Message-ID: <20211211134917.20b380d1@hermes.local> In-Reply-To: <20211210153245.9505-1-ciara.loftus@intel.com> References: <20211210153245.9505-1-ciara.loftus@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 10 Dec 2021 15:32:45 +0000 Ciara Loftus wrote: > Secondary process support had been disabled for the AF_XDP PMD > because there was no logic in place to share the AF_XDP socket > file descriptors between the processes. This commit introduces > this logic using the IPC APIs. > > Since AF_XDP rings are single-producer single-consumer, rx/tx > in the secondary process is disabled. However other operations > including retrieval of stats are permitted. > > Signed-off-by: Ciara Loftus > --- > doc/guides/nics/af_xdp.rst | 9 ++ > doc/guides/nics/features/af_xdp.ini | 1 + > doc/guides/rel_notes/release_22_03.rst | 4 + > drivers/net/af_xdp/rte_eth_af_xdp.c | 210 +++++++++++++++++++++++-- > 4 files changed, 210 insertions(+), 14 deletions(-) Could also fix (and change your editor settings) the missing newline at the end of files in XDP. Specifically: drivers/net/af_xdp/meson.build doc/guides/nics/af_xdp.rst Overall in DPDK: $ find app *tools config doc drivers examples lib -type f | xargs pcregrep -LMr '\n\Z' | grep -v '.svg$' | grep -v '.png$' | grep -v '.data$' | grep -v '.pyc$' app/test/test_cfgfiles/etc/empty.ini doc/guides/cryptodevs/features/null.ini doc/guides/cryptodevs/features/ccp.ini doc/guides/cryptodevs/features/qat.ini doc/guides/cryptodevs/features/caam_jr.ini doc/guides/cryptodevs/features/cn9k.ini doc/guides/cryptodevs/features/bcmfs.ini doc/guides/cryptodevs/features/cn10k.ini doc/guides/cryptodevs/features/aesni_mb.ini doc/guides/cryptodevs/features/armv8.ini doc/guides/nics/af_xdp.rst drivers/net/af_xdp/meson.build examples/flow_classify/ipv4_rules_file.txt