From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-kmods] linux/igb_uio: fix build for switch fall through
Date: Wed, 15 Dec 2021 11:20:17 -0800 [thread overview]
Message-ID: <20211215112017.26958d79@hermes.local> (raw)
In-Reply-To: <20211215184859.1859870-1-ferruh.yigit@intel.com>
On Wed, 15 Dec 2021 18:48:59 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't
> take any fall through comments into account but only uses compiler
> 'fallthrough' attribute to document fall through action is intended.
>
> "falls through" comment was used in the code which is causing a build
> error now, this patch converts comment to the 'fallthrough' macro
> defined in the Linux.
>
> To cover the case where Linux version doesn't have the macro, defined it
> in the compatibility header too.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Are you sure that fixes it? because the comment in the macro is typically
not visible in a macro expansion.
Since in most case Linux uses gcc why not use the gcc attribute
__attribute__ ((fallthrough))
next prev parent reply other threads:[~2021-12-15 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 18:48 Ferruh Yigit
2021-12-15 19:20 ` Stephen Hemminger [this message]
2021-12-15 21:04 ` Ferruh Yigit
2021-12-15 23:15 ` Stephen Hemminger
2021-12-16 9:37 ` Ferruh Yigit
2021-12-16 12:03 ` [dpdk-kmods v2] " Ferruh Yigit
2022-01-11 14:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215112017.26958d79@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).