From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22ED2A034F; Fri, 24 Dec 2021 18:45:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A15444067B; Fri, 24 Dec 2021 18:45:02 +0100 (CET) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id 586D24013F for ; Fri, 24 Dec 2021 18:45:01 +0100 (CET) Received: by mail-pg1-f180.google.com with SMTP id s1so6619393pga.5 for ; Fri, 24 Dec 2021 09:45:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i6kPpsPSmHcBBLjPUfpG9CvuCk+w7WyLHNolaUm9SXM=; b=L+pCBLjL3z0urxwxonRdBgRAP8ZNxvwnpT8TNvlQ7yQcjQECHcZzWkYLBR9DwHtMzn TnFX3OSayw5ccAx/1G8eDiV9mZ5n8V0Gkv87XHJY/i4kvSfSGqYyDdKEGsShrhk96eO5 DoLouAy+wRdpv1YTOmy0IL08Ljy9Z+x9GD/J/oucEXA1v56hewJsdZ/zSCfSsI0GKWkE DWW5ew0YrroByATTuYf3aqQK5Q+glNnHUXDaBGD2REQgMWQujwQcYjaomAl9Ci5lR0C5 HTNPfXpxSM82Wm7y4a5RyD6nugzAV0iAHYHEYHdAODTCDI26bwLug8wPWwgXzfOBvvkM X3Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i6kPpsPSmHcBBLjPUfpG9CvuCk+w7WyLHNolaUm9SXM=; b=JC33kSXOObblcREMWJ8cfl0s0xVdi7oooyhSth0mFSschXySvtd1wDEWSQunL5oZmO +puj3e3iR8MCW611qMPQHSnjPs0LJkb9MuKTZ33Ztn8pUNXd/XorN2AWecpUncWeU5qo ZUMk+NwD30M8J1J2gzeA8v3H97gi5EmOWed9BDOdFyW7gN43aTUi9tIxUnl/kEwhALEy EfnKgtDRjx6qvaRiGqqQ875ld8Birv5bjewtcpB1EzMH47IGR6bLGM40/cMPZG2Z2bLg yRAt5Zm8eWK3UXXedZxLXGorvDPpwNdNfQkqZlvMmOvUsD14UFPPLzRhnogpvBNDXppB KsGg== X-Gm-Message-State: AOAM531l9Vb/p25jVLpNJmuG7oEvT1AUOI4qKTRoiwDc3sN5ubVDLgXG vtT3NcvkiepPZSDACV7XA2NLvlHj4Mrl0HPY X-Google-Smtp-Source: ABdhPJw0LBhNqHNRTovLn7bEzaW2CyP44Q1MIvP99kbWoFAEpkfvhPTYRds5OnqAzK0qtT+wgmiQ0Q== X-Received: by 2002:a63:4712:: with SMTP id u18mr6880894pga.330.1640367900372; Fri, 24 Dec 2021 09:45:00 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id p13sm1725261pgl.23.2021.12.24.09.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Dec 2021 09:45:00 -0800 (PST) Date: Fri, 24 Dec 2021 09:44:57 -0800 From: Stephen Hemminger To: Yanling Song Cc: , , , , Subject: Re: [PATCH v3 00/25] Net/SPNIC: support SPNIC into DPDK 22.03 Message-ID: <20211224094457.051f3c17@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 24 Dec 2021 16:32:18 +0800 Yanling Song wrote: > The patchsets introduce SPNIC driver for Ramaxel's SPNxx serial NIC cards into DPDK 22.03. > Ramaxel Memory Technology is a company which supply a lot of electric products: > storage, communication, PCB... > SPNxxx is a serial PCIE interface NIC cards: > SPN110: 2 PORTs *25G > SPN120: 4 PORTs *25G > SPN130: 2 PORTs *100G > > The following is main features of our SPNIC: > - TSO > - LRO > - Flow control > - SR-IOV(Partially supported) > - VLAN offload > - VLAN filter > - CRC offload > - Promiscuous mode > - RSS > > v2->v3: > 1. Fix clang compiling failure. > > v1->v2: > 1. Fix coding style issues and compiling failures; > 2. Only support linux in meson.build; > 3. Use CLOCK_MONOTONIC_COARSE instead of CLOCK_MONOTONIC/CLOCK_MONOTONIC_RAW; > 4. Fix time_before(); > 5. Remove redundant checks in spnic_dev_configure(); Overall looks good. Please use a consistent prefix to all globally visible symbols to avoid any possible name clashes when statically linking. $ nm ./build/drivers/librte_net_spnic.a | grep ' t ' | grep -v spnic_ | grep -v rte_ 00000000000006f0 t remove_aeq 0000000000000040 t fault_event_handler 0000000000000060 t ffm_event_msg_handler 00000000000016c0 t alloc_mbox_info 0000000000000ca0 t send_mbox_to_func 0000000000000890 t send_tlp_mbox_to_func 00000000000000c0 t pciinitfn_net_spnic 0000000000000890 t clean_queue_offload_ctxt