From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0401A04A9; Mon, 27 Dec 2021 18:49:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E8B940683; Mon, 27 Dec 2021 18:49:20 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id EC56F4067B for ; Mon, 27 Dec 2021 18:49:19 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id x15so11857611plg.1 for ; Mon, 27 Dec 2021 09:49:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m/Uo8zlQOBhoq8oyltUOrQYILx2f8kXqE60a6y/Yiac=; b=ts6qZgbvB+hLeYco5X+42M+t9YtrOTBaWPyPyv8zxk8EyDi5xZe3D7XHzHGfsc2pTI 2+MLWcAiMYQwB7YPhNbmez9/ei+SIfD1rHZw+0VnGqXK/4vz7ntopdFYKZmgox50JLCf X0WJ3Rz+C+DS0DNwdlgACcMySCY+3PziL1QF4yN0EsbazVP80Vj3DOIQFpAqjkPSBze3 GXsonkLOxW+l80svBZFA/Qp5abdXg0bPZYS/KWX6k9/2GRqnVD+NJEz70js+JOqZRRe4 MIn/kld6rwPyuyHOBpb5jaXF3vAhY+JuedQnePvmJsjiKkIFWHSPOkigQZpY2gu3PhYx TnsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m/Uo8zlQOBhoq8oyltUOrQYILx2f8kXqE60a6y/Yiac=; b=6X6KZSOpB+hrJOv81iZi4Wef6IgjXPgubr1JRbJy85JA5YqvwF6rbMvfR4xxcuw/sc 2BQjH2FImj0Rbwct8y/X7JRw7hrEKvGNF1Zie7c+T+PmVl9xQzKTLr2Htsl/cBBlFSNy 8EgA4R+GGmtO82eVmz6rWGX5WScNqPBW14sTfDxqVfEFzA61INGRdpSzrG0UuP1ntael v30CQqlmng443ROC4uivQVaC5mpF/0YjjoHz8AoL9pFj+Vgjl7t+TCn6QBEnSh7hN7f0 i/J6cMkkqoKESYEW65h65EqSrcVCgo4DcklP6fzHTfeXOVjUMp/f88rl08U5jNKuVbMn WimQ== X-Gm-Message-State: AOAM533UxHOlUCQAm258V0fsbTGUwHv+YAJXk6SIz2xdzwa8rpFqNaZF dVNphcbHDVNZM+BThk+Zmgz1DA== X-Google-Smtp-Source: ABdhPJwulXTSCY2SxfF1FBh5O0nmvfbnERz8M25kaWcdby+ZOuNMvZU0VF4zK/I0mzZU2DG78cZsEw== X-Received: by 2002:a17:90b:4a84:: with SMTP id lp4mr22409865pjb.150.1640627358926; Mon, 27 Dec 2021 09:49:18 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id y11sm18829270pfi.80.2021.12.27.09.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Dec 2021 09:49:18 -0800 (PST) Date: Mon, 27 Dec 2021 09:49:16 -0800 From: Stephen Hemminger To: nipun.gupta@nxp.com Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com, hemant.agrawal@nxp.com, Gagandeep Singh Subject: Re: [PATCH v2 14/16] net/pfe: disable HW CRC stripping Message-ID: <20211227094916.6aa2218c@hermes.local> In-Reply-To: <20211227161645.24359-15-nipun.gupta@nxp.com> References: <20211206121824.3493-1-nipun.gupta@nxp.com> <20211227161645.24359-1-nipun.gupta@nxp.com> <20211227161645.24359-15-nipun.gupta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 27 Dec 2021 21:46:43 +0530 nipun.gupta@nxp.com wrote: > @@ -422,8 +422,11 @@ pfe_eth_close(struct rte_eth_dev *dev) > } > > static int > -pfe_eth_configure(struct rte_eth_dev *dev __rte_unused) > +pfe_eth_configure(struct rte_eth_dev *dev) > { > + if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC) > + PFE_PMD_ERR("PMD does not support KEEP_CRC offload"); > + > return 0; > } > Why is this necessary? There is already a check for offload capabilities in rte_eth_dev_configure(). The device should report correct supported offloads instead.