From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E15A4A034F; Tue, 28 Dec 2021 08:01:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F85840040; Tue, 28 Dec 2021 08:01:32 +0100 (CET) Received: from VLXDG1SPAM1.ramaxel.com (email.ramaxel.com [221.4.138.186]) by mails.dpdk.org (Postfix) with ESMTP id 93AEF4003C for ; Tue, 28 Dec 2021 08:01:31 +0100 (CET) Received: from V12DG1MBS01.ramaxel.local (v12dg1mbs01.ramaxel.local [172.26.18.31]) by VLXDG1SPAM1.ramaxel.com with ESMTPS id 1BS71Mnq090425 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 Dec 2021 15:01:22 +0800 (GMT-8) (envelope-from songyl@ramaxel.com) Received: from localhost (172.20.2.155) by V12DG1MBS01.ramaxel.local (172.26.18.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 28 Dec 2021 15:01:21 +0800 Date: Tue, 28 Dec 2021 15:01:20 +0800 From: Yanling Song To: Stephen Hemminger CC: , , , , Subject: Re: [PATCH v3 00/25] Net/SPNIC: support SPNIC into DPDK 22.03 Message-ID: <20211228150120.000013cf@ramaxel.com> In-Reply-To: <20211224094457.051f3c17@hermes.local> References: <20211224094457.051f3c17@hermes.local> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.2.155] X-ClientProxiedBy: V12DG1MBS03.ramaxel.local (172.26.18.33) To V12DG1MBS01.ramaxel.local (172.26.18.31) X-DNSRBL: X-MAIL: VLXDG1SPAM1.ramaxel.com 1BS71Mnq090425 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 24 Dec 2021 09:44:57 -0800 Stephen Hemminger wrote: > On Fri, 24 Dec 2021 16:32:18 +0800 > Yanling Song wrote: > > > The patchsets introduce SPNIC driver for Ramaxel's SPNxx serial NIC > > cards into DPDK 22.03. Ramaxel Memory Technology is a company which > > supply a lot of electric products: storage, communication, PCB... > > SPNxxx is a serial PCIE interface NIC cards: > > SPN110: 2 PORTs *25G > > SPN120: 4 PORTs *25G > > SPN130: 2 PORTs *100G > > > > The following is main features of our SPNIC: > > - TSO > > - LRO > > - Flow control > > - SR-IOV(Partially supported) > > - VLAN offload > > - VLAN filter > > - CRC offload > > - Promiscuous mode > > - RSS > > > > v2->v3: > > 1. Fix clang compiling failure. > > > > v1->v2: > > 1. Fix coding style issues and compiling failures; > > 2. Only support linux in meson.build; > > 3. Use CLOCK_MONOTONIC_COARSE instead of > > CLOCK_MONOTONIC/CLOCK_MONOTONIC_RAW; 4. Fix time_before(); > > 5. Remove redundant checks in spnic_dev_configure(); > > Overall looks good. > > Please use a consistent prefix to all globally visible symbols to > avoid any possible name clashes when statically linking. > > $ nm ./build/drivers/librte_net_spnic.a | grep ' t ' | grep -v > spnic_ | grep -v rte_ 00000000000006f0 t remove_aeq > 0000000000000040 t fault_event_handler > 0000000000000060 t ffm_event_msg_handler > 00000000000016c0 t alloc_mbox_info > 0000000000000ca0 t send_mbox_to_func > 0000000000000890 t send_tlp_mbox_to_func > 00000000000000c0 t pciinitfn_net_spnic > 0000000000000890 t clean_queue_offload_ctxt > > Good point. There are some external functions which have no spnic_ prefix. and there are also some static functions which have no spnic_ prefix. Since static functions only works in the file, it doesn't matter to add prefix or not. My plan is to add spnic_ prefix to those external functions. Is it ok to you?