From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5478BA034D;
	Wed, 29 Dec 2021 11:26:20 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E4F8E40151;
	Wed, 29 Dec 2021 11:26:19 +0100 (CET)
Received: from VLXDG1SPAM1.ramaxel.com (email.unionmem.com [221.4.138.186])
 by mails.dpdk.org (Postfix) with ESMTP id CA05B40040
 for <dev@dpdk.org>; Wed, 29 Dec 2021 11:26:18 +0100 (CET)
Received: from V12DG1MBS01.ramaxel.local (v12dg1mbs01.ramaxel.local
 [172.26.18.31])
 by VLXDG1SPAM1.ramaxel.com with ESMTPS id 1BTAQCiQ011898
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Wed, 29 Dec 2021 18:26:12 +0800 (GMT-8)
 (envelope-from songyl@ramaxel.com)
Received: from localhost (172.20.2.155) by V12DG1MBS01.ramaxel.local
 (172.26.18.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 29
 Dec 2021 18:26:11 +0800
Date: Wed, 29 Dec 2021 18:26:09 +0800
From: Yanling Song <songyl@ramaxel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
CC: <dev@dpdk.org>, <yanling.song@linux.dev>, <yanggan@ramaxel.com>,
 <xuyun@ramaxel.com>, <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 05/25] net/spnic: add mgmt module
Message-ID: <20211229182609.000052a9@ramaxel.com>
In-Reply-To: <20211228075918.78fd82a9@hermes.local>
References: <cover.1640332922.git.songyl@ramaxel.com>
 <e3a90b37c081cd85d39db84c76df2ad41c8480ea.1640332922.git.songyl@ramaxel.com>
 <20211228075918.78fd82a9@hermes.local>
X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.20.2.155]
X-ClientProxiedBy: V12DG1MBS03.ramaxel.local (172.26.18.33) To
 V12DG1MBS01.ramaxel.local (172.26.18.31)
X-DNSRBL: 
X-MAIL: VLXDG1SPAM1.ramaxel.com 1BTAQCiQ011898
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, 28 Dec 2021 07:59:18 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:

> On Fri, 24 Dec 2021 16:32:23 +0800
> Yanling Song <songyl@ramaxel.com> wrote:
> 
> > +static void nic_event_handler(void *hwdev  
> 
> This is one example of something this driver does a lot.
> It casts away the hardware device structure to void * then reassigns
> it to the the hardware structure.  This is the classic type unsafe C
> style code. If possible keep the type information.

Ok. The change will be included in V5 since V4 was pushed already.