From: Stephen Hemminger <stephen@networkplumber.org>
To: <eagostini@nvidia.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v1 3/3] gpu/cuda: mem alloc aligned memory
Date: Mon, 3 Jan 2022 10:05:20 -0800 [thread overview]
Message-ID: <20220103100520.66677c3f@hermes.local> (raw)
In-Reply-To: <20220104014721.1799-4-eagostini@nvidia.com>
On Tue, 4 Jan 2022 01:47:21 +0000
<eagostini@nvidia.com> wrote:
> static int
> -cuda_mem_alloc(struct rte_gpu *dev, size_t size, void **ptr)
> +cuda_mem_alloc(struct rte_gpu *dev, size_t size, void **ptr, unsigned int align)
> {
> CUresult res;
> const char *err_string;
> @@ -610,8 +612,10 @@ cuda_mem_alloc(struct rte_gpu *dev, size_t size, void **ptr)
>
> /* Allocate memory */
> mem_alloc_list_tail->size = size;
> - res = pfn_cuMemAlloc(&(mem_alloc_list_tail->ptr_d),
> - mem_alloc_list_tail->size);
> + mem_alloc_list_tail->size_orig = size + align;
> +
> + res = pfn_cuMemAlloc(&(mem_alloc_list_tail->ptr_orig_d),
> + mem_alloc_list_tail->size_orig);
> if (res != 0) {
> pfn_cuGetErrorString(res, &(err_string));
> rte_cuda_log(ERR, "cuCtxSetCurrent current failed with %s",
> @@ -620,6 +624,13 @@ cuda_mem_alloc(struct rte_gpu *dev, size_t size, void **ptr)
> return -rte_errno;
> }
>
> +
> + /* Align memory address */
> + mem_alloc_list_tail->ptr_d = mem_alloc_list_tail->ptr_orig_d;
> + if (align && ((uintptr_t)mem_alloc_list_tail->ptr_d) % align)
> + mem_alloc_list_tail->ptr_d += (align -
> + (((uintptr_t)mem_alloc_list_tail->ptr_d) % align));
Posix memalign takes size_t for both size and alignment.
Better to put the input parameters first, and then the resulting output parameter last
for consistency; follows the Rusty API design manifesto.
Alignment only makes sense if power of two. The code should check that and optimize
for that.
next prev parent reply other threads:[~2022-01-03 18:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 1:47 [PATCH v1 0/3] GPU memory aligned eagostini
2022-01-04 1:47 ` [PATCH v1 1/3] gpudev: mem alloc aligned memory eagostini
2022-01-04 1:47 ` [PATCH v1 2/3] app/test-gpudev: test aligned memory allocation eagostini
2022-01-04 1:47 ` [PATCH v1 3/3] gpu/cuda: mem alloc aligned memory eagostini
2022-01-03 18:05 ` Stephen Hemminger [this message]
2022-01-03 18:15 ` Elena Agostini
2022-01-03 18:17 ` Stephen Hemminger
2022-01-03 18:22 ` Elena Agostini
2022-01-08 0:20 ` [PATCH v2 1/3] gpudev: " eagostini
2022-01-08 0:20 ` [PATCH v2 2/3] app/test-gpudev: test aligned memory allocation eagostini
2022-01-08 0:20 ` [PATCH v2 3/3] gpu/cuda: mem alloc aligned memory eagostini
2022-01-21 10:34 ` [PATCH v2 1/3] gpudev: " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103100520.66677c3f@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).