From: Stephen Hemminger <stephen@networkplumber.org>
To: Elena Agostini <eagostini@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v1 3/3] gpu/cuda: mem alloc aligned memory
Date: Mon, 3 Jan 2022 10:17:41 -0800 [thread overview]
Message-ID: <20220103101741.711319ab@hermes.local> (raw)
In-Reply-To: <DM6PR12MB4107C9CA5C45F4614BB71980CD499@DM6PR12MB4107.namprd12.prod.outlook.com>
On Mon, 3 Jan 2022 18:15:11 +0000
Elena Agostini <eagostini@nvidia.com> wrote:
> > Alignment only makes sense if power of two. The code should check that and optimize
> > for that.
> >
>
> The alignment value is checked in the gpudev library before
> passing it to the driver.
>
> Adding this kind of checks in the driver has been rejected in the past because it was
> considered dead code (the library was already checking input parameters).
>
> Let me know what are the preferred options.
Driver could use the mask instead of slow divide operation.
next prev parent reply other threads:[~2022-01-03 18:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 1:47 [PATCH v1 0/3] GPU memory aligned eagostini
2022-01-04 1:47 ` [PATCH v1 1/3] gpudev: mem alloc aligned memory eagostini
2022-01-04 1:47 ` [PATCH v1 2/3] app/test-gpudev: test aligned memory allocation eagostini
2022-01-04 1:47 ` [PATCH v1 3/3] gpu/cuda: mem alloc aligned memory eagostini
2022-01-03 18:05 ` Stephen Hemminger
2022-01-03 18:15 ` Elena Agostini
2022-01-03 18:17 ` Stephen Hemminger [this message]
2022-01-03 18:22 ` Elena Agostini
2022-01-08 0:20 ` [PATCH v2 1/3] gpudev: " eagostini
2022-01-08 0:20 ` [PATCH v2 2/3] app/test-gpudev: test aligned memory allocation eagostini
2022-01-08 0:20 ` [PATCH v2 3/3] gpu/cuda: mem alloc aligned memory eagostini
2022-01-21 10:34 ` [PATCH v2 1/3] gpudev: " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103101741.711319ab@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).