From: Maxime Gouin <maxime.gouin@6wind.com>
To: dev@dpdk.org
Cc: Maxime Gouin <maxime.gouin@6wind.com>,
Rosen Xu <rosen.xu@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
Tianfei Zhang <tianfei.zhang@intel.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: [PATCH] bus/ifpga: remove useless check while browsing devices
Date: Wed, 5 Jan 2022 11:26:52 +0100 [thread overview]
Message-ID: <20220105102652.6400-1-maxime.gouin@6wind.com> (raw)
reported by code analysis tool C++test (version 10.4):
> /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
> 67 Condition "afu_dev" is always evaluated to true
> 81 Condition "afu_dev" is always evaluated to true
The "for" loop already checks that afu_dev is not NULL.
Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
---
drivers/bus/ifpga/ifpga_bus.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index cbc680928486..c5c8bbd57219 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -64,8 +64,7 @@ ifpga_find_afu_dev(const struct rte_rawdev *rdev,
struct rte_afu_device *afu_dev = NULL;
TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
- if (afu_dev &&
- afu_dev->rawdev == rdev &&
+ if (afu_dev->rawdev == rdev &&
!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
return afu_dev;
}
@@ -78,8 +77,7 @@ rte_ifpga_find_afu_by_name(const char *name)
struct rte_afu_device *afu_dev = NULL;
TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
- if (afu_dev &&
- !strcmp(afu_dev->device.name, name))
+ if (!strcmp(afu_dev->device.name, name))
return afu_dev;
}
return NULL;
--
2.30.2
next reply other threads:[~2022-01-06 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 10:26 Maxime Gouin [this message]
2022-01-11 15:12 ` Kevin Traynor
2022-01-13 14:19 ` Xu, Rosen
2022-01-19 16:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105102652.6400-1-maxime.gouin@6wind.com \
--to=maxime.gouin@6wind.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=qi.z.zhang@intel.com \
--cc=rosen.xu@intel.com \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).