From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2833EA00C3; Fri, 14 Jan 2022 17:24:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CB9241160; Fri, 14 Jan 2022 17:24:20 +0100 (CET) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id 3F12B4115A for ; Fri, 14 Jan 2022 17:24:19 +0100 (CET) Received: by mail-pg1-f182.google.com with SMTP id c5so3151094pgk.12 for ; Fri, 14 Jan 2022 08:24:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QSfE5UOTWRfCNMEzDFqPy9Fg8XOh63SpcrrOppLQIqE=; b=15xnGXfcLcMWvfqYzFxHDPZtEC3w0KYQMYuevY7oXW3tLoO5Rjp/OXtNT2OecfeG/Y owG+7QfAYQznMK1Fw5USSxc9IsU3mq/uXOOZDGvVP5779ZgzmuPtzUn8dEoWeHNzvqLk NW6a6sdNYYro7rUE7KFm0XD7d+Dahaezp52IwcqNGlYA6V3GV+vUbooMG3/bn81o9mD9 WUWFbTKuT+1IZ0Kg1Xb95pgQohQ9gxnY03dAkXtJ8Lr0LrM1iL2g7WxWSskFfrNWl/pD nRTm523MfmgFjlWJTMnjO6cI7fSa7DM3zY8VMO6qWIDtEDzY/aKNgPL93gDfd9UtzRrj shgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QSfE5UOTWRfCNMEzDFqPy9Fg8XOh63SpcrrOppLQIqE=; b=ydUi861zW8yp9YuaSrOkeM64kPcxtVxvRuftZ2wIzioJC2bvy04gKMc0/TLaav/FKe bzmjJZBKCOiiNIVOdWVaedyf656mKsZjM+WrO+YyeNcfGhnXNTC0NUFsuNe7ccyXDruZ MOC6at9hXkXjGnSk5T2MuTPi1JyZe7J0LLwro6vGaeddlf+GCWzo7UodMVazgWUpD7mr w3wYo0uxs5MeuRx3QTTAhiezVtvQF6Vis5jEEgucsvSlbfY167ynra81upXoFS+g8SU7 t9SAkwVTu31Cr43ce/yKD7CvRT1gxOOPlTRJbE/fZCEQKvhHbEvxmMwXAcsKCP9WxcTB 5BUQ== X-Gm-Message-State: AOAM531wYQPQlXPwsFIs3FQs8zkMUlJ6M7XrhXvBhkgtbn4wv1dRbdcH wtRUEUG7lVO8lzC4jGwUNyEaTg== X-Google-Smtp-Source: ABdhPJy3kaQBmoIdesV4KV2RwrxYos8R4ufyZISxSt4fUT6EuzCbT18SAJgfJWGNc2gWUUYHUQPdHg== X-Received: by 2002:a63:be45:: with SMTP id g5mr8699582pgo.309.1642177458442; Fri, 14 Jan 2022 08:24:18 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id 6sm5022855pgr.88.2022.01.14.08.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jan 2022 08:24:18 -0800 (PST) Date: Fri, 14 Jan 2022 08:24:15 -0800 From: Stephen Hemminger To: Tudor Cornea Cc: ferruh.yigit@intel.com, padraig.j.connolly@intel.com, thomas@monjalon.net, helin.zhang@intel.com, dev@dpdk.org Subject: Re: [PATCH v5] kni: allow configuring the kni thread granularity Message-ID: <20220114082415.69752802@hermes.local> In-Reply-To: <1642173499-59396-1-git-send-email-tudor.cornea@gmail.com> References: <1637781854-74761-1-git-send-email-tudor.cornea@gmail.com> <1642173499-59396-1-git-send-email-tudor.cornea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 14 Jan 2022 17:18:19 +0200 Tudor Cornea wrote: > +module_param(min_scheduling_interval, long, 0644); > +MODULE_PARM_DESC(min_scheduling_interval, > +"\t\tKni thread min scheduling interval (default=100 microseconds):\n" > +"\t\t" > +); > + > +module_param(max_scheduling_interval, long, 0644); > +MODULE_PARM_DESC(max_scheduling_interval, > +"\t\tKni thread max scheduling interval (default=200 microseconds):\n" > +"\t\t" > +); Please don't add more bad module parameter strings. The KNI author did something no other kernel modules do with tabs and double spacing, stop this bogus stuff. Is there any reason you have to use KNI at all. KNI is broken on many levels and is not fixable. What about virtio or tap?