From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31611A034E; Thu, 20 Jan 2022 17:45:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 003C842705; Thu, 20 Jan 2022 17:45:08 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id D9CA840042 for ; Thu, 20 Jan 2022 17:45:07 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id c5so5767265pgk.12 for ; Thu, 20 Jan 2022 08:45:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qNiveLUmEgfwZVA6bnO1RQttYign6ddbN2rFMAvPF/4=; b=LkNgQLW49vhseF4R/rbSQiGixenR7NJ/+SqB08auTO1EzDC4lokvuRg3ECFEW/7H7B 3I3q2IweLpYxqgXnkfoI5nABJHNVU/EmOmpt070aMgq1KBjyakPbSkNuYZjTqu/njKet hB1e2r2ufSE4BQTLBYDEBtqhXDmvafCdloecIBKPZDVk+89w24iThGwgYg+sK6c5cA/4 6m2dZSoXlPlWrPZalZ2LnuVqOI42MYoj8j40JHFkJ9xgYnr37sNJUhKennwlXtapkYZ5 D435J6hdwIZZIqYYkhKiuuxt1oSh+lVQhc2P1e/iJ5guHgIy8fzkaODnTtbyRNvNtcCH FTgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qNiveLUmEgfwZVA6bnO1RQttYign6ddbN2rFMAvPF/4=; b=xScikS0iUEJxlaaN1bXhz4Lrgmjhfpk9jl9ZS9V78zx47KA780SrUYccmoASfu/fak muMLW90SNaKWg9QBYwKJjuxF8GRYVLMq+l22+kyRsCRo+6sgjk2GkVePLsB670e0HZcu cjKMUYMZ9jtdrMHa82i1tIwH2O+FKR89psMou7xyQBHvrYeF4qzXapzCoJnG+q5ekgAG W8ev6l2WR5AEoDcZTJ9HMmACjlakqaK0gzcaYKzqeD0N8BK8XVD+a4PRGqpqhv/5aPVT /VhE0vWpAlljr0GkqKewkyaCKhPq222wBHyolJjAorktH9GP7Em14caggqwCI0nMkpWY 3SoQ== X-Gm-Message-State: AOAM531V2Xjq32c+NGlvnl3fGE6qyVXQghIafQr/dXUx7+lxEHgj5aAV vyUN+Vo/41g3BicWL5P6D51+hw== X-Google-Smtp-Source: ABdhPJyOloIEGiUVM3hDwwMvjfeZKeflfltGFQQS2b02PsuirJTfdzbY64jH9ZynTIfVfG/OW4nNvA== X-Received: by 2002:a63:7f53:: with SMTP id p19mr32341347pgn.321.1642697105643; Thu, 20 Jan 2022 08:45:05 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id h9sm3968500pfi.54.2022.01.20.08.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 08:45:05 -0800 (PST) Date: Thu, 20 Jan 2022 08:45:02 -0800 From: Stephen Hemminger To: Akhil Goyal Cc: , , , , , , , , , , , , Subject: Re: [PATCH v2 1/4] ethdev: introduce IP reassembly offload Message-ID: <20220120084502.7e5eb2c5@hermes.local> In-Reply-To: <20220120162627.4155695-2-gakhil@marvell.com> References: <20220103150813.1694888-1-gakhil@marvell.com> <20220120162627.4155695-1-gakhil@marvell.com> <20220120162627.4155695-2-gakhil@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 20 Jan 2022 21:56:24 +0530 Akhil Goyal wrote: > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice. > + * > + * A structure used to set IP reassembly configuration. > + * > + * If RTE_ETH_RX_OFFLOAD_IP_REASSEMBLY flag is set in offloads field, > + * the PMD will attempt IP reassembly for the received packets as per > + * properties defined in this structure: > + * > + */ > +struct rte_eth_ip_reass_params { > + /** Maximum time in ms which PMD can wait for other fragments. */ > + uint32_t reass_timeout; > + /** Maximum number of fragments that can be reassembled. */ > + uint16_t max_frags; > + /** > + * Flags to enable reassembly of packet types - > + * RTE_ETH_DEV_REASSEMBLY_F_xxx. > + */ > + uint16_t flags; > +}; > + Actually, this is not experimental. You are embedding this in dev_info and dev_info is not experimental; therefore the reassembly parameters can never change without breaking ABI of dev_info.