From: Stephen Hemminger <stephen@networkplumber.org>
To: Wei Huang <wei.huang@intel.com>
Cc: dev@dpdk.org, rosen.xu@intel.com, qi.z.zhang@intel.com,
stable@dpdk.org, tianfei.zhang@intel.com, ferruh.yigit@intel.com,
david.marchand@redhat.com
Subject: Re: [PATCH v5] raw/ifpga: fix pthread cannot join
Date: Fri, 21 Jan 2022 08:19:56 -0800 [thread overview]
Message-ID: <20220121081956.4837e66a@hermes.local> (raw)
In-Reply-To: <20220121033246.10339-1-wei.huang@intel.com>
On Thu, 20 Jan 2022 22:32:46 -0500
Wei Huang <wei.huang@intel.com> wrote:
> @@ -497,7 +497,7 @@ static int set_surprise_link_check_aer(
> int gsd_enable, ret;
> #define MS 1000
>
> - while (1) {
> + while (rte_atomic32_read(&ifpga_monitor_start)) {
Better, but rte_atomic is deprecated in favor of using __atomic builtin
instead. This is because there are more options possible with
__atomic_load_n than rte_atomic32_read. rte_atomic32_read has to assume
worst case memory ordering, and your example relaxed memory ordering is
what you need.
prev parent reply other threads:[~2022-01-21 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220121012932.9827-1-wei.huang>
2022-01-21 3:32 ` Wei Huang
2022-01-21 16:19 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121081956.4837e66a@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
--cc=wei.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).