* [dpdk-dev] [PATCH] common/cnxk: fix missing RTE Flow counter deletion
@ 2022-01-25 4:15 psatheesh
2022-02-17 6:36 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: psatheesh @ 2022-01-25 4:15 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul, stable, Jerin Jacob Kollanukkaran
From: Satheesh Paul <psatheesh@marvell.com>
Added code to clear and delete counters upon flow deletion.
Fixes: a07f7ced43 ("common/cnxk: add NPC init and fini")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
---
drivers/common/cnxk/roc_npc.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
index e3961bfbc6..df3016f538 100644
--- a/drivers/common/cnxk/roc_npc.c
+++ b/drivers/common/cnxk/roc_npc.c
@@ -1259,6 +1259,16 @@ roc_npc_flow_destroy(struct roc_npc *roc_npc, struct roc_npc_flow *flow)
return rc;
}
+ if (flow->ctr_id != NPC_COUNTER_NONE) {
+ rc = roc_npc_mcam_clear_counter(roc_npc, flow->ctr_id);
+ if (rc != 0)
+ return rc;
+
+ rc = npc_mcam_free_counter(npc, flow->ctr_id);
+ if (rc != 0)
+ return rc;
+ }
+
rc = npc_mcam_free_entry(npc, flow->mcam_id);
if (rc != 0)
return rc;
--
2.25.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] common/cnxk: fix missing RTE Flow counter deletion
2022-01-25 4:15 [dpdk-dev] [PATCH] common/cnxk: fix missing RTE Flow counter deletion psatheesh
@ 2022-02-17 6:36 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2022-02-17 6:36 UTC (permalink / raw)
To: Satheesh Paul, Ferruh Yigit
Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao,
dpdk-dev, dpdk stable, Jerin Jacob Kollanukkaran
On Tue, Jan 25, 2022 at 9:45 AM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Added code to clear and delete counters upon flow deletion.
>
> Fixes: a07f7ced43 ("common/cnxk: add NPC init and fini")
> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Updated the comment as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks
common/cnxk: fix flow deletion
When a flow is deleted, the counters are deleted without
being cleared first. This results in counter values being
retained and shown in flows created later. Hence, counter
is cleared before being deleted.
Updated driver to clear and delete counters upon flow deletion.
Fixes: a07f7ced43 ("common/cnxk: add NPC init and fini")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> ---
> drivers/common/cnxk/roc_npc.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
> index e3961bfbc6..df3016f538 100644
> --- a/drivers/common/cnxk/roc_npc.c
> +++ b/drivers/common/cnxk/roc_npc.c
> @@ -1259,6 +1259,16 @@ roc_npc_flow_destroy(struct roc_npc *roc_npc, struct roc_npc_flow *flow)
> return rc;
> }
>
> + if (flow->ctr_id != NPC_COUNTER_NONE) {
> + rc = roc_npc_mcam_clear_counter(roc_npc, flow->ctr_id);
> + if (rc != 0)
> + return rc;
> +
> + rc = npc_mcam_free_counter(npc, flow->ctr_id);
> + if (rc != 0)
> + return rc;
> + }
> +
> rc = npc_mcam_free_entry(npc, flow->mcam_id);
> if (rc != 0)
> return rc;
> --
> 2.25.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-17 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 4:15 [dpdk-dev] [PATCH] common/cnxk: fix missing RTE Flow counter deletion psatheesh
2022-02-17 6:36 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).