DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [PATCH v2 8/9] vhost: differentiate IOTLB logs
Date: Tue, 25 Jan 2022 12:24:56 +0100	[thread overview]
Message-ID: <20220125112457.166434-9-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20220125112457.166434-1-maxime.coquelin@redhat.com>

Same logging messages were used for both IOTLB cache
insertion failure and IOTLB pending insertion failure.

This patch differentiate them to ease logs analysis.

Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 lib/vhost/iotlb.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c
index afa86d7c2b..adc426612a 100644
--- a/lib/vhost/iotlb.c
+++ b/lib/vhost/iotlb.c
@@ -70,7 +70,8 @@ vhost_user_iotlb_pending_insert(struct virtio_net *dev, struct vhost_virtqueue *
 
 	ret = rte_mempool_get(vq->iotlb_pool, (void **)&node);
 	if (ret) {
-		VHOST_LOG_CONFIG(DEBUG, "(%s) IOTLB pool %s empty, clear entries\n",
+		VHOST_LOG_CONFIG(DEBUG,
+				"(%s) IOTLB pool %s empty, clear entries for pending insertion\n",
 				dev->ifname, vq->iotlb_pool->name);
 		if (!TAILQ_EMPTY(&vq->iotlb_pending_list))
 			vhost_user_iotlb_pending_remove_all(vq);
@@ -78,7 +79,8 @@ vhost_user_iotlb_pending_insert(struct virtio_net *dev, struct vhost_virtqueue *
 			vhost_user_iotlb_cache_random_evict(vq);
 		ret = rte_mempool_get(vq->iotlb_pool, (void **)&node);
 		if (ret) {
-			VHOST_LOG_CONFIG(ERR, "(%s) IOTLB pool %s still empty, failure\n",
+			VHOST_LOG_CONFIG(ERR,
+					"(%s) IOTLB pool %s still empty, prending insertion failure\n",
 					dev->ifname, vq->iotlb_pool->name);
 			return;
 		}
@@ -167,7 +169,8 @@ vhost_user_iotlb_cache_insert(struct virtio_net *dev, struct vhost_virtqueue *vq
 
 	ret = rte_mempool_get(vq->iotlb_pool, (void **)&new_node);
 	if (ret) {
-		VHOST_LOG_CONFIG(DEBUG, "(%s) IOTLB pool %s empty, clear entries\n",
+		VHOST_LOG_CONFIG(DEBUG,
+				"(%s) IOTLB pool %s empty, clear entries for cache insertion\n",
 				dev->ifname, vq->iotlb_pool->name);
 		if (!TAILQ_EMPTY(&vq->iotlb_list))
 			vhost_user_iotlb_cache_random_evict(vq);
@@ -175,7 +178,8 @@ vhost_user_iotlb_cache_insert(struct virtio_net *dev, struct vhost_virtqueue *vq
 			vhost_user_iotlb_pending_remove_all(vq);
 		ret = rte_mempool_get(vq->iotlb_pool, (void **)&new_node);
 		if (ret) {
-			VHOST_LOG_CONFIG(ERR, "(%s) IOTLB pool %s still empty, failure\n",
+			VHOST_LOG_CONFIG(ERR,
+					"(%s) IOTLB pool %s still empty, cache insertion failed\n",
 					dev->ifname, vq->iotlb_pool->name);
 			return;
 		}
-- 
2.34.1


  parent reply	other threads:[~2022-01-25 11:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 11:24 [PATCH v2 0/9] vhost: improve logging Maxime Coquelin
2022-01-25 11:24 ` [PATCH v2 1/9] vhost: improve IOTLB logs Maxime Coquelin
2022-01-26  3:26   ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 2/9] vhost: improve vDPA registration failure log Maxime Coquelin
2022-01-26  3:26   ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 3/9] vhost: improve Vhost layer logs Maxime Coquelin
2022-01-26  3:26   ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 4/9] vhost: improve Vhost-user " Maxime Coquelin
2022-01-26  3:26   ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 5/9] vhost: improve socket " Maxime Coquelin
2022-01-26  3:26   ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 6/9] vhost: improve Virtio-net " Maxime Coquelin
2022-01-26  3:26   ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 7/9] vhost: remove multi-line logs Maxime Coquelin
2022-01-26  3:27   ` Xia, Chenbo
2022-01-26  9:30     ` Maxime Coquelin
2022-01-25 11:24 ` Maxime Coquelin [this message]
2022-01-26  3:27   ` [PATCH v2 8/9] vhost: differentiate IOTLB logs Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 9/9] vhost: use proper logging type for data path Maxime Coquelin
2022-01-26  3:27   ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220125112457.166434-9-maxime.coquelin@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).