* [PATCH] devtools: fix comment detection in forbidden token check
@ 2022-01-27 10:55 David Marchand
2022-01-27 16:20 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2022-01-27 10:55 UTC (permalink / raw)
To: dev; +Cc: stable, Thomas Monjalon, Stephen Hemminger, Arnon Warshavsky
After a comment section was detected, passing to a new hunk was not seen
as ending the section and all subsequent hunks were ignored.
Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs")
Cc: stable@dpdk.org
Reported-by: Thomas Monjalon <thomas@monjalon.net>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-forbidden-tokens.awk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/devtools/check-forbidden-tokens.awk b/devtools/check-forbidden-tokens.awk
index 61ba707c9b..026844141c 100755
--- a/devtools/check-forbidden-tokens.awk
+++ b/devtools/check-forbidden-tokens.awk
@@ -20,6 +20,9 @@ BEGIN {
# state machine assumes the comments structure is enforced by
# checkpatches.pl
(in_file) {
+ if ($0 ~ "^@@") {
+ in_comment = 0
+ }
# comment start
if (index($0,comment_start) > 0) {
in_comment = 1
--
2.23.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] devtools: fix comment detection in forbidden token check
2022-01-27 10:55 [PATCH] devtools: fix comment detection in forbidden token check David Marchand
@ 2022-01-27 16:20 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2022-01-27 16:20 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stable, Stephen Hemminger, Arnon Warshavsky
27/01/2022 11:55, David Marchand:
> After a comment section was detected, passing to a new hunk was not seen
> as ending the section and all subsequent hunks were ignored.
>
> Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs")
> Cc: stable@dpdk.org
>
> Reported-by: Thomas Monjalon <thomas@monjalon.net>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-27 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-27 10:55 [PATCH] devtools: fix comment detection in forbidden token check David Marchand
2022-01-27 16:20 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).